New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 774773 link

Starred by 6 users
Status: Verified
Owner:
beccahughes@chromium.org
Closed: Oct 2017
Cc:
qin...@chromium.org
█ sandeepkumars@chromium.org
nyerramilli@chromium.org
rbasuvula@chromium.org
beccahughes@chromium.org
ligim...@chromium.org
█ msrchandra@chromium.org
candr...@chromium.org
dtrainor@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Line is overlapping speaker in the YouTube web player

Project Member Reported by mar...@mwiacek.com, Oct 14 2017 
Example URL:
http://joemonster.org/filmy/86640/Ojciec_podczas_spaceru_z_synem_wsiada_do_przypadkowego_porsche

Steps to reproduce the problem:
1. open page
2. click on play
3. try to drag point showing position in video - it can be moved and after resume blue line is overlapping speaker

What is the expected behavior?
Line is not overlapping speaker

What went wrong?
In stable version dragging is not possible

Does it occur on multiple sites: Yes

Is it a problem with a plugin? N/A 

Did this work before? Yes Stable 61.0.3163.98

Does this work in other browsers? Yes

Chrome version: 63.0.3236.6  Channel: beta
OS Version: 7
Flash Version:
Screenshot_20171014-112218.png
1.2 MB View Download

Comment 1 by nyerramilli@chromium.org, Oct 16 2017

Labels: Needs-triage-Mobile Needs-Bisect

Comment 2 by sandeepkumars@chromium.org, Oct 16 2017

Cc: msrchandra@chromium.org nyerramilli@chromium.org ligim...@chromium.org candr...@chromium.org sandeepkumars@chromium.org
Labels: -Type-Bug -Pri-2 ReleaseBlock-Stable Triaged-Mobile Pri-1 Type-Bug-Regression
Owner: beccahughes@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue in Android, make sure to enable Showing download when online Flag. Observed seeking bar is overlapped with the volume icon.

Steps Followed:
1. Launched Browser
2. Navigated to http://joemonster.org/filmy/86640/Ojciec_podczas_spaceru_z_synem_wsiada_do_przypadkowego_porsche
3. Observed seeking bar is overlapped with the volume icon.

Chrome versions tested:
63.0.3236.6, 63.0.3239.0

OS
Android 7.1.2

Android Devices
7.1.2 Pixel XL Build/N2G48E

Below is the bisect info
=======================

Chrome Good Build -- 63.0.3226.0
Chrome Bad Build  -- 63.0.3227.0

https://chromium.googlesource.com/chromium/src/+log/63.0.3226.0..63.0.3227.0?pretty=fuller&n=10000

Results from pre revision bisect --
You are looking for a change made after 504965(GOOD), but before 504966(BAD).

From the above revision range suspecting the following --
https://chromium.googlesource.com/chromium/src/+/46fb5c855a8622fe73a5c8000b7370407b9122af

@beccahughes -- Could you please look into the issue, kindly re-assign if this is not related to your changes.

Please navigate to below link for log's and video--
go/chrome-androidlogs/774773

Adding Release Block Stable as this is a recent Regression broken in M63. Remove if not required.

Note: This issue is not observed in Desktop.

Thanks!!

Comment 3 by kojii@chromium.org, Oct 16 2017

Components: -Blink Blink>Media>Controls
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/279fd7acf9b1c1463d1b88618c0a20d29d0e653d

commit 279fd7acf9b1c1463d1b88618c0a20d29d0e653d
Author: Becca Hughes <beccahughes@chromium.org>
Date: Mon Oct 16 11:42:55 2017

Reland "Media Controls: Fix timeline zoom factor"

This is a reland of f707b5e77a29503574c97c35188bf8c9350d7934

The change was reverted because controls-page-zoom* was flaking.
This changes those tests from Pixel+Layout tests to layout only.

Original change's description:
> Media Controls: Fix timeline zoom factor
> 
> This fixes cases where the user zooms in or out and the timeline
> is not scaled correctly. Also hides overflowing content from the
> timeline in case something does go wrong.
> 
> BUG= 771140 ,771880
> 
> Change-Id: I10bc36f336f5607c5df4d8a7824138bed7f08a0f
> Reviewed-on: https://chromium-review.googlesource.com/707062
> Commit-Queue: Becca Hughes <beccahughes@chromium.org>
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#507992}

Bug:  771140 , 771880,  774773 
Change-Id: Ifd6cee02081acc2d77c3916544844689b684272e
Reviewed-on: https://chromium-review.googlesource.com/715257
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509022}
[modify] https://crrev.com/279fd7acf9b1c1463d1b88618c0a20d29d0e653d/content/shell/test_runner/test_runner.cc
[add] https://crrev.com/279fd7acf9b1c1463d1b88618c0a20d29d0e653d/third_party/WebKit/LayoutTests/media/controls/controls-page-zoom-in.html
[add] https://crrev.com/279fd7acf9b1c1463d1b88618c0a20d29d0e653d/third_party/WebKit/LayoutTests/media/controls/controls-page-zoom-out.html
[add] https://crrev.com/279fd7acf9b1c1463d1b88618c0a20d29d0e653d/third_party/WebKit/LayoutTests/platform/mac/media/controls/controls-page-zoom-in-expected.txt
[add] https://crrev.com/279fd7acf9b1c1463d1b88618c0a20d29d0e653d/third_party/WebKit/LayoutTests/platform/mac/media/controls/controls-page-zoom-out-expected.txt
[add] https://crrev.com/279fd7acf9b1c1463d1b88618c0a20d29d0e653d/third_party/WebKit/LayoutTests/platform/mac/virtual/new-remote-playback-pipeline/media/controls/controls-page-zoom-in-expected.txt
[add] https://crrev.com/279fd7acf9b1c1463d1b88618c0a20d29d0e653d/third_party/WebKit/LayoutTests/platform/mac/virtual/new-remote-playback-pipeline/media/controls/controls-page-zoom-out-expected.txt
[add] https://crrev.com/279fd7acf9b1c1463d1b88618c0a20d29d0e653d/third_party/WebKit/LayoutTests/platform/win/media/controls/controls-page-zoom-in-expected.txt
[add] https://crrev.com/279fd7acf9b1c1463d1b88618c0a20d29d0e653d/third_party/WebKit/LayoutTests/platform/win/media/controls/controls-page-zoom-out-expected.txt
[add] https://crrev.com/279fd7acf9b1c1463d1b88618c0a20d29d0e653d/third_party/WebKit/LayoutTests/platform/win/virtual/new-remote-playback-pipeline/media/controls/controls-page-zoom-in-expected.txt
[add] https://crrev.com/279fd7acf9b1c1463d1b88618c0a20d29d0e653d/third_party/WebKit/LayoutTests/platform/win/virtual/new-remote-playback-pipeline/media/controls/controls-page-zoom-out-expected.txt
[modify] https://crrev.com/279fd7acf9b1c1463d1b88618c0a20d29d0e653d/third_party/WebKit/Source/modules/media_controls/elements/MediaControlSliderElement.cpp
[modify] https://crrev.com/279fd7acf9b1c1463d1b88618c0a20d29d0e653d/third_party/WebKit/Source/modules/media_controls/elements/MediaControlSliderElement.h
[modify] https://crrev.com/279fd7acf9b1c1463d1b88618c0a20d29d0e653d/third_party/WebKit/Source/modules/media_controls/resources/legacyMediaControls.css

Comment 5 by beccahughes@chromium.org, Oct 16 2017

Status: Started (was: Assigned)
This should be fixed now. @sandeepkumars - please can you confirm?

Comment 6 by msrchandra@chromium.org, Oct 16 2017

Labels: -Needs-Bisect M-63

Comment 7 by sandeepkumars@chromium.org, Oct 17 2017

Labels: hasbisect-per-revision

Comment 8 by sandeepkumars@chromium.org, Oct 17 2017 

Tested the issue using 64.0.3242.0 on 7.1.2 Pixel XL Build/N2G48E and the issue is working as expected now.

Observed the seeking bar is no more overlapping with the volume icon.

Thanks!!

Comment 9 by beccahughes@chromium.org, Oct 17 2017

Labels: Merge-Request-63

Comment 10 by beccahughes@chromium.org, Oct 17 2017 

Issue 771880 has been merged into this issue.

Comment 11 by beccahughes@chromium.org, Oct 17 2017

Cc: beccahughes@chromium.org dtrainor@chromium.org rbasuvula@chromium.org qin...@chromium.org
 Issue 774820  has been merged into this issue.
Project Member

Comment 12 by sheriffbot@chromium.org, Oct 18 2017

Labels: -Merge-Request-63 Hotlist-Merge-Approved Merge-Approved-63
Your change meets the bar and is auto-approved for M63. Please go ahead and merge the CL to branch 3239 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 13 by bugdroid1@chromium.org, Oct 18 2017

Labels: -merge-approved-63 merge-merged-3239
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f54cb9676beffb6bb04ac11ef6b7874d84fc050

commit 7f54cb9676beffb6bb04ac11ef6b7874d84fc050
Author: Becca Hughes <beccahughes@chromium.org>
Date: Wed Oct 18 08:40:37 2017

Reland "Media Controls: Fix timeline zoom factor"

This is a reland of f707b5e77a29503574c97c35188bf8c9350d7934

The change was reverted because controls-page-zoom* was flaking.
This changes those tests from Pixel+Layout tests to layout only.

Original change's description:
> Media Controls: Fix timeline zoom factor
> 
> This fixes cases where the user zooms in or out and the timeline
> is not scaled correctly. Also hides overflowing content from the
> timeline in case something does go wrong.
> 
> BUG= 771140 ,771880
> 
> Change-Id: I10bc36f336f5607c5df4d8a7824138bed7f08a0f
> Reviewed-on: https://chromium-review.googlesource.com/707062
> Commit-Queue: Becca Hughes <beccahughes@chromium.org>
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#507992}

Bug:  771140 , 771880,  774773 
Change-Id: Ifd6cee02081acc2d77c3916544844689b684272e
Reviewed-on: https://chromium-review.googlesource.com/715257
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#509022}(cherry picked from commit 279fd7acf9b1c1463d1b88618c0a20d29d0e653d)
Reviewed-on: https://chromium-review.googlesource.com/725459
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#49}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[modify] https://crrev.com/7f54cb9676beffb6bb04ac11ef6b7874d84fc050/content/shell/test_runner/test_runner.cc
[add] https://crrev.com/7f54cb9676beffb6bb04ac11ef6b7874d84fc050/third_party/WebKit/LayoutTests/media/controls/controls-page-zoom-in.html
[add] https://crrev.com/7f54cb9676beffb6bb04ac11ef6b7874d84fc050/third_party/WebKit/LayoutTests/media/controls/controls-page-zoom-out.html
[add] https://crrev.com/7f54cb9676beffb6bb04ac11ef6b7874d84fc050/third_party/WebKit/LayoutTests/platform/mac/media/controls/controls-page-zoom-in-expected.txt
[add] https://crrev.com/7f54cb9676beffb6bb04ac11ef6b7874d84fc050/third_party/WebKit/LayoutTests/platform/mac/media/controls/controls-page-zoom-out-expected.txt
[add] https://crrev.com/7f54cb9676beffb6bb04ac11ef6b7874d84fc050/third_party/WebKit/LayoutTests/platform/mac/virtual/new-remote-playback-pipeline/media/controls/controls-page-zoom-in-expected.txt
[add] https://crrev.com/7f54cb9676beffb6bb04ac11ef6b7874d84fc050/third_party/WebKit/LayoutTests/platform/mac/virtual/new-remote-playback-pipeline/media/controls/controls-page-zoom-out-expected.txt
[add] https://crrev.com/7f54cb9676beffb6bb04ac11ef6b7874d84fc050/third_party/WebKit/LayoutTests/platform/win/media/controls/controls-page-zoom-in-expected.txt
[add] https://crrev.com/7f54cb9676beffb6bb04ac11ef6b7874d84fc050/third_party/WebKit/LayoutTests/platform/win/media/controls/controls-page-zoom-out-expected.txt
[add] https://crrev.com/7f54cb9676beffb6bb04ac11ef6b7874d84fc050/third_party/WebKit/LayoutTests/platform/win/virtual/new-remote-playback-pipeline/media/controls/controls-page-zoom-in-expected.txt
[add] https://crrev.com/7f54cb9676beffb6bb04ac11ef6b7874d84fc050/third_party/WebKit/LayoutTests/platform/win/virtual/new-remote-playback-pipeline/media/controls/controls-page-zoom-out-expected.txt
[modify] https://crrev.com/7f54cb9676beffb6bb04ac11ef6b7874d84fc050/third_party/WebKit/Source/modules/media_controls/elements/MediaControlSliderElement.cpp
[modify] https://crrev.com/7f54cb9676beffb6bb04ac11ef6b7874d84fc050/third_party/WebKit/Source/modules/media_controls/elements/MediaControlSliderElement.h
[modify] https://crrev.com/7f54cb9676beffb6bb04ac11ef6b7874d84fc050/third_party/WebKit/Source/modules/media_controls/resources/legacyMediaControls.css

Comment 14 by beccahughes@chromium.org, Oct 18 2017

Status: Verified (was: Started)

Comment 15 by beccahughes@chromium.org, Oct 20 2017

Cc: ranjitkan@chromium.org
 Issue 771140  has been merged into this issue.

Comment 16 by sandeepkumars@chromium.org, Oct 24 2017 

 Issue 777413  has been merged into this issue.

Comment 17 by kgna...@chromium.org, Oct 24 2017 

Woks fine as per expected behavior, Issue verified on 63.0.3239.17
►

Sign in to add a comment