* virtual/gpu/fast/canvas/canvas-text-baseline.html * virtual/gpu/fast/canvas/canvas-transforms-during-path.html * virtual/gpu/fast/canvas/quadraticCurveTo.xml have started failing with image diffs in: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11/builds/24462 https://build.chromium.org/p/chromium.mac/builders/Mac10.12%20Tests/builds/6256 https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/24959 Looking at the blamelist for 10.11, the only thing that seems relevant is the Skia roll in https://chromium-review.googlesource.com/719419. The image diff seems to be just a few pixels - I can't really see any visual difference. It's EOD Friday, so I'm assigning to the Skia sheriff that starts on Monday, and CCing the current one.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/66bbae03450888a010a089dd3c1a0a3470d05e2e commit 66bbae03450888a010a089dd3c1a0a3470d05e2e Author: Alex Moshchuk <alexmos@chromium.org> Date: Sat Oct 14 01:29:47 2017 Disable three failing virtual/gpu/fast/canvas tests for Mac. NOTRY=true Bug: 774751 Change-Id: I6d13a229fe57564914c2663a6c37b977c2d2d600 TBR: benjaminwagner@google.com Reviewed-on: https://chromium-review.googlesource.com/720144 Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#508904} [modify] https://crrev.com/66bbae03450888a010a089dd3c1a0a3470d05e2e/third_party/WebKit/LayoutTests/TestExpectations
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/01113f28586141cba9a44aed0fc54bafaab17fb2 commit 01113f28586141cba9a44aed0fc54bafaab17fb2 Author: Ben Wagner <benjaminwagner@google.com> Date: Tue Oct 24 16:43:33 2017 Rebaseline for Skia roll. Bug 774751 blames this on https://chromium-review.googlesource.com/c/chromium/src/+/719419, which contains 48 Skia commits. I don't know which of those 48 caused the diffs, but they are imperceptible, so I'm not sure we care. Bug: 774751 Change-Id: I1b56b24759c0c5d77b9fe689453155d811d19ba9 Reviewed-on: https://chromium-review.googlesource.com/733861 Reviewed-by: Mike Klein <mtklein@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#511174} [modify] https://crrev.com/01113f28586141cba9a44aed0fc54bafaab17fb2/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/01113f28586141cba9a44aed0fc54bafaab17fb2/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu/fast/canvas/canvas-text-baseline-expected.png [modify] https://crrev.com/01113f28586141cba9a44aed0fc54bafaab17fb2/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu/fast/canvas/canvas-transforms-during-path-expected.png [modify] https://crrev.com/01113f28586141cba9a44aed0fc54bafaab17fb2/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu/fast/canvas/quadraticCurveTo-expected.png
Comment 1 by alex...@chromium.org
, Oct 14 2017