New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 774741 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 765834



Sign in to add a comment

Blacklist a OWNERS file

Project Member Reported by aarya@google.com, Oct 14 2017

Issue description

Comment 1 by aarya@google.com, Oct 14 2017

Cc: mbarbe...@chromium.org st...@chromium.org
Also,see why skia was not suggested in https://bugs.chromium.org/p/chromium/issues/detail?id=772684
Can we just delete this specific component or we still want to keep it in OWNERS file?
Cc: -mbarbe...@chromium.org kateso...@chromium.org
Owner: mbarbe...@chromium.org
I'm removing that CL from the OWNERS file for now since presumably it could cause confusion with manual triage as well, but on some level it was right (made sense for the top level directory, but not the subdirectory for fuzzers). I'm not sure how much we want to complicate this process, but there may be some discussion worth having on additional blacklisting or fine-grained owner comments (along the lines of set noparent) so we could keep components like this.
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54ccc285b04e5d8b9d98f9b3111b451ec5cfabca

commit 54ccc285b04e5d8b9d98f9b3111b451ec5cfabca
Author: Martin Barbella <mbarbella@chromium.org>
Date: Tue Oct 17 18:39:41 2017

Remove component from testing/libfuzzer/OWNERS.

Though the component is somewhat reasonable for the documentation,
scripts, and other general things, it doesn't make sense for the
fuzzers themselves. This is causing issues with automatic
component assignment, and could cause confusion during manual
triage. Until we have a better solution, we should remove this.

R=inferno@chromium.org,mmoroz@chromium.org

Bug:  774741 
Change-Id: Ia5474fd91e9fbc32d4306565f6058d6f519f26d7
Reviewed-on: https://chromium-review.googlesource.com/723644
Commit-Queue: Martin Barbella <mbarbella@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509443}
[modify] https://crrev.com/54ccc285b04e5d8b9d98f9b3111b451ec5cfabca/testing/libfuzzer/OWNERS

Status: Fixed (was: Assigned)
Discussed this yesterday and decided that we probably don't want to introduce a blacklist for specific OWNERS file entries in the predator side. If we'd be doing that, it seems like there are deeper problems. Feel free to reopen if you think there's still work to do here.
Cc: mbarbe...@chromium.org
 Issue 772717  has been merged into this issue.

Sign in to add a comment