New issue
Advanced search Search tips

Issue 774730 link

Starred by 2 users
Status: Assigned
Owner:
mdjones@chromium.org
Cc:
yus...@chromium.org
tedc...@chromium.org
peconn@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Support tab reparenting without view intent

Project Member Reported by mdjones@chromium.org, Oct 13 2017 
We should support the ability to detach and reattach a tab without using a view intent. Ideally we can detach the entire tab model so we don't have 'floating tabs' and can preserve tab order. This can take shape in the form of an in-memory cache that the browser can pull from at [re]startup.

This is particularly useful for instances like the Chrome Home promo where we would like to preserve a tab through an activity restart.

Comment 1 by yus...@chromium.org, Oct 13 2017

Cc: peconn@chromium.org
Makes sense to me. Actually Peter has been investigating a new way to reparent a tab after the new Activity has been created for FullscreenActivity.

There is nothing inherently constraining reparenting to work without a VIEW intent launch. All we need are two activities, one with the tab we want to move to the other one. Initially, VIEW intents became part of the logic mostly for synchronizing the eventual Activity launch with the attaching, but yes, this might actually help us do a bit of a cleanup as well.

Comment 2 by peconn@chromium.org, Oct 16 2017 

Yeah, I've done some work in this CL: https://chromium-review.googlesource.com/c/chromium/src/+/632686 . I'd be very happy to chat or see if my work can be changed into something more clean/general.

Comment 3 by msrchandra@chromium.org, Oct 16 2017

Labels: Needs-triage-Mobile

Comment 4 by mdjones@chromium.org, Oct 16 2017

Status: Available (was: Untriaged)

Comment 5 by benhenry@chromium.org, Aug 1

Status: Assigned (was: Available)
►

Sign in to add a comment