Cbuildbot stage names in Milo.BuildInfo and CIDB are inconsistent. |
||||||||||
Issue description
We'd like some easier to process data from Milo.BuildInfo cbuildbot stages, as we are depending more on the API to fill in our build details page.
Here is an example for a current build stage in the API result:
"step": {
"name": "VMTest (attempt 1) : [SKIPPED]",
"status": "SUCCESS",
"stdoutStream": {
"name": "recipes/steps/VMTest__attempt_1__:__SKIPPED_/0/stdout"
},
"started": "2017-07-24T01:02:49.097813829Z",
"ended": "2017-07-24T01:02:49.098639964Z"
}
(for more example, see http://shortn/_O8k3d6RA8V)
The proposed changes are:
1. Put only the stage name in the name field. In the above example, that is getting rid of the (attemp 1) : [SKIPPED]",
2. Stage name should either be the same as they are in CIDB, or stage should have a field that tells us the CIDB id for the stage, so that we can easily cross-reference to get more accurate time.
2. We should be able to use stage name as an id for a build stage for our UI purpose, so they should be unique (e.g, no two CommitQueueSync stages for the same build)
3. Status should reflect the real status of the stage. In the above example, it should be "skipped" as opposed to "success".
Let me know how this sound :-)
,
Oct 30 2017
,
Oct 30 2017
I don't think cbuildbot has any control over how these results are formatted.
,
Nov 1 2017
I misunderstood the first time I scanned this. That stage name is controlled by cbuildbot, and is currently being emitted as a tag. I haven't yet compared to CIDB. What, exactly, would you expect the stage name to be? We have several definitions for them. "VMTest (attempt 1) : [SKIPPED]", "VMTest (attempt 1)", or "VMTest"? The final format would not be unique across all builds.
,
Nov 1 2017
The uniqueID is no longer a requirement as we work around it by assigning it some IDs when we display the graph. The main thing is to being able to find a CIDB build stage reliably, if exist. And know if a CIDB stage doesn't exist. It would also be nice to have a cleaner stage name(the same name to ones in CIDB) and an accurate status.
,
Nov 1 2017
,
Nov 1 2017
Based on an IM conversation.... CIDB currently contains "VMTest", which is considered important for metrics. How about we create a new column is the CIDB stage table called "display_name" which will contain the named formatted as whatever we gave BuildInfo, for example: "VMTest (attempt 1) : [SKIPPED]". Be aware that that field would not be populated for old branches.
,
Nov 1 2017
,
Mar 30 2018
,
Mar 30 2018
,
Jun 8 2018
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by jinjingl@chromium.org
, Oct 13 2017