New issue
Advanced search Search tips

Issue 774716 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 711468



Sign in to add a comment

[root layer scrolls] failures in printing/...

Project Member Reported by szager@chromium.org, Oct 13 2017

Issue description

With RLS enabled, the root layer is 800x600, which is incorrect for printing layout.  Affected tests:

printing/absolute-position-headers-and-footers.html
printing/ellipsis-printing-style.html
printing/fixed-positioned-but-static-headers-and-footers.html
printing/fixed-positioned-headers-and-footers-absolute-covering-some-pages.html
printing/fixed-positioned-headers-and-footers-clipped.html
printing/fixed-positioned-headers-and-footers-inside-transform.html
printing/fixed-positioned-headers-and-footers-larger-than-page.html
printing/fixed-positioned-headers-and-footers.html
printing/forced-break-tree-dump-only.html
printing/iframe-print.html
printing/list-item-with-empty-first-line.html
printing/quirks-percentage-height-body.html
printing/quirks-percentage-height.html
printing/simultaneous-position-float-change.html
printing/standards-percentage-heights.html
printing/subframes-percentage-height.html
printing/tfoot-repeats-at-bottom-of-each-page-multiple-tables.html
printing/tfoot-repeats-at-bottom-of-each-page.html
printing/thead-repeats-at-top-of-each-page-multiple-tables.html
printing/thead-repeats-at-top-of-each-page.html
printing/webgl-oversized-printing.html
 

Comment 1 by e...@chromium.org, Oct 14 2017

Status: Available (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/290b2ac7af255d3364d0b070ce58a34c33e63d34

commit 290b2ac7af255d3364d0b070ce58a34c33e63d34
Author: Stefan Zager <szager@chromium.org>
Date: Mon Oct 23 22:30:26 2017

[root layer scrolls] Fix printing

When printing, the root layer should not have scrollbars, and it should
not clip its overflow.

Bug:  774716 , 774716 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I4d5ecd8cf944a5870568dd08d5a6081bce2b5900
Reviewed-on: https://chromium-review.googlesource.com/729713
Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510944}
[modify] https://crrev.com/290b2ac7af255d3364d0b070ce58a34c33e63d34/third_party/WebKit/LayoutTests/FlagExpectations/root-layer-scrolls
[add] https://crrev.com/290b2ac7af255d3364d0b070ce58a34c33e63d34/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/printing/print-box-shadow-expected.txt
[add] https://crrev.com/290b2ac7af255d3364d0b070ce58a34c33e63d34/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/linux/paint/printing/print-text-shadow-expected.txt
[add] https://crrev.com/290b2ac7af255d3364d0b070ce58a34c33e63d34/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/linux/printing/absolute-position-headers-and-footers-expected.txt
[add] https://crrev.com/290b2ac7af255d3364d0b070ce58a34c33e63d34/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/linux/printing/ellipsis-printing-style-expected.txt
[add] https://crrev.com/290b2ac7af255d3364d0b070ce58a34c33e63d34/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/linux/printing/fixed-positioned-but-static-headers-and-footers-expected.txt
[add] https://crrev.com/290b2ac7af255d3364d0b070ce58a34c33e63d34/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/linux/printing/fixed-positioned-headers-and-footers-absolute-covering-some-pages-expected.txt
[add] https://crrev.com/290b2ac7af255d3364d0b070ce58a34c33e63d34/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/linux/printing/fixed-positioned-headers-and-footers-clipped-expected.txt
[add] https://crrev.com/290b2ac7af255d3364d0b070ce58a34c33e63d34/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/linux/printing/fixed-positioned-headers-and-footers-expected.txt
[add] https://crrev.com/290b2ac7af255d3364d0b070ce58a34c33e63d34/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/linux/printing/fixed-positioned-headers-and-footers-inside-transform-expected.txt
[add] https://crrev.com/290b2ac7af255d3364d0b070ce58a34c33e63d34/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/linux/printing/fixed-positioned-headers-and-footers-larger-than-page-expected.txt
[add] https://crrev.com/290b2ac7af255d3364d0b070ce58a34c33e63d34/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/linux/printing/forced-break-tree-dump-only-expected.txt
[add] https://crrev.com/290b2ac7af255d3364d0b070ce58a34c33e63d34/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/linux/printing/iframe-print-expected.txt
[add] https://crrev.com/290b2ac7af255d3364d0b070ce58a34c33e63d34/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/linux/printing/list-item-with-empty-first-line-expected.txt
[add] https://crrev.com/290b2ac7af255d3364d0b070ce58a34c33e63d34/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/linux/printing/tfoot-repeats-at-bottom-of-each-page-expected.txt
[add] https://crrev.com/290b2ac7af255d3364d0b070ce58a34c33e63d34/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/linux/printing/tfoot-repeats-at-bottom-of-each-page-multiple-tables-expected.txt
[add] https://crrev.com/290b2ac7af255d3364d0b070ce58a34c33e63d34/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/linux/printing/thead-repeats-at-top-of-each-page-multiple-tables-expected.txt
[add] https://crrev.com/290b2ac7af255d3364d0b070ce58a34c33e63d34/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac/paint/printing/print-text-shadow-expected.txt
[add] https://crrev.com/290b2ac7af255d3364d0b070ce58a34c33e63d34/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac/printing/absolute-position-headers-and-footers-expected.txt
[add] https://crrev.com/290b2ac7af255d3364d0b070ce58a34c33e63d34/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac/printing/ellipsis-printing-style-expected.txt
[add] https://crrev.com/290b2ac7af255d3364d0b070ce58a34c33e63d34/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac/printing/fixed-positioned-but-static-headers-and-footers-expected.txt
[add] https://crrev.com/290b2ac7af255d3364d0b070ce58a34c33e63d34/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac/printing/fixed-positioned-headers-and-footers-absolute-covering-some-pages-expected.txt
[add] https://crrev.com/290b2ac7af255d3364d0b070ce58a34c33e63d34/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac/printing/fixed-positioned-headers-and-footers-clipped-expected.txt
[add] https://crrev.com/290b2ac7af255d3364d0b070ce58a34c33e63d34/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac/printing/fixed-positioned-headers-and-footers-expected.txt
[add] https://crrev.com/290b2ac7af255d3364d0b070ce58a34c33e63d34/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac/printing/fixed-positioned-headers-and-footers-inside-transform-expected.txt
[add] https://crrev.com/290b2ac7af255d3364d0b070ce58a34c33e63d34/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac/printing/fixed-positioned-headers-and-footers-larger-than-page-expected.txt
[add] https://crrev.com/290b2ac7af255d3364d0b070ce58a34c33e63d34/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac/printing/forced-break-tree-dump-only-expected.txt
[add] https://crrev.com/290b2ac7af255d3364d0b070ce58a34c33e63d34/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac/printing/iframe-print-expected.txt
[add] https://crrev.com/290b2ac7af255d3364d0b070ce58a34c33e63d34/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac/printing/list-item-with-empty-first-line-expected.txt
[add] https://crrev.com/290b2ac7af255d3364d0b070ce58a34c33e63d34/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac/printing/tfoot-repeats-at-bottom-of-each-page-expected.txt
[add] https://crrev.com/290b2ac7af255d3364d0b070ce58a34c33e63d34/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac/printing/tfoot-repeats-at-bottom-of-each-page-multiple-tables-expected.txt
[add] https://crrev.com/290b2ac7af255d3364d0b070ce58a34c33e63d34/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac/printing/thead-repeats-at-top-of-each-page-multiple-tables-expected.txt
[add] https://crrev.com/290b2ac7af255d3364d0b070ce58a34c33e63d34/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/win/paint/printing/print-text-shadow-expected.txt
[add] https://crrev.com/290b2ac7af255d3364d0b070ce58a34c33e63d34/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/win/printing/fixed-positioned-headers-and-footers-absolute-covering-some-pages-expected.txt
[add] https://crrev.com/290b2ac7af255d3364d0b070ce58a34c33e63d34/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/win/printing/forced-break-tree-dump-only-expected.txt
[add] https://crrev.com/290b2ac7af255d3364d0b070ce58a34c33e63d34/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/win/printing/iframe-print-expected.txt
[add] https://crrev.com/290b2ac7af255d3364d0b070ce58a34c33e63d34/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/win/printing/list-item-with-empty-first-line-expected.txt
[add] https://crrev.com/290b2ac7af255d3364d0b070ce58a34c33e63d34/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/win/printing/tfoot-repeats-at-bottom-of-each-page-expected.txt
[add] https://crrev.com/290b2ac7af255d3364d0b070ce58a34c33e63d34/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/win/printing/tfoot-repeats-at-bottom-of-each-page-multiple-tables-expected.txt
[add] https://crrev.com/290b2ac7af255d3364d0b070ce58a34c33e63d34/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/win/printing/thead-repeats-at-top-of-each-page-multiple-tables-expected.txt
[add] https://crrev.com/290b2ac7af255d3364d0b070ce58a34c33e63d34/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/win7/printing/absolute-position-headers-and-footers-expected.txt
[add] https://crrev.com/290b2ac7af255d3364d0b070ce58a34c33e63d34/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/win7/printing/ellipsis-printing-style-expected.txt
[add] https://crrev.com/290b2ac7af255d3364d0b070ce58a34c33e63d34/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/win7/printing/fixed-positioned-but-static-headers-and-footers-expected.txt
[add] https://crrev.com/290b2ac7af255d3364d0b070ce58a34c33e63d34/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/win7/printing/fixed-positioned-headers-and-footers-clipped-expected.txt
[add] https://crrev.com/290b2ac7af255d3364d0b070ce58a34c33e63d34/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/win7/printing/fixed-positioned-headers-and-footers-expected.txt
[add] https://crrev.com/290b2ac7af255d3364d0b070ce58a34c33e63d34/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/win7/printing/fixed-positioned-headers-and-footers-inside-transform-expected.txt
[add] https://crrev.com/290b2ac7af255d3364d0b070ce58a34c33e63d34/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/win7/printing/fixed-positioned-headers-and-footers-larger-than-page-expected.txt
[add] https://crrev.com/290b2ac7af255d3364d0b070ce58a34c33e63d34/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/printing/simultaneous-position-float-change-expected.txt
[modify] https://crrev.com/290b2ac7af255d3364d0b070ce58a34c33e63d34/third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp
[modify] https://crrev.com/290b2ac7af255d3364d0b070ce58a34c33e63d34/third_party/WebKit/Source/core/layout/LayoutView.cpp
[modify] https://crrev.com/290b2ac7af255d3364d0b070ce58a34c33e63d34/third_party/WebKit/Source/core/page/PrintContext.cpp
[modify] https://crrev.com/290b2ac7af255d3364d0b070ce58a34c33e63d34/third_party/WebKit/Source/core/paint/FramePainter.cpp
[modify] https://crrev.com/290b2ac7af255d3364d0b070ce58a34c33e63d34/third_party/WebKit/Source/core/paint/ViewPainter.cpp

Blocking: -417782 711468
Summary: [root layer scrolls] failures in printing/... (was: [root layer scrolls] printing tests with layout tree dump have incorrect layer sizes)
Note: the following tests still fail with RLS:

printing/fixed-positioned-scrolled.html
printing/quirks-percentage-height-body.html
printing/quirks-percentage-height.html
printing/standards-percentage-heights.html
printing/subframes-percentage-height.html
printing/thead-repeats-at-top-of-each-page.html
Owner: chrishtr@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a5f202ddde7adf2b45248e416b86ad96fd64700

commit 6a5f202ddde7adf2b45248e416b86ad96fd64700
Author: Chris Harrelson <chrishtr@chromium.org>
Date: Wed Feb 07 20:26:42 2018

[RLS] Rebaseline and mark as passing some tests in printing/

Bug:  774716 
Change-Id: I32404edcb0417e10ff533db45b774a512b591a5e
Reviewed-on: https://chromium-review.googlesource.com/904948
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535128}
[modify] https://crrev.com/6a5f202ddde7adf2b45248e416b86ad96fd64700/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/6a5f202ddde7adf2b45248e416b86ad96fd64700/third_party/WebKit/LayoutTests/platform/linux/printing/thead-under-multicol-expected.png
[modify] https://crrev.com/6a5f202ddde7adf2b45248e416b86ad96fd64700/third_party/WebKit/LayoutTests/platform/linux/printing/thead-under-multicol-expected.txt
[delete] https://crrev.com/addede59555ab6c04cc072a2ab59cb11066c3a27/third_party/WebKit/LayoutTests/platform/linux/virtual/threaded/printing/absolute-position-headers-and-footers-expected.txt
[delete] https://crrev.com/addede59555ab6c04cc072a2ab59cb11066c3a27/third_party/WebKit/LayoutTests/platform/linux/virtual/threaded/printing/fixed-positioned-but-static-headers-and-footers-expected.txt
[modify] https://crrev.com/6a5f202ddde7adf2b45248e416b86ad96fd64700/third_party/WebKit/LayoutTests/platform/linux/virtual/threaded/printing/fixed-positioned-headers-and-footers-absolute-covering-some-pages-expected.txt
[delete] https://crrev.com/addede59555ab6c04cc072a2ab59cb11066c3a27/third_party/WebKit/LayoutTests/platform/linux/virtual/threaded/printing/fixed-positioned-headers-and-footers-expected.txt
[delete] https://crrev.com/addede59555ab6c04cc072a2ab59cb11066c3a27/third_party/WebKit/LayoutTests/platform/linux/virtual/threaded/printing/fixed-positioned-headers-and-footers-inside-transform-expected.txt
[delete] https://crrev.com/addede59555ab6c04cc072a2ab59cb11066c3a27/third_party/WebKit/LayoutTests/platform/linux/virtual/threaded/printing/fixed-positioned-headers-and-footers-larger-than-page-expected.txt
[add] https://crrev.com/6a5f202ddde7adf2b45248e416b86ad96fd64700/third_party/WebKit/LayoutTests/platform/linux/virtual/threaded/printing/thead-under-multicol-expected.png
[modify] https://crrev.com/6a5f202ddde7adf2b45248e416b86ad96fd64700/third_party/WebKit/LayoutTests/platform/linux/virtual/threaded/printing/thead-under-multicol-expected.txt
[modify] https://crrev.com/6a5f202ddde7adf2b45248e416b86ad96fd64700/third_party/WebKit/LayoutTests/platform/mac-mac10.11/printing/thead-under-multicol-expected.png
[add] https://crrev.com/6a5f202ddde7adf2b45248e416b86ad96fd64700/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/threaded/printing/thead-under-multicol-expected.png
[add] https://crrev.com/6a5f202ddde7adf2b45248e416b86ad96fd64700/third_party/WebKit/LayoutTests/platform/mac-mac10.12/printing/thead-under-multicol-expected.png
[add] https://crrev.com/6a5f202ddde7adf2b45248e416b86ad96fd64700/third_party/WebKit/LayoutTests/platform/mac-mac10.12/printing/thead-under-multicol-expected.txt
[add] https://crrev.com/6a5f202ddde7adf2b45248e416b86ad96fd64700/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/threaded/printing/thead-under-multicol-expected.png
[add] https://crrev.com/6a5f202ddde7adf2b45248e416b86ad96fd64700/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/threaded/printing/thead-under-multicol-expected.txt
[add] https://crrev.com/6a5f202ddde7adf2b45248e416b86ad96fd64700/third_party/WebKit/LayoutTests/platform/mac-retina/printing/thead-under-multicol-expected.png
[add] https://crrev.com/6a5f202ddde7adf2b45248e416b86ad96fd64700/third_party/WebKit/LayoutTests/platform/mac-retina/virtual/threaded/printing/thead-under-multicol-expected.png
[modify] https://crrev.com/6a5f202ddde7adf2b45248e416b86ad96fd64700/third_party/WebKit/LayoutTests/platform/win/printing/thead-under-multicol-expected.png
[modify] https://crrev.com/6a5f202ddde7adf2b45248e416b86ad96fd64700/third_party/WebKit/LayoutTests/platform/win/printing/thead-under-multicol-expected.txt

Status: Fixed (was: Assigned)

Comment 7 by skobes@google.com, Mar 19 2018

 Issue 774717  has been merged into this issue.

Sign in to add a comment