[root layer scrolls] missing vertical scrollbars |
||
Issue descriptionThese tests expect to have a vertical scrollbar, but don't: external/wpt/viewport/viewport-read-size-causes-layout.html external/wpt/viewport/viewport-read-size-in-iframe-causes-layout.html external/wpt/viewport/viewport-resize-event-on-load-overflowing-page.html external/wpt/viewport/viewport-unscaled-size-iframe.html external/wpt/viewport/viewport-unscaled-size.html
,
Oct 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a8e1de5b19353797ee41b343d1e4cc021d61d735 commit a8e1de5b19353797ee41b343d1e4cc021d61d735 Author: Philip Rogers <pdr@chromium.org> Date: Wed Oct 25 19:35:10 2017 [root layer scrolls] Make VisualViewport size RLS-aware This patch makes VisualViewport.{width, height} work with root layer scrolling (RLS) where the layout viewport scrollable area should be used to access the visible content rect. This patch removes the scrollbar size codepath from LocalDomWindow so it is only used by inner{width, height} and can return the LocalFrameView's size without a layout in many cases. The scrollbar size codepaths in VisualViewport and DOMVisualViewport have been updated to use the correct visible content rect. With this patch, 11 more tests pass with RLS. Bug: 774711 Change-Id: Idc2357fe12767bda6b3e0d94006141bf265203fd Reviewed-on: https://chromium-review.googlesource.com/729467 Reviewed-by: Stefan Zager <szager@chromium.org> Reviewed-by: Steve Kobes <skobes@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#511555} [modify] https://crrev.com/a8e1de5b19353797ee41b343d1e4cc021d61d735/third_party/WebKit/LayoutTests/FlagExpectations/root-layer-scrolls [modify] https://crrev.com/a8e1de5b19353797ee41b343d1e4cc021d61d735/third_party/WebKit/Source/core/frame/DOMVisualViewport.cpp [modify] https://crrev.com/a8e1de5b19353797ee41b343d1e4cc021d61d735/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp [modify] https://crrev.com/a8e1de5b19353797ee41b343d1e4cc021d61d735/third_party/WebKit/Source/core/frame/LocalDOMWindow.h [modify] https://crrev.com/a8e1de5b19353797ee41b343d1e4cc021d61d735/third_party/WebKit/Source/core/frame/VisualViewport.cpp
,
Oct 25 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Oct 24 2017