New issue
Advanced search Search tips

Issue 774694 link

Starred by 3 users
Status: Fixed
Owner:
l...@chromium.org
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

DevTools: reduce console noise by coalescing

Project Member Reported by l...@chromium.org, Oct 13 2017 
Messages that flood the developer's Console can hurt the developer experience.  One mitigation to noise is to coalesce console messages more aggressively.

For example, messageA and messageB with the same text, but different stack traces could be collapsed as one message.  Upon clicking an expansion triangle, it could reveal two stack trace representations.

Comment 1 by evensten...@gmail.com, Oct 13 2017 

Could I work on this?

Comment 2 by l...@chromium.org, Oct 13 2017

Status: Started (was: Assigned)
That was fast!  For this bug in particular, I've already been working on this for awhile, just haven't opened a crbug until today, my apologies.  I have a plan on how to approach the UI, but if you have ideas on how it should look, please feel free to comment here.

We still welcome contributions, though, and many many DevTools bugs are still available!
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be419f390431155cdf011605a0eef2eb717af327

commit be419f390431155cdf011605a0eef2eb717af327
Author: Erik Luo <luoe@chromium.org>
Date: Fri Oct 20 03:51:38 2017

DevTools: fix styles for groups with repeat counts

Incrementing a group's repeat count will now look better. The structure
of message decorations will change to allow nesting level indents to
remain unaffected by the offset of the repeat bubble's width.

Before: repeatCount > nestingLevelMarkers > groupExpandIcon
After: nestingLevelMarkers > groupExpandIcon > repeatCount

Screenshot: https://imgur.com/a/E0Ld4

Bug:  774694 
Change-Id: I2e43b0eaa27b14650529e4e45108e14f3d2bd228
Reviewed-on: https://chromium-review.googlesource.com/728392
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510322}
[modify] https://crrev.com/be419f390431155cdf011605a0eef2eb717af327/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
[modify] https://crrev.com/be419f390431155cdf011605a0eef2eb717af327/third_party/WebKit/Source/devtools/front_end/console/consoleView.css
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1952a0fce9eae13c1040b8c13f3b6d32115be3cb

commit 1952a0fce9eae13c1040b8c13f3b6d32115be3cb
Author: Pavel Feldman <pfeldman@chromium.org>
Date: Sun Oct 22 22:26:30 2017

DevTools: use medium icons for the console sidebar.

Bug:  774694 
Change-Id: Ic796965db50aedd5e835e492b7f7282f77442c29
Reviewed-on: https://chromium-review.googlesource.com/732610
Reviewed-by: Blaise Bruer <allada@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510709}
[modify] https://crrev.com/1952a0fce9eae13c1040b8c13f3b6d32115be3cb/third_party/WebKit/Source/devtools/front_end/Images/mediumIcons.png
[modify] https://crrev.com/1952a0fce9eae13c1040b8c13f3b6d32115be3cb/third_party/WebKit/Source/devtools/front_end/Images/mediumIcons_2x.png
[modify] https://crrev.com/1952a0fce9eae13c1040b8c13f3b6d32115be3cb/third_party/WebKit/Source/devtools/front_end/Images/smallIcons.png
[modify] https://crrev.com/1952a0fce9eae13c1040b8c13f3b6d32115be3cb/third_party/WebKit/Source/devtools/front_end/Images/smallIcons_2x.png
[modify] https://crrev.com/1952a0fce9eae13c1040b8c13f3b6d32115be3cb/third_party/WebKit/Source/devtools/front_end/Images/src/mediumIcons.svg
[modify] https://crrev.com/1952a0fce9eae13c1040b8c13f3b6d32115be3cb/third_party/WebKit/Source/devtools/front_end/Images/src/optimize_png.hashes
[modify] https://crrev.com/1952a0fce9eae13c1040b8c13f3b6d32115be3cb/third_party/WebKit/Source/devtools/front_end/Images/src/smallIcons.svg
[modify] https://crrev.com/1952a0fce9eae13c1040b8c13f3b6d32115be3cb/third_party/WebKit/Source/devtools/front_end/Images/src/svg2png.hashes
[modify] https://crrev.com/1952a0fce9eae13c1040b8c13f3b6d32115be3cb/third_party/WebKit/Source/devtools/front_end/console/ConsoleSidebar.js
[modify] https://crrev.com/1952a0fce9eae13c1040b8c13f3b6d32115be3cb/third_party/WebKit/Source/devtools/front_end/ui/Icon.js
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35b75df7c144b82cfc24193bc80a6d64e298914f

commit 35b75df7c144b82cfc24193bc80a6d64e298914f
Author: Pavel Feldman <pfeldman@chromium.org>
Date: Mon Oct 23 08:45:01 2017

DevTools: automatic console message grouping changes:

- New message matching logic
- Setting in the toolbar
- Nesting marker
- Bugfixes

Bug:  774694 
Change-Id: I1898b113e2c7e69873ddb31156c593a8eb655661
Reviewed-on: https://chromium-review.googlesource.com/731969
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510737}
[modify] https://crrev.com/35b75df7c144b82cfc24193bc80a6d64e298914f/third_party/WebKit/LayoutTests/http/tests/devtools/console-xhr-logging.js
[modify] https://crrev.com/35b75df7c144b82cfc24193bc80a6d64e298914f/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-timestamp.js
[modify] https://crrev.com/35b75df7c144b82cfc24193bc80a6d64e298914f/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
[modify] https://crrev.com/35b75df7c144b82cfc24193bc80a6d64e298914f/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
[modify] https://crrev.com/35b75df7c144b82cfc24193bc80a6d64e298914f/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewport.js
[modify] https://crrev.com/35b75df7c144b82cfc24193bc80a6d64e298914f/third_party/WebKit/Source/devtools/front_end/console/consoleView.css
[modify] https://crrev.com/35b75df7c144b82cfc24193bc80a6d64e298914f/third_party/WebKit/Source/devtools/front_end/console/module.json
[modify] https://crrev.com/35b75df7c144b82cfc24193bc80a6d64e298914f/third_party/WebKit/Source/devtools/front_end/console_model/ConsoleModel.js
[modify] https://crrev.com/35b75df7c144b82cfc24193bc80a6d64e298914f/third_party/WebKit/Source/devtools/front_end/main/Main.js
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 31 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/387fe8234417a5e32af29e10975ad36730164a5d

commit 387fe8234417a5e32af29e10975ad36730164a5d
Author: Erik Luo <luoe@chromium.org>
Date: Tue Oct 31 01:45:38 2017

DevTools: do not group JS-source error messages

Errors from JS such as Promise.reject() or TypeError/SyntaxError from
should not be grouped.

Bug:  774694 
Change-Id: I791617939a6fd01f963d907e87f87f22031438c4
Reviewed-on: https://chromium-review.googlesource.com/742202
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512697}
[add] https://crrev.com/387fe8234417a5e32af29e10975ad36730164a5d/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-group-similar-expected.txt
[add] https://crrev.com/387fe8234417a5e32af29e10975ad36730164a5d/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-group-similar.js
[modify] https://crrev.com/387fe8234417a5e32af29e10975ad36730164a5d/third_party/WebKit/Source/devtools/front_end/console_model/ConsoleModel.js

Comment 9 by l...@chromium.org, Dec 8 2017 

Further work: use console string arguments from backend to substitute for %s instead of relying on regexes on the frontend for things like 'Milestone'.

Comment 10 by pfeldman@chromium.org, Dec 8 2017

Status: Fixed (was: Started)
►

Sign in to add a comment