New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 774688 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 753192
Owner: ----
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

snav-container-white-space.html LayoutTest is flaky

Project Member Reported by tmartino@chromium.org, Oct 13 2017

Issue description

fast/spatial-navigation/snav-container-white-space.html has been flaky today on Mac and Windows. I'm marking it as such for the time being.
 
This was previously disabled in crbug.com/757165
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c12b24dc8d0bf3f595f2e37c33a605aff26a094

commit 5c12b24dc8d0bf3f595f2e37c33a605aff26a094
Author: tmartino <tmartino@chromium.org>
Date: Fri Oct 13 23:02:07 2017

Marking snav-container-white-space.html flaky

Bug:  774688 
Change-Id: I9cbeba332838cf54ea76915364a06b743834df1e

TBR=qyearsley@chromium.org,jeffcarp@chromium.org,dpranke@chromium.org

Change-Id: I9cbeba332838cf54ea76915364a06b743834df1e
Reviewed-on: https://chromium-review.googlesource.com/719610
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508859}
[modify] https://crrev.com/5c12b24dc8d0bf3f595f2e37c33a605aff26a094/third_party/WebKit/LayoutTests/TestExpectations

Components: Blink>Layout
Labels: OS-Mac OS-Windows
Owner: xiaoche...@chromium.org
Naively assigning to xiaochengh@, who has some of the more recent changes in this directory. Hoping you can triage this better than I can :)

Comment 4 by e...@chromium.org, Oct 17 2017

Status: Assigned (was: Untriaged)
Cc: xiaoche...@chromium.org
Components: -Blink>Layout Blink>HTML>Focus
Owner: kochi@chromium.org
Assigning to kochi@ since the test is about spatial navigation.

Comment 6 by kochi@chromium.org, Oct 19 2017

Cc: kochi@chromium.org
Owner: hu...@vewd.com
Hugo, could you take a look?

Comment 7 by hu...@vewd.com, Oct 31 2017

Mergedinto: 753192
Owner: ----
Status: Duplicate (was: Assigned)
Looking at the test failure [1], I see that the first Down key is missing! This is similar to Issue 753192.

TEST COMPLETE
FAIL gFocusedDocument.activeElement.getAttribute("id") should be 1. Was start. // Missed the Down to 1.
FAIL gFocusedDocument.activeElement.getAttribute("id") should be 2. Was 1.
FAIL gFocusedDocument.activeElement.getAttribute("id") should be 3. Was 2.
FAIL gFocusedDocument.activeElement.getAttribute("id") should be 4. Was 3.
FAIL gFocusedDocument.activeElement.getAttribute("id") should be 5. Was 4. 
FAIL gFocusedDocument.activeElement.getAttribute("id") should be 4. Was 3.
FAIL gFocusedDocument.activeElement.getAttribute("id") should be 3. Was 2.
FAIL gFocusedDocument.activeElement.getAttribute("id") should be 2. Was 1.
FAIL gFocusedDocument.activeElement.getAttribute("id") should be 1. Was start.
PASS gFocusedDocument.activeElement.getAttribute("id") is "start"
This test tests that a anchor element with in image in it and a space after the image, can still give the correct size in ContainerNode::getRect().

This missing Down-key seems to be the problem on both Mac [1] and Windows [2].

[1] https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Mac10_11__retina_/19070/layout-test-results.zip
[2] https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Win7/56989/layout-test-results.zip
From https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=fast%2Fspatial-navigation%2Fsnav-container-white-space.html 

I'd like to bounce this back to the Mac/Win/test/input developers because I only got a Linux workstation myself and this test does not flake on Linux. Could it simply be that content_shell sometimes is slow to start on Mac/Win?

If I'd have a Mac/Win machine I'd loop this test locally, with some debug prints, to try to find out where the key gets lost. Maybe loosing the first eventSender.keyDown() is general source of LayoutTest flakiness on our Win/Mac bots?

Sign in to add a comment