New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 774680 link

Starred by 5 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

DataUse.MessageSize.* Histogram is overflowing the count limits

Project Member Reported by nikunjb@chromium.org, Oct 13 2017

Issue description

Chrome Version: 59.0.3071.115 onwards (Maybe before also)
OS: All

The issue is with recording data use in bytes. The effect is seen only when aggregating data use. It sometimes overflow int limit.

 
Suggestion: Accumulate in bytes but the value stored in sparse histogram will be in KB. Anything below 1KB will be counted as 1KB. Anything beyond will be rounded to nearest KB.

Does this sound good? If yes then I can make the change.
Using KB sounds good to me. Should we use a new histogram prefix so that the new values don't get confused with the old?

+rajendrant, WDYT?
What do you think of this as a solution?
https://chromium-review.googlesource.com/#/c/chromium/src/+/729143

BTW, I find numerous bug reports to actually REMOVE these histograms because they're not being looked at.  Perhaps that would be the best solution?

That solution looks good to me, thanks!

I'm not sure about removing the histograms though; @rajendrant, are these histograms still being used?
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eedfae101066b7d50d81235bfa06a068c8d25ff4

commit eedfae101066b7d50d81235bfa06a068c8d25ff4
Author: Brian White <bcwhite@chromium.org>
Date: Mon Oct 23 18:56:17 2017

Use KB for units measuring data per service.

Adding bytes on a per-service basis causes the count to overflow the
signed 32-bit counter.

This converts the recording to KiB, hopefully preventing the wrapping.

Bug:  774680 
Change-Id: If2e19d101815527e7a5efc97486aef3bb73afb66
Reviewed-on: https://chromium-review.googlesource.com/729143
Commit-Queue: Brian White <bcwhite@chromium.org>
Reviewed-by: Scott Little <sclittle@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510863}
[modify] https://crrev.com/eedfae101066b7d50d81235bfa06a068c8d25ff4/components/data_use_measurement/core/data_use_measurement.cc
[modify] https://crrev.com/eedfae101066b7d50d81235bfa06a068c8d25ff4/tools/metrics/histograms/histograms.xml

Status: Verified (was: Untriaged)
Although the "obsolete" annotations in the histograms.xml file were incorrectly specified (fix forthcoming), the general change seems to be working properly and there have been no reported overflows since the change.

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2d1ec3cc923c520629bf49f604b740c5fb672dc

commit f2d1ec3cc923c520629bf49f604b740c5fb672dc
Author: Brian White <bcwhite@chromium.org>
Date: Fri Oct 27 14:40:20 2017

Fix "obsolete" annotations for DataUse suffixes.

Bug:  774680 
Change-Id: I1d040e7dc69a60fcc79f7798935e0d7a9179785b
Reviewed-on: https://chromium-review.googlesource.com/739721
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512179}
[modify] https://crrev.com/f2d1ec3cc923c520629bf49f604b740c5fb672dc/tools/metrics/histograms/histograms.xml

Cc: gayane@chromium.org
 Issue 739925  has been merged into this issue.

Sign in to add a comment