DataUse.MessageSize.* Histogram is overflowing the count limits |
||
Issue descriptionChrome Version: 59.0.3071.115 onwards (Maybe before also) OS: All The issue is with recording data use in bytes. The effect is seen only when aggregating data use. It sometimes overflow int limit.
,
Oct 13 2017
Using KB sounds good to me. Should we use a new histogram prefix so that the new values don't get confused with the old? +rajendrant, WDYT?
,
Oct 19 2017
What do you think of this as a solution? https://chromium-review.googlesource.com/#/c/chromium/src/+/729143 BTW, I find numerous bug reports to actually REMOVE these histograms because they're not being looked at. Perhaps that would be the best solution?
,
Oct 19 2017
That solution looks good to me, thanks! I'm not sure about removing the histograms though; @rajendrant, are these histograms still being used?
,
Oct 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eedfae101066b7d50d81235bfa06a068c8d25ff4 commit eedfae101066b7d50d81235bfa06a068c8d25ff4 Author: Brian White <bcwhite@chromium.org> Date: Mon Oct 23 18:56:17 2017 Use KB for units measuring data per service. Adding bytes on a per-service basis causes the count to overflow the signed 32-bit counter. This converts the recording to KiB, hopefully preventing the wrapping. Bug: 774680 Change-Id: If2e19d101815527e7a5efc97486aef3bb73afb66 Reviewed-on: https://chromium-review.googlesource.com/729143 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by: Scott Little <sclittle@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#510863} [modify] https://crrev.com/eedfae101066b7d50d81235bfa06a068c8d25ff4/components/data_use_measurement/core/data_use_measurement.cc [modify] https://crrev.com/eedfae101066b7d50d81235bfa06a068c8d25ff4/tools/metrics/histograms/histograms.xml
,
Oct 26 2017
Although the "obsolete" annotations in the histograms.xml file were incorrectly specified (fix forthcoming), the general change seems to be working properly and there have been no reported overflows since the change.
,
Oct 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f2d1ec3cc923c520629bf49f604b740c5fb672dc commit f2d1ec3cc923c520629bf49f604b740c5fb672dc Author: Brian White <bcwhite@chromium.org> Date: Fri Oct 27 14:40:20 2017 Fix "obsolete" annotations for DataUse suffixes. Bug: 774680 Change-Id: I1d040e7dc69a60fcc79f7798935e0d7a9179785b Reviewed-on: https://chromium-review.googlesource.com/739721 Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#512179} [modify] https://crrev.com/f2d1ec3cc923c520629bf49f604b740c5fb672dc/tools/metrics/histograms/histograms.xml
,
Oct 31 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by nikunjb@chromium.org
, Oct 13 2017