[Chrome Home] Animate checkmark for List UI |
||||||
Issue descriptionWe need some animation for the checkmark icon in selection mode: spec provided: https://material-components-web.appspot.com/checkbox.html original discussion: https://bugs.chromium.org/p/chromium/issues/detail?id=755034&desc=2#c5
,
Oct 25 2017
We don't have checkboxes on the New Tab Page. Not sure what the correct component for this is, maybe just UI>Browser>Mobile
,
Oct 25 2017
The checkmark is selection mode is on history, bookmarks, and downloads.
,
Dec 1 2017
,
Dec 1 2017
hannahs@ - Please check the attached video for the checkmark animation. The duration is set to 200ms for the first half and 200ms for the second half of the stroke. We can adjust the animation time if this is not a standard.
,
Dec 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a5c6302c0acfd85ba46a44ed95a811e4d6edbdab commit a5c6302c0acfd85ba46a44ed95a811e4d6edbdab Author: Becky Zhou <huayinz@chromium.org> Date: Sat Dec 02 00:25:49 2017 [Home] Animate checkmark for List UI Adds an animation to the checkmark icon for History/Bookmark/Download. Bug: 774673 Change-Id: I72254511a5b79026d26f0bfe7bf6b2df26b37daf Reviewed-on: https://chromium-review.googlesource.com/801977 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#521147} [add] https://crrev.com/a5c6302c0acfd85ba46a44ed95a811e4d6edbdab/chrome/android/java/res/drawable/ic_check_googblue_24dp_animated.xml [modify] https://crrev.com/a5c6302c0acfd85ba46a44ed95a811e4d6edbdab/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadItemView.java [modify] https://crrev.com/a5c6302c0acfd85ba46a44ed95a811e4d6edbdab/chrome/android/java/src/org/chromium/chrome/browser/widget/selection/SelectableItemView.java [modify] https://crrev.com/a5c6302c0acfd85ba46a44ed95a811e4d6edbdab/chrome/android/javatests/src/org/chromium/chrome/browser/bookmarks/BookmarkTest.java [modify] https://crrev.com/a5c6302c0acfd85ba46a44ed95a811e4d6edbdab/chrome/test/data/android/render_tests/BookmarkTest.bookmark_manager_folder_selected.Nexus_5-19.png
,
Dec 2 2017
+Helene wdyt? lgtm!!
,
Dec 13 2017
Becky, I'm seeing the animation on regular download items but not the OfflineGroupHeaderView. It looks like that class has its own #updateCheckIcon() method that probably needs to be updated.
,
Dec 13 2017
Oh.. I didn't update the OfflineGroupHeaderView. Will work on that shortly:)
,
Jan 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/863a492713b741ae185dbf14bea36cc270cd4b04 commit 863a492713b741ae185dbf14bea36cc270cd4b04 Author: Becky Zhou <huayinz@chromium.org> Date: Thu Jan 18 20:04:36 2018 [Downloads] Animate checkmark on OfflineGroupHeaderView Bug: 774673 Change-Id: Ie5b89f1a12172838e986f4789fd37db9897e69af Reviewed-on: https://chromium-review.googlesource.com/826249 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#530245} [modify] https://crrev.com/863a492713b741ae185dbf14bea36cc270cd4b04/chrome/android/java/src/org/chromium/chrome/browser/download/ui/OfflineGroupHeaderView.java
,
Feb 9 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by dtapu...@chromium.org
, Oct 25 2017