New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 774671 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 772943
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

CQ graceful self-destruct after all CL's in will-submit causes CQ failure

Project Member Reported by jclinton@chromium.org, Oct 13 2017

Issue description

This build should have succeeded: https://uberchromegw.corp.google.com/i/chromeos/builders/master-paladin/builds/16526

In the logs we see:
05:09:59: INFO: will_submit set contains 1 changes: [CL:*460553]
might_submit set contains 1 changes: [CL:699064]
will_not_submit set contains 0 changes: []

05:09:59: INFO: Still waiting for the following builds to complete: [u'cave-paladin', u'hana-paladin', u'kevin-paladin', u'link-paladin', u'lumpy-paladin', u'quawks-paladin', u'reef-uni-paladin', u'wizpig-paladin', u'wolf-paladin']
05:09:59: INFO: 2:36:46.642973 until timeout...
05:10:59: INFO: Updating slave status...
05:11:08: INFO: Running cidb query on pid 13970, repr(query) starts with <sqlalchemy.sql.expression.Select at 0x7fcb379e1c50; Select object>
05:11:09: INFO: Running cidb query on pid 13970, repr(query) starts with <sqlalchemy.sql.expression.Select at 0x7fcb3778a2d0; Select object>
05:11:09: INFO: Running cidb query on pid 13970, repr(query) starts with u'SELECT bs.id, bs.build_id, bs.name, bs.board, bs.status, bs.last_updated, bs.start_time, bs.finish
05:11:09: INFO: Running cidb query on pid 13970, repr(query) starts with <sqlalchemy.sql.expression.Select at 0x7fcb378f8750; Select object>
05:11:09: INFO: Running cidb query on pid 13970, repr(query) starts with 'SELECT c.id, b.id, action, c.reason, build_config, change_number, patch_number, change_source, time
05:11:09: INFO: Running cidb query on pid 13970, repr(query) starts with 'SELECT build_id, build_config, waterfall, builder_name, build_number, message_type, message_subtype
05:11:10: INFO: Running cidb query on pid 13970, repr(query) starts with <sqlalchemy.sql.expression.Select at 0x7fcb379e1e50; Select object>
05:11:10: INFO: Running cidb query on pid 13970, repr(query) starts with 'SELECT c.id, b.id, action, c.reason, build_config, change_number, patch_number, change_source, time
05:11:18: INFO: Running cidb query on pid 13970, repr(query) starts with <sqlalchemy.sql.expression.Select at 0x7fcb37872890; Select object>
05:11:18: INFO: Running cidb query on pid 13970, repr(query) starts with u'SELECT id, build_stage_id, outer_failure_id, exception_type, exception_message, exception_category
05:11:18: INFO: Processing changes in might submit set.
05:11:18: INFO: Moving CL:*460553 CL:699064 to will_submit set, because their relevant builds completed successfully or all failures are ignorable or passed in CQ history.
05:11:18: INFO: will_submit set contains 2 changes: [CL:*460553 CL:699064]
might_submit set contains 0 changes: []
will_not_submit set contains 0 changes: []

05:11:18: WARNING: This build will self-destruct given the results of relevant change triages.
05:11:18: INFO: This build will self-destruct with success.
...
@@@STEP_WARNINGS@@@
05:11:30: WARNING: The following builders failed with this manifest:
cave-paladin, hana-paladin, kevin-paladin, link-paladin, lumpy-paladin, quawks-paladin, reef-uni-paladin, wizpig-paladin, wolf-paladin
Please check the logs of the failing builders for details.

It seems that we don't account for per-board submit logic allowing all CL's to submit (with none in the general paladin set).
 

Comment 1 by nxia@chromium.org, Oct 13 2017

Cc: jkop@chromium.org
this is another example of  crbug.com/772943 

The CQ actually submitted all CLs but reported itself as failed. 

Comment 2 by nxia@chromium.org, Oct 13 2017

Mergedinto: 772943
Status: Duplicate (was: Untriaged)

Comment 3 by nxia@chromium.org, Oct 13 2017

Owner: nxia@chromium.org

Sign in to add a comment