Decide if OnFailureChecksComplete() should look at result.action(). |
||
Issue descriptionThe initial version of https://crrev.com/c/621873 contains: net_error_ = result.net_error_code(); ... if (net::ERR_ABORTED == net_error_) { frame_tree_node_->ResetNavigationRequest(false, true); return; } However, we may want to change the behaviour based on result.action(). In particular, the documentation for CANCEL_AND_IGNORE says "act like the request was never made" [1], which suggests that we should also reset the navigation request (instead of committing the error page) for that action. Arguably, it also makes sense to allow throttles to cancel a committed navigation with a result of net::ERR_ABORTED. [1] https://cs.chromium.org/chromium/src/content/public/browser/navigation_throttle.h?l=34&rcl=835f294f50b4c64329c2021b141be3f45b4df338
,
Feb 26 2018
Carlos, I /think/ you took on the Committed Interstitials stuff? Can you PTAL? |
||
►
Sign in to add a comment |
||
Comment 1 by tedc...@chromium.org
, Feb 7 2018Labels: android-fe-triaged