New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 774663 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug
Team-Security-UX



Sign in to add a comment

Decide if OnFailureChecksComplete() should look at result.action().

Project Member Reported by lgar...@chromium.org, Oct 13 2017

Issue description

The initial version of https://crrev.com/c/621873 contains:
  
    net_error_ = result.net_error_code();
    ...

    if (net::ERR_ABORTED == net_error_) {
      frame_tree_node_->ResetNavigationRequest(false, true);
      return;
    }

However, we may want to change the behaviour based on result.action(). In particular, the documentation for CANCEL_AND_IGNORE says "act like the request was never made" [1], which suggests that we should also reset the navigation request (instead of committing the error page) for that action.

Arguably, it also makes sense to allow throttles to cancel a committed navigation with a result of net::ERR_ABORTED.

[1] https://cs.chromium.org/chromium/src/content/public/browser/navigation_throttle.h?l=34&rcl=835f294f50b4c64329c2021b141be3f45b4df338
 
Components: -UI>Browser>Navigation UI>Browser>Interstitials
Labels: android-fe-triaged
Owner: carlosil@chromium.org
Status: Assigned (was: Untriaged)
Carlos, I /think/ you took on the Committed Interstitials stuff? Can you PTAL?

Sign in to add a comment