New issue
Advanced search Search tips

Issue 774659 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove unused AudioParamHandler method

Project Member Reported by rtoy@chromium.org, Oct 13 2017

Issue description

AudioParamHandler declares the method WarnIfOutsideRange(float value,
float min_value, float max_value)

But this method is neither implemented nor used.

Remove it.

 

Comment 1 by rtoy@chromium.org, Oct 13 2017

Summary: Remove unused AudioParamHandler method (was: Remove unused AudioParamHandler)
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8a2e6003ce245e69cedbf4e2a6007a8f335cfc4

commit c8a2e6003ce245e69cedbf4e2a6007a8f335cfc4
Author: Raymond Toy <rtoy@chromium.org>
Date: Tue Oct 17 18:45:23 2017

Remove unused AudioParamHandler method

The method WarnIfOutsideRange is declared but not implemented and not
used anywhere.  Remove it.

Bug:  774659 
Test: None
Change-Id: I1b852348fbea1cab9a5ff64c8a9c0e78423a4532
Reviewed-on: https://chromium-review.googlesource.com/719539
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509452}
[modify] https://crrev.com/c8a2e6003ce245e69cedbf4e2a6007a8f335cfc4/third_party/WebKit/Source/modules/webaudio/AudioParam.h

Comment 3 by rtoy@chromium.org, Oct 18 2017

Status: Fixed (was: Started)

Sign in to add a comment