New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 774651 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

[Bling Bookmarks] replace folder icons in folder picker

Project Member Reported by amyroberts@chromium.org, Oct 13 2017

Issue description

replace icons with new pngs to remove padding per UI review.
 
new foler icons.zip
1.2 KB Download

Comment 1 by martiw@chromium.org, Oct 13 2017

Cc: amyroberts@chromium.org
The icon is replaced in Bookmarks. (crrev.com/c/716438) less than 24 hours ago.  It should appear in the next canary build.

Comment 2 by martiw@chromium.org, Oct 14 2017

The icon replacement change was landed to canary 64.0.3240.0
You may try now.

I will have to merge the change to 63 branch later.

Comment 3 by martiw@chromium.org, Oct 16 2017

Cc: noyau@chromium.org
I downloaded the canary today and verified that the folder icon is changed.

However, the Destination Picker is still using the old icon.

Before we implement a new Destination Picker, should we update the folder icon of the Destination Picker now (icon changed only when new bookmark flag is ON).

Comment 4 by martiw@chromium.org, Oct 16 2017

screenshot attached (if we change icon in destination picker)

destination_picker.png
140 KB View Download

Comment 5 Deleted

+ Pink and Éric to weigh in

Thanks, Marti! 

Well, I think the old icon size in the picker look larger, clearer, and more proportional to the text size. However, I am aware of the need for consistency and shipping less assets. Can we make the size of the new folder asset a bit larger everywhere (i.e. in destination picker and in regular lists in collection views ?). 

Comment 7 by martiw@chromium.org, Oct 16 2017

The existing new folder icon is already used up to entire width of the png:
https://cs.chromium.org/chromium/src/ios/chrome/browser/ui/bookmarks/resources/bookmark_gray_folder_new.imageset/bookmark_gray_folder_new%403x.png?q=%22bookmark_gray_folder_new.imageset/bookmark_gray_folder_new@3x.png%22&sq=package:chromium&dr

We'll need to change code if we want to make it bigger.

And I am not sure it is good to make it bigger.  In my personal opinion, the existing new icon size looks consistent with the favicon and new placeholder icon.

Comment 8 by martiw@chromium.org, Oct 16 2017

Attached new bookmark screenshot, with new folder icon, favicon, placeholder icon
Simulator Screen Shot - iPhone 6 - 2017-10-17 at 00.11.15.png
98.0 KB View Download
Thanks, Marti. Good point about the folder size vs. the favicon size. I still have a preference for bigger in the destination picker but for the sake of consistency we should probably stick with what you have in comment #4. 

Amy: Please weigh in and re-assign back to Marti if all looks good.
Owner: martiw@chromium.org
I agree with the rationale in comment #7, the new folder asset in comment #4 LGTM. 
Status: Started (was: Assigned)
thanks Mardini and Amy!  working on the CL.
The new icon will only be used in the folder picker when new bookmark flag is ON.
So the old bookmark will not be affected.
Project Member

Comment 12 by bugdroid1@chromium.org, Oct 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02dc512287af46ecf3e8089ac733d2143616526a

commit 02dc512287af46ecf3e8089ac733d2143616526a
Author: Marti Wong <martiw@chromium.org>
Date: Tue Oct 17 15:32:18 2017

Use new folder icon in folder picker when new bookmark flag is on.

Bug:  774651 
Change-Id: I91c3120212926bb76e95517874f992ceb04d5359
Reviewed-on: https://chromium-review.googlesource.com/722360
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509393}
[modify] https://crrev.com/02dc512287af46ecf3e8089ac733d2143616526a/ios/chrome/browser/ui/bookmarks/bookmark_folder_table_view_cell.mm

Labels: Merge-Request-63 M-63
Status: Fixed (was: Started)
Summary: [Bling Bookmarks] replace folder icons in folder picker (was: [Bling Bookmarks] replace folder icons)
Project Member

Comment 14 by sheriffbot@chromium.org, Oct 19 2017

Labels: -Merge-Request-63 Hotlist-Merge-Approved Merge-Approved-63
Your change meets the bar and is auto-approved for M63. Please go ahead and merge the CL to branch 3239 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 15 by bugdroid1@chromium.org, Oct 19 2017

Labels: -merge-approved-63 merge-merged-3239
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c0643eb5f0c388b0f866cf5f6488e8c645803d54

commit c0643eb5f0c388b0f866cf5f6488e8c645803d54
Author: Marti Wong <martiw@chromium.org>
Date: Thu Oct 19 05:31:29 2017

Use new folder icon in folder picker when new bookmark flag is on.

Bug:  774651 
Change-Id: I91c3120212926bb76e95517874f992ceb04d5359
Reviewed-on: https://chromium-review.googlesource.com/722360
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#509393}(cherry picked from commit 02dc512287af46ecf3e8089ac733d2143616526a)
Reviewed-on: https://chromium-review.googlesource.com/727441
Reviewed-by: Marti Wong <martiw@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#61}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[modify] https://crrev.com/c0643eb5f0c388b0f866cf5f6488e8c645803d54/ios/chrome/browser/ui/bookmarks/bookmark_folder_table_view_cell.mm

Status: Verified (was: Fixed)
Verified in 64.0.3248.0 Canary, iPhone6 iOS 10.3.3, iPhone8Plus iOS11, iPad Pro iOS11
Looks good.
Verified in:

App Version: 63.0.3239.19 beta
Devices: iPhone 5, iPhone 7, iPad Mini
iOS Version: 9.3.5, 10.3.3, 11.0.2

Old folder icons are replace with new icons only when New Bookmarks are enabled. Please see the screenshot attached.
Foldericons_New.jpg
220 KB View Download

Sign in to add a comment