New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 774622 link

Starred by 1 user
Status: Fixed
Owner:
zhongyi@chromium.org
Closed: Mar 2018
Cc:
█ lorenzo@google.com
rch@chromium.org
█ jri@chromium.org
█ mdumitrescu@google.com
Components:
EstimatedDays: 0
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocked on:
issue 775593


Sign in to add a comment

Implement connection migration version 2

Project Member Reported by zhongyi@chromium.org, Oct 13 2017 
We used to migrate connection immediately on the client side without checking the connectivity of the new path before switching over. This causes some sessions fail which would not necessarily happen if stay on the original network.

To fix this, we introduce connection migration version 2, which does two things on top of version 1:
- add decision picking logics to choose direct migrate or probing then migrate;
- add mechanisms to probe new path so as to discover the connectivity on the new path;
- add logic to "migrate back to default network" which is required if session is using non-default network for some reason.   

This bug will be used to track the progress of the implementation.

Comment 1 by zhongyi@chromium.org, Oct 17 2017

Blockedon: 775593
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/782c67049bc64304ebce1f48119888274602c06c

commit 782c67049bc64304ebce1f48119888274602c06c
Author: Zhongyi Shi <zhongyi@chromium.org>
Date: Tue Nov 14 02:24:27 2017

Add logic to send connectivity probing packet to designated destination
using given packet writer. Probing packet effectively is a padded PING
packet.

relnote: n/a currently unused code.

Manual merge internal change: 175555522

Bug:  774622 
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I3c355c31138fa7999c7a36e6b84cb548b701d91c
Reviewed-on: https://chromium-review.googlesource.com/767011
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516148}
[modify] https://crrev.com/782c67049bc64304ebce1f48119888274602c06c/net/quic/core/quic_connection.cc
[modify] https://crrev.com/782c67049bc64304ebce1f48119888274602c06c/net/quic/core/quic_connection.h
[modify] https://crrev.com/782c67049bc64304ebce1f48119888274602c06c/net/quic/core/quic_framer.cc
[modify] https://crrev.com/782c67049bc64304ebce1f48119888274602c06c/net/quic/core/quic_framer.h
[modify] https://crrev.com/782c67049bc64304ebce1f48119888274602c06c/net/quic/core/quic_framer_test.cc
[modify] https://crrev.com/782c67049bc64304ebce1f48119888274602c06c/net/quic/core/quic_packet_creator.cc
[modify] https://crrev.com/782c67049bc64304ebce1f48119888274602c06c/net/quic/core/quic_packet_creator.h
[modify] https://crrev.com/782c67049bc64304ebce1f48119888274602c06c/net/quic/core/quic_packet_creator_test.cc
[modify] https://crrev.com/782c67049bc64304ebce1f48119888274602c06c/net/quic/core/quic_packet_generator.cc
[modify] https://crrev.com/782c67049bc64304ebce1f48119888274602c06c/net/quic/core/quic_packet_generator.h
[modify] https://crrev.com/782c67049bc64304ebce1f48119888274602c06c/net/quic/core/quic_packet_generator_test.cc
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42573c993f1932b02861b45ef9a67ec11bee7d0c

commit 42573c993f1932b02861b45ef9a67ec11bee7d0c
Author: Zhongyi Shi <zhongyi@chromium.org>
Date: Wed Nov 15 06:19:46 2017

relnote: fix a DCHECK in an unused method: SendConnectivityProbingPacket
which is discovered in an e2e test.

Manual merge internal change: 175635226

Bug:  774622 
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I565434bf59df9dce61f2376352717bba9a125e0e
Reviewed-on: https://chromium-review.googlesource.com/768578
Reviewed-by: Buck Krasic <ckrasic@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516602}
[modify] https://crrev.com/42573c993f1932b02861b45ef9a67ec11bee7d0c/net/quic/core/quic_connection.cc
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea64ccad2225522828eb62a1dafd294721dd59b7

commit ea64ccad2225522828eb62a1dafd294721dd59b7
Author: Zhongyi Shi <zhongyi@chromium.org>
Date: Fri Nov 17 01:47:48 2017

Add logic to receive connectivity probing packet. Server will send a
connectivity probing packet back to the source address of received
connectivity probing packet without latching on the new peer address
from received connectivity probing packet.

relnote: n/a current unused code, flag protected by
quic_server_reply_to_connectivity_probing which is on by default.

Manual merge internal change: 175728966

Bug:  774622 
Change-Id: If0f958cdd2f0540be435cd222ba6f848acb9e185
Reviewed-on: https://chromium-review.googlesource.com/775993
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517240}
[modify] https://crrev.com/ea64ccad2225522828eb62a1dafd294721dd59b7/net/quic/core/quic_connection.cc
[modify] https://crrev.com/ea64ccad2225522828eb62a1dafd294721dd59b7/net/quic/core/quic_connection.h
[modify] https://crrev.com/ea64ccad2225522828eb62a1dafd294721dd59b7/net/quic/core/quic_connection_test.cc
[modify] https://crrev.com/ea64ccad2225522828eb62a1dafd294721dd59b7/net/quic/core/quic_flags_list.h
[modify] https://crrev.com/ea64ccad2225522828eb62a1dafd294721dd59b7/net/quic/core/quic_session.cc
[modify] https://crrev.com/ea64ccad2225522828eb62a1dafd294721dd59b7/net/quic/core/quic_session.h
[modify] https://crrev.com/ea64ccad2225522828eb62a1dafd294721dd59b7/net/quic/core/quic_session_test.cc
[modify] https://crrev.com/ea64ccad2225522828eb62a1dafd294721dd59b7/net/quic/test_tools/quic_packet_creator_peer.cc
[modify] https://crrev.com/ea64ccad2225522828eb62a1dafd294721dd59b7/net/quic/test_tools/quic_packet_creator_peer.h
[modify] https://crrev.com/ea64ccad2225522828eb62a1dafd294721dd59b7/net/quic/test_tools/quic_test_utils.h
[modify] https://crrev.com/ea64ccad2225522828eb62a1dafd294721dd59b7/net/quic/test_tools/simulator/quic_endpoint.h
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8fff75b5f82f72763d7220cf75aa2cf7872c7c61

commit 8fff75b5f82f72763d7220cf75aa2cf7872c7c61
Author: Zhongyi Shi <zhongyi@chromium.org>
Date: Sun Nov 19 21:36:36 2017

Add QuicConnectivityProbingManager which sends connectivity probing
packet on new path. The manager will send out a new connectivity probing
packet if there is no response from the server on the probed path. The
manager will retry after a silent period from the previous sent event with
exponential backoff.
1 unit timeout is the smaller of 2 smoothed rtt from old path, or 600ms.


Bug:  774622 
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I623b8a5aa8da6d553ca16d9f67655d4a32a4a1c9
Reviewed-on: https://chromium-review.googlesource.com/774299
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517737}
[modify] https://crrev.com/8fff75b5f82f72763d7220cf75aa2cf7872c7c61/net/BUILD.gn
[modify] https://crrev.com/8fff75b5f82f72763d7220cf75aa2cf7872c7c61/net/quic/chromium/quic_chromium_client_session.cc
[modify] https://crrev.com/8fff75b5f82f72763d7220cf75aa2cf7872c7c61/net/quic/chromium/quic_chromium_client_session.h
[add] https://crrev.com/8fff75b5f82f72763d7220cf75aa2cf7872c7c61/net/quic/chromium/quic_connectivity_probing_manager.cc
[add] https://crrev.com/8fff75b5f82f72763d7220cf75aa2cf7872c7c61/net/quic/chromium/quic_connectivity_probing_manager.h
[add] https://crrev.com/8fff75b5f82f72763d7220cf75aa2cf7872c7c61/net/quic/chromium/quic_connectivity_probing_manager_test.cc
[modify] https://crrev.com/8fff75b5f82f72763d7220cf75aa2cf7872c7c61/net/quic/chromium/quic_stream_factory.h
[modify] https://crrev.com/8fff75b5f82f72763d7220cf75aa2cf7872c7c61/net/quic/chromium/quic_stream_factory_peer.cc
[modify] https://crrev.com/8fff75b5f82f72763d7220cf75aa2cf7872c7c61/net/quic/chromium/quic_stream_factory_peer.h
[modify] https://crrev.com/8fff75b5f82f72763d7220cf75aa2cf7872c7c61/net/quic/chromium/test_task_runner.cc
[modify] https://crrev.com/8fff75b5f82f72763d7220cf75aa2cf7872c7c61/net/quic/chromium/test_task_runner.h
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/647956240a4eaf17b36616ad2ccc8a5c41c96e83

commit 647956240a4eaf17b36616ad2ccc8a5c41c96e83
Author: Zhongyi Shi <zhongyi@chromium.org>
Date: Mon Nov 20 02:21:49 2017

Add config for both cronet and browser to use connection migration v2,
this in particular controls migration with platform notification.

Bug:  774622 
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I410bcc3f5ee0280465b3c592cbf81cb0fea15c27
Reviewed-on: https://chromium-review.googlesource.com/776331
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517746}
[modify] https://crrev.com/647956240a4eaf17b36616ad2ccc8a5c41c96e83/components/cronet/url_request_context_config.cc
[modify] https://crrev.com/647956240a4eaf17b36616ad2ccc8a5c41c96e83/components/cronet/url_request_context_config_unittest.cc
[modify] https://crrev.com/647956240a4eaf17b36616ad2ccc8a5c41c96e83/components/network_session_configurator/browser/network_session_configurator.cc
[modify] https://crrev.com/647956240a4eaf17b36616ad2ccc8a5c41c96e83/components/network_session_configurator/browser/network_session_configurator_unittest.cc
[modify] https://crrev.com/647956240a4eaf17b36616ad2ccc8a5c41c96e83/net/http/http_network_session.cc
[modify] https://crrev.com/647956240a4eaf17b36616ad2ccc8a5c41c96e83/net/http/http_network_session.h
[modify] https://crrev.com/647956240a4eaf17b36616ad2ccc8a5c41c96e83/net/http/http_proxy_client_socket_wrapper_unittest.cc
[modify] https://crrev.com/647956240a4eaf17b36616ad2ccc8a5c41c96e83/net/quic/chromium/quic_stream_factory.cc
[modify] https://crrev.com/647956240a4eaf17b36616ad2ccc8a5c41c96e83/net/quic/chromium/quic_stream_factory.h
[modify] https://crrev.com/647956240a4eaf17b36616ad2ccc8a5c41c96e83/net/quic/chromium/quic_stream_factory_fuzzer.cc
[modify] https://crrev.com/647956240a4eaf17b36616ad2ccc8a5c41c96e83/net/quic/chromium/quic_stream_factory_test.cc
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f587cc02551234504beb9722e2864ee441f522e

commit 5f587cc02551234504beb9722e2864ee441f522e
Author: Zhongyi Shi <zhongyi@chromium.org>
Date: Tue Nov 21 23:24:17 2017

Add connection migration handling code
with migrate back to default
network support. We will not mark session as going away until consistent
failure on migrating back to the default network with no platform notifications.

This also handles packet write error.

Bug:  774622 
Change-Id: I9e9fa301d60d7a56c3d1b92af315932451e7db7a
Reviewed-on: https://chromium-review.googlesource.com/777612
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Reviewed-by: Jana Iyengar <jri@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518436}
[modify] https://crrev.com/5f587cc02551234504beb9722e2864ee441f522e/net/log/net_log_event_type_list.h
[modify] https://crrev.com/5f587cc02551234504beb9722e2864ee441f522e/net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc
[modify] https://crrev.com/5f587cc02551234504beb9722e2864ee441f522e/net/quic/chromium/quic_chromium_client_session.cc
[modify] https://crrev.com/5f587cc02551234504beb9722e2864ee441f522e/net/quic/chromium/quic_chromium_client_session.h
[modify] https://crrev.com/5f587cc02551234504beb9722e2864ee441f522e/net/quic/chromium/quic_chromium_client_session_test.cc
[modify] https://crrev.com/5f587cc02551234504beb9722e2864ee441f522e/net/quic/chromium/quic_connectivity_probing_manager.cc
[modify] https://crrev.com/5f587cc02551234504beb9722e2864ee441f522e/net/quic/chromium/quic_connectivity_probing_manager.h
[modify] https://crrev.com/5f587cc02551234504beb9722e2864ee441f522e/net/quic/chromium/quic_connectivity_probing_manager_test.cc
[modify] https://crrev.com/5f587cc02551234504beb9722e2864ee441f522e/net/quic/chromium/quic_http_stream_test.cc
[modify] https://crrev.com/5f587cc02551234504beb9722e2864ee441f522e/net/quic/chromium/quic_proxy_client_socket_unittest.cc
[modify] https://crrev.com/5f587cc02551234504beb9722e2864ee441f522e/net/quic/chromium/quic_stream_factory.cc
[modify] https://crrev.com/5f587cc02551234504beb9722e2864ee441f522e/net/quic/chromium/quic_stream_factory.h
[modify] https://crrev.com/5f587cc02551234504beb9722e2864ee441f522e/net/quic/chromium/quic_stream_factory_test.cc
[modify] https://crrev.com/5f587cc02551234504beb9722e2864ee441f522e/net/quic/core/quic_connection.cc
[modify] https://crrev.com/5f587cc02551234504beb9722e2864ee441f522e/net/quic/core/quic_connection.h
[modify] https://crrev.com/5f587cc02551234504beb9722e2864ee441f522e/net/quic/core/quic_connection_test.cc
[modify] https://crrev.com/5f587cc02551234504beb9722e2864ee441f522e/net/quic/test_tools/quic_test_utils.h
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6eb074291f8135fd4288526e92679f83ad2f5a46

commit 6eb074291f8135fd4288526e92679f83ad2f5a46
Author: Zhongyi Shi <zhongyi@chromium.org>
Date: Wed Nov 22 06:59:23 2017

Turn on the connection migration v2 for write error

Bug:  774622 
Change-Id: Ieb331d387b9e1f55eb0e2b8bec0c662918a2790a
Reviewed-on: https://chromium-review.googlesource.com/783523
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518556}
[modify] https://crrev.com/6eb074291f8135fd4288526e92679f83ad2f5a46/net/quic/chromium/quic_chromium_client_session.cc
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 22 2017

Labels: merge-merged-3275
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af3467c7a6fb767009f22d2ad1dd40a7460e8ee2

commit af3467c7a6fb767009f22d2ad1dd40a7460e8ee2
Author: Zhongyi Shi <zhongyi@chromium.org>
Date: Wed Nov 22 22:07:41 2017

Turn on the connection migration v2 for write error

TBR=zhongyi@chromium.org

(cherry picked from commit 6eb074291f8135fd4288526e92679f83ad2f5a46)

Bug:  774622 
Change-Id: Ieb331d387b9e1f55eb0e2b8bec0c662918a2790a
Reviewed-on: https://chromium-review.googlesource.com/783523
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#518556}
Reviewed-on: https://chromium-review.googlesource.com/786314
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/branch-heads/3275@{#3}
Cr-Branched-From: 57df29264aaef643e8c48bead8701bacd94d1fbc-refs/heads/master@{#518486}
[modify] https://crrev.com/af3467c7a6fb767009f22d2ad1dd40a7460e8ee2/net/quic/chromium/quic_chromium_client_session.cc
Project Member

Comment 10 by bugdroid1@chromium.org, Dec 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4683a37ef679c4b1ea669855567a7938724389a

commit f4683a37ef679c4b1ea669855567a7938724389a
Author: Zhongyi Shi <zhongyi@chromium.org>
Date: Fri Dec 01 00:03:28 2017

Add a different config param to control connection migration v2 on
path degrading

Bug:  774622 
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I0c3841858a2f285414c0fc6cb8808ebea06a26b4
Reviewed-on: https://chromium-review.googlesource.com/794810
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520758}
[modify] https://crrev.com/f4683a37ef679c4b1ea669855567a7938724389a/components/cronet/url_request_context_config.cc
[modify] https://crrev.com/f4683a37ef679c4b1ea669855567a7938724389a/components/cronet/url_request_context_config_unittest.cc
[modify] https://crrev.com/f4683a37ef679c4b1ea669855567a7938724389a/components/network_session_configurator/browser/network_session_configurator.cc
[modify] https://crrev.com/f4683a37ef679c4b1ea669855567a7938724389a/components/network_session_configurator/browser/network_session_configurator_unittest.cc
[modify] https://crrev.com/f4683a37ef679c4b1ea669855567a7938724389a/net/http/http_network_session.cc
[modify] https://crrev.com/f4683a37ef679c4b1ea669855567a7938724389a/net/http/http_network_session.h
[modify] https://crrev.com/f4683a37ef679c4b1ea669855567a7938724389a/net/http/http_proxy_client_socket_wrapper_unittest.cc
[modify] https://crrev.com/f4683a37ef679c4b1ea669855567a7938724389a/net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc
[modify] https://crrev.com/f4683a37ef679c4b1ea669855567a7938724389a/net/quic/chromium/quic_chromium_client_session.cc
[modify] https://crrev.com/f4683a37ef679c4b1ea669855567a7938724389a/net/quic/chromium/quic_chromium_client_session.h
[modify] https://crrev.com/f4683a37ef679c4b1ea669855567a7938724389a/net/quic/chromium/quic_chromium_client_session_test.cc
[modify] https://crrev.com/f4683a37ef679c4b1ea669855567a7938724389a/net/quic/chromium/quic_http_stream_test.cc
[modify] https://crrev.com/f4683a37ef679c4b1ea669855567a7938724389a/net/quic/chromium/quic_proxy_client_socket_unittest.cc
[modify] https://crrev.com/f4683a37ef679c4b1ea669855567a7938724389a/net/quic/chromium/quic_stream_factory.cc
[modify] https://crrev.com/f4683a37ef679c4b1ea669855567a7938724389a/net/quic/chromium/quic_stream_factory.h
[modify] https://crrev.com/f4683a37ef679c4b1ea669855567a7938724389a/net/quic/chromium/quic_stream_factory_fuzzer.cc
[modify] https://crrev.com/f4683a37ef679c4b1ea669855567a7938724389a/net/quic/chromium/quic_stream_factory_test.cc
Project Member

Comment 11 by bugdroid1@chromium.org, Dec 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56e44b20420dab5682cc48920ed42ce487e9e04f

commit 56e44b20420dab5682cc48920ed42ce487e9e04f
Author: Zhongyi Shi <zhongyi@chromium.org>
Date: Sat Dec 02 00:06:33 2017

Fix QuicStreamFactoryFuzzer initialization with connection migration v2

Bug:  790997 ,  774622 
Change-Id: I4b254e962d8aed0c10130b891d250980f412b088
Reviewed-on: https://chromium-review.googlesource.com/803620
Reviewed-by: Buck Krasic <ckrasic@chromium.org>
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521135}
[modify] https://crrev.com/56e44b20420dab5682cc48920ed42ce487e9e04f/net/quic/chromium/quic_stream_factory_fuzzer.cc
Project Member

Comment 12 by bugdroid1@chromium.org, Dec 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56e44b20420dab5682cc48920ed42ce487e9e04f

commit 56e44b20420dab5682cc48920ed42ce487e9e04f
Author: Zhongyi Shi <zhongyi@chromium.org>
Date: Sat Dec 02 00:06:33 2017

Fix QuicStreamFactoryFuzzer initialization with connection migration v2

Bug:  790997 ,  774622 
Change-Id: I4b254e962d8aed0c10130b891d250980f412b088
Reviewed-on: https://chromium-review.googlesource.com/803620
Reviewed-by: Buck Krasic <ckrasic@chromium.org>
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521135}
[modify] https://crrev.com/56e44b20420dab5682cc48920ed42ce487e9e04f/net/quic/chromium/quic_stream_factory_fuzzer.cc
Project Member

Comment 13 by bugdroid1@chromium.org, Dec 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef52e20abb8dd510ea8a111d9cee8dbce55194fd

commit ef52e20abb8dd510ea8a111d9cee8dbce55194fd
Author: Zhongyi Shi <zhongyi@chromium.org>
Date: Sat Dec 02 10:41:43 2017

Add a label in URLRequest NetLog to indicate the connection migration mode
it is running with.

QUIC Connection Migration: add a label in each URLRequest to indicate
connection migration mode it's running with so that URLRequest and associated
QuicSession can be differentiated in a single NetLog if multiple CronetEngines
with different experiment configurations are running at the same time.

Bug:  774622 
Change-Id: I003f0ac83efbec7ac41d16a83ef5d0230d4aa7d1
Reviewed-on: https://chromium-review.googlesource.com/804296
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521210}
[modify] https://crrev.com/ef52e20abb8dd510ea8a111d9cee8dbce55194fd/net/log/net_log_event_type_list.h
[modify] https://crrev.com/ef52e20abb8dd510ea8a111d9cee8dbce55194fd/net/quic/chromium/quic_chromium_client_session.cc
[modify] https://crrev.com/ef52e20abb8dd510ea8a111d9cee8dbce55194fd/net/quic/chromium/quic_chromium_client_session.h
[modify] https://crrev.com/ef52e20abb8dd510ea8a111d9cee8dbce55194fd/net/quic/chromium/quic_http_stream.cc
Project Member

Comment 14 by bugdroid1@chromium.org, Dec 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f482134e73cb4aef135d9ce951db0afae3cb59b9

commit f482134e73cb4aef135d9ce951db0afae3cb59b9
Author: Zhongyi Shi <zhongyi@chromium.org>
Date: Tue Dec 05 01:18:18 2017

Add view for connection migration v2 field in net internal.

Bug:  774622 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iebb15655a503c33d674b1a1cb636ea788ffdecde
Reviewed-on: https://chromium-review.googlesource.com/803632
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521570}
[modify] https://crrev.com/f482134e73cb4aef135d9ce951db0afae3cb59b9/chrome/browser/resources/net_internals/quic_view.html

Comment 15 by zhongyi@chromium.org, Mar 2 2018

Status: Fixed (was: Assigned)
The major implementation work has been completed. The feature is deployed/launched in some Cronet embedders. Closing this one. 

Performance improvement work will be tracked at Issue 818259.
►

Sign in to add a comment