New issue
Advanced search Search tips

Issue 774612 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Oct 4
Cc:
dtrainor@chromium.org
peter@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Origin display needs to be secure

Project Member Reported by delph...@chromium.org, Oct 13 2017 
From John Mellor: Origin display needs to be made secure, i.e. we need to ensure the true origin always shows even if the developer shows a long title that contains "(https://fakeorigin.com)".

Currently we're just display "<title> <origin>" which means long titles (or in fact very short titles) can hide the origin.

Comment 1 by joh...@chromium.org, Oct 16 2017 

See  issue 509834  and  issue 717725  for inspiration. Ideally the origin would be displayed using the same logic as for Web Notifications.

Comment 2 by delph...@chromium.org, Nov 14 2017

Cc: dtrainor@chromium.org
It would be great to have another line of text to display both origin and title.

Comment 3 by delph...@chromium.org, Jan 24 2018

Owner: ----
Status: Available (was: Assigned)

Comment 4 by na...@chromium.org, Jul 4

Owner: na...@chromium.org
Status: Assigned (was: Available)

Comment 5 by na...@chromium.org, Aug 7

Labels: BlocksMVP
Owner: ----
Status: Available (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c8d1ba73724b172b4a1d3d7edf80536d3e87fed

commit 6c8d1ba73724b172b4a1d3d7edf80536d3e87fed
Author: Rayan Kanso <rayankans@chromium.org>
Date: Wed Oct 03 17:07:51 2018

Display formatted origin at top of download notification when provided

The origin will be set if provided to the OfflineItem a non-incognito profile.
screenshot: https://lh3.googleusercontent.com/-BCLL-YuqB28/W6j_XbF542I/AAAAAAAABLA/Mq7jMbOdDdAPPZh-rfFVbDx7JIfLTKlEACL0BGAYYCw/h261/2018-09-24.png

Bug:  774612 
Change-Id: I34aa8fa51195443a242e4bd6e068d2d408737fbb
Reviewed-on: https://chromium-review.googlesource.com/1240304
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596260}
[modify] https://crrev.com/6c8d1ba73724b172b4a1d3d7edf80536d3e87fed/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadBroadcastManager.java
[modify] https://crrev.com/6c8d1ba73724b172b4a1d3d7edf80536d3e87fed/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationFactory.java
[modify] https://crrev.com/6c8d1ba73724b172b4a1d3d7edf80536d3e87fed/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService2.java
[modify] https://crrev.com/6c8d1ba73724b172b4a1d3d7edf80536d3e87fed/chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier2.java
[modify] https://crrev.com/6c8d1ba73724b172b4a1d3d7edf80536d3e87fed/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationService2Test.java
[modify] https://crrev.com/6c8d1ba73724b172b4a1d3d7edf80536d3e87fed/chrome/android/javatests/src/org/chromium/chrome/browser/download/MockDownloadNotificationService2.java
[modify] https://crrev.com/6c8d1ba73724b172b4a1d3d7edf80536d3e87fed/chrome/browser/background_fetch/background_fetch_browsertest.cc
[modify] https://crrev.com/6c8d1ba73724b172b4a1d3d7edf80536d3e87fed/chrome/browser/background_fetch/background_fetch_delegate_impl.cc
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec6816b0fd871e2561f2e57ce29cc2741e68a227

commit ec6816b0fd871e2561f2e57ce29cc2741e68a227
Author: Rayan Kanso <rayankans@chromium.org>
Date: Wed Oct 03 17:11:57 2018

Include origin in background fetch desktop download notifications

The origin will be displayed in the status section of the notification.
Very long origins will be elided to display the eTLD+1.

Screenshots:
https://lh3.googleusercontent.com/-eFfCFlWJf3Y/W7NlhkLY07I/AAAAAAAABMw/_RhaEe6jlnM1X-xXfsIoZ7uyJOnfd6JngCL0BGAYYCw/h48/desktoporigin1.png
https://lh3.googleusercontent.com/-TiCAYHS9hfg/W7Nlep2HgkI/AAAAAAAABMk/cG6uFKK8sBcc8P-cmy9HtqEZHTp_2S2hgCL0BGAYYCw/h50/desktoporiginevil.png

Bug:  774612 
Change-Id: Iacd874b5fd03f3e6e37c204e9df9e4cbaba67435
Reviewed-on: https://chromium-review.googlesource.com/1256943
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596262}
[modify] https://crrev.com/ec6816b0fd871e2561f2e57ce29cc2741e68a227/chrome/browser/download/download_ui_model.cc
[modify] https://crrev.com/ec6816b0fd871e2561f2e57ce29cc2741e68a227/chrome/browser/download/download_ui_model.h
[modify] https://crrev.com/ec6816b0fd871e2561f2e57ce29cc2741e68a227/chrome/browser/download/offline_item_model.cc
[modify] https://crrev.com/ec6816b0fd871e2561f2e57ce29cc2741e68a227/chrome/browser/download/offline_item_model.h
[modify] https://crrev.com/ec6816b0fd871e2561f2e57ce29cc2741e68a227/chrome/browser/ui/views/download/download_item_view.cc
[modify] https://crrev.com/ec6816b0fd871e2561f2e57ce29cc2741e68a227/chrome/browser/ui/views/download/download_item_view.h
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/117f07a4f90f4169a43320158279b870f93a7d46

commit 117f07a4f90f4169a43320158279b870f93a7d46
Author: Rayan Kanso <rayankans@chromium.org>
Date: Wed Oct 03 17:20:27 2018

Add a flag to OfflineItem for showing the origin in notifications.

Background Fetch notifications should always show the origin in the
notification. In order to not break the behavior of other download
notifications, a flag was added to OfflineItem to show the origin.

Bug:  774612 
Change-Id: I2f08e7e7d71a6520d02443a0961733d173242372
Reviewed-on: https://chromium-review.googlesource.com/1259011
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596265}
[modify] https://crrev.com/117f07a4f90f4169a43320158279b870f93a7d46/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadBroadcastManager.java
[modify] https://crrev.com/117f07a4f90f4169a43320158279b870f93a7d46/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadInfo.java
[modify] https://crrev.com/117f07a4f90f4169a43320158279b870f93a7d46/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationFactory.java
[modify] https://crrev.com/117f07a4f90f4169a43320158279b870f93a7d46/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService2.java
[modify] https://crrev.com/117f07a4f90f4169a43320158279b870f93a7d46/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUpdate.java
[modify] https://crrev.com/117f07a4f90f4169a43320158279b870f93a7d46/chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier2.java
[modify] https://crrev.com/117f07a4f90f4169a43320158279b870f93a7d46/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationService2Test.java
[modify] https://crrev.com/117f07a4f90f4169a43320158279b870f93a7d46/chrome/android/javatests/src/org/chromium/chrome/browser/download/MockDownloadNotificationService2.java
[modify] https://crrev.com/117f07a4f90f4169a43320158279b870f93a7d46/chrome/browser/background_fetch/background_fetch_delegate_impl.cc
[modify] https://crrev.com/117f07a4f90f4169a43320158279b870f93a7d46/chrome/browser/download/offline_item_model.cc
[modify] https://crrev.com/117f07a4f90f4169a43320158279b870f93a7d46/components/offline_items_collection/core/android/java/src/org/chromium/components/offline_items_collection/OfflineItem.java
[modify] https://crrev.com/117f07a4f90f4169a43320158279b870f93a7d46/components/offline_items_collection/core/android/java/src/org/chromium/components/offline_items_collection/bridges/OfflineItemBridge.java
[modify] https://crrev.com/117f07a4f90f4169a43320158279b870f93a7d46/components/offline_items_collection/core/android/offline_item_bridge.cc
[modify] https://crrev.com/117f07a4f90f4169a43320158279b870f93a7d46/components/offline_items_collection/core/offline_item.cc
[modify] https://crrev.com/117f07a4f90f4169a43320158279b870f93a7d46/components/offline_items_collection/core/offline_item.h
[modify] https://crrev.com/117f07a4f90f4169a43320158279b870f93a7d46/components/offline_items_collection/core/test_support/offline_item_test_support.cc

Comment 9 by rayankans@chromium.org, Oct 4

Status: Fixed (was: Available)
►

Sign in to add a comment