New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 774601 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: ----



Sign in to add a comment

Chrome Home / Modern auto-sign in snackbar has incorrect text color

Project Member Reported by cl...@chromium.org, Oct 13 2017

Issue description

Application Version (from "Chrome Settings > About Chrome"): 63.0.3239.0

What steps will reproduce the problem?
(1) Enable #enable-chrome-home
(2) Sign into page with Credential Manager API auto-sign in

What is the expected result?
Snackbar has white text on blue background.

What happens instead?
Snackbar has black text on blue background.


 
cz0Uo91ivyy.png
165 KB View Download

Comment 1 by cl...@chromium.org, Oct 13 2017

This bug is a result of the change in https://bugs.chromium.org/p/chromium/issues/detail?id=731321
Labels: -Pri-2 -Hotlist-Home-needs-triage M-63 Hotlist-Chrome-Home Pri-1
Status: Assigned (was: Untriaged)
We may want to merge a fix for to 63 (TBD). Becky, will you please take a look? I think we just need to expose a way to set the snackbar text appearance similar to Snackbar#setBackground()

Comment 3 Deleted

Comment 4 by hwi@chromium.org, Oct 13 2017

Rephrasing: If the fix is to change the color of the blue bg snackbar to match the white bg snackbar (modern), I recommend we discuss with the CM Api team (+zkoch). The color choice (blue bg and white text) was intentional.
Status: Started (was: Assigned)
I think we just want to fix the text color for auto-sign snackbar?

Comment 6 by hwi@chromium.org, Oct 13 2017

c5 - Got it. Sounds good. Thanks Becky! 

Please disregard c3 & c4. 
Labels: Merge-Request-63
Requesting a merge for the small (+28, -2) CL in #7. The change fixes the text color on the auto-signin snackbar text color. The color regressed when Chrome Home is enabled due to the snackbar visual refresh.
Project Member

Comment 9 by sheriffbot@chromium.org, Oct 17 2017

Labels: -Merge-Request-63 Hotlist-Merge-Approved Merge-Approved-63
Your change meets the bar and is auto-approved for M63. Please go ahead and merge the CL to branch 3239 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 17 2017

Labels: -merge-approved-63 merge-merged-3239
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86afe6cbc99912553f5bce177cc1860fe31b7525

commit 86afe6cbc99912553f5bce177cc1860fe31b7525
Author: Becky Zhou <huayinz@chromium.org>
Date: Tue Oct 17 15:52:44 2017

[Chrome Home] Fix auto-signin snackbar text color

Bug:  774601 
Change-Id: I9bb19d3ecacc57df5918e24f5c5b940fbd136a4d
Reviewed-on: https://chromium-review.googlesource.com/719880
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#508872}(cherry picked from commit 73dde0d5a6a2bfcd42d7b39b22e0c2c235469b34)
Reviewed-on: https://chromium-review.googlesource.com/723640
Cr-Commit-Position: refs/branch-heads/3239@{#31}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[modify] https://crrev.com/86afe6cbc99912553f5bce177cc1860fe31b7525/chrome/android/java/src/org/chromium/chrome/browser/snackbar/Snackbar.java
[modify] https://crrev.com/86afe6cbc99912553f5bce177cc1860fe31b7525/chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarView.java
[modify] https://crrev.com/86afe6cbc99912553f5bce177cc1860fe31b7525/chrome/android/java/src/org/chromium/chrome/browser/snackbar/smartlockautosignin/AutoSigninSnackbarController.java

Status: Fixed (was: Started)

Sign in to add a comment