New issue
Advanced search Search tips

Issue 774589 link

Starred by 1 user
Status: Fixed
Owner:
rtoy@chromium.org
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Display AudioParam warnings for AudioWorklets

Project Member Reported by rtoy@chromium.org, Oct 13 2017 
When an AudioParam needs to print a warning message, the name of the
AudioParam is included to help the user know which AudioParam is
affected.  Currently, however, AudioParams from an AudioWorklet have
user-defined names that aren't displayed; a generic
"AudioWorklet.customParameter" is displayed.

Add support for this, to make it uniform with existing AudioParams.

Comment 1 by rtoy@chromium.org, Oct 20 2017

Owner: rtoy@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d33dd8fb42f4f2edf9a9a8c88504dc20bde2bfe4

commit d33dd8fb42f4f2edf9a9a8c88504dc20bde2bfe4
Author: Raymond Toy <rtoy@chromium.org>
Date: Tue Oct 24 01:50:16 2017

Display AudioWorklet AudioParam names in warning messages

When AudioParam warnings are displayed, include the user-specified
AudioParam name and AudioWorklet name in the message.

Bug:  774589 
Test: AudioParam/worklet-warnings.html
Change-Id: I7ed35737acb5122c86ba05eeda84748804880bfb
Reviewed-on: https://chromium-review.googlesource.com/719424
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510998}
[add] https://crrev.com/d33dd8fb42f4f2edf9a9a8c88504dc20bde2bfe4/third_party/WebKit/LayoutTests/webaudio/AudioParam/worklet-warnings-expected.txt
[add] https://crrev.com/d33dd8fb42f4f2edf9a9a8c88504dc20bde2bfe4/third_party/WebKit/LayoutTests/webaudio/AudioParam/worklet-warnings.html
[add] https://crrev.com/d33dd8fb42f4f2edf9a9a8c88504dc20bde2bfe4/third_party/WebKit/LayoutTests/webaudio/resources/worklet-test.js
[modify] https://crrev.com/d33dd8fb42f4f2edf9a9a8c88504dc20bde2bfe4/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp
[modify] https://crrev.com/d33dd8fb42f4f2edf9a9a8c88504dc20bde2bfe4/third_party/WebKit/Source/modules/webaudio/AudioListener.cpp
[modify] https://crrev.com/d33dd8fb42f4f2edf9a9a8c88504dc20bde2bfe4/third_party/WebKit/Source/modules/webaudio/AudioParam.cpp
[modify] https://crrev.com/d33dd8fb42f4f2edf9a9a8c88504dc20bde2bfe4/third_party/WebKit/Source/modules/webaudio/AudioParam.h
[modify] https://crrev.com/d33dd8fb42f4f2edf9a9a8c88504dc20bde2bfe4/third_party/WebKit/Source/modules/webaudio/AudioWorkletNode.cpp
[modify] https://crrev.com/d33dd8fb42f4f2edf9a9a8c88504dc20bde2bfe4/third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.cpp
[modify] https://crrev.com/d33dd8fb42f4f2edf9a9a8c88504dc20bde2bfe4/third_party/WebKit/Source/modules/webaudio/ConstantSourceNode.cpp
[modify] https://crrev.com/d33dd8fb42f4f2edf9a9a8c88504dc20bde2bfe4/third_party/WebKit/Source/modules/webaudio/DelayNode.cpp
[modify] https://crrev.com/d33dd8fb42f4f2edf9a9a8c88504dc20bde2bfe4/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp
[modify] https://crrev.com/d33dd8fb42f4f2edf9a9a8c88504dc20bde2bfe4/third_party/WebKit/Source/modules/webaudio/GainNode.cpp
[modify] https://crrev.com/d33dd8fb42f4f2edf9a9a8c88504dc20bde2bfe4/third_party/WebKit/Source/modules/webaudio/OscillatorNode.cpp
[modify] https://crrev.com/d33dd8fb42f4f2edf9a9a8c88504dc20bde2bfe4/third_party/WebKit/Source/modules/webaudio/PannerNode.cpp
[modify] https://crrev.com/d33dd8fb42f4f2edf9a9a8c88504dc20bde2bfe4/third_party/WebKit/Source/modules/webaudio/StereoPannerNode.cpp

Comment 3 by rtoy@chromium.org, Oct 24 2017

Status: Fixed (was: Started)
►

Sign in to add a comment