NOTREACHED hit viewing chrome://settings/siteData |
||||||||
Issue descriptionTip of tree 15e7fd19d52ac5f7da45984a13ebcb264af1ca6d r508735 * Build/run Chrome as debug * Go to chrome://settings/siteData Hits NOTREACHED: FATAL:settings_cookies_view_handler.cc(115)] Check failed: false. GetCategoryLabelID() is being called with TYPE_QUOTA which isn't handled. Relevant bits of stack: #3 (anonymous namespace)::GetCategoryLabelID() #4 settings::CookiesViewHandler::SendLocalDataList() #5 settings::CookiesViewHandler::HandleGetDisplayList() #6 _ZN4base8internal13FunctorTraitsIMN10extensions28ExtensionWebContentsObserverEFvPN7content15RenderFrameHostEEvE6InvokeIPS3_JS6_EEEvS8_OT_DpOT0_ #7 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKMN10extensions28ExtensionWebContentsObserverEFvPN7content15RenderFrameHostEEJPS5_S8_EEEvOT_DpOT0_ #8 _ZN4base8internal7InvokerINS0_9BindStateIMN10extensions28ExtensionWebContentsObserverEFvPN7content15RenderFrameHostEEJNS0_17UnretainedWrapperIS4_EEEEEFvS7_EE7RunImplIRKS9_RKNSt3__15tupleIJSB_EEEJLm0EEEEvOT_OT0_NSI_16integer_sequenceImJXspT1_EEEEOS7_ #9 _ZN4base8internal7InvokerINS0_9BindStateIMN10extensions28ExtensionWebContentsObserverEFvPN7content15RenderFrameHostEEJNS0_17UnretainedWrapperIS4_EEEEEFvS7_EE3RunEPNS0_13BindStateBaseEOS7_ #10 _ZNKR4base17RepeatingCallbackIFvPN7content11WebContentsEEE3RunES3_ #11 content::WebUIImpl::ProcessWebUIMessage() #12 content::WebUIImpl::OnWebUISend()
,
Oct 13 2017
Guessing this is related to https://chromium-review.googlesource.com/c/chromium/src/+/714241.
,
Oct 13 2017
,
Oct 13 2017
,
Oct 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f097403ad0a17bb610823929b3a0a42c8afb9b3b commit f097403ad0a17bb610823929b3a0a42c8afb9b3b Author: Dave Schuyler <dschuyler@chromium.org> Date: Fri Oct 13 23:37:31 2017 [MD settings] fix not reached error on quota local data This CL checks for quota local data nodes and omits them from the local data list. This is a workaround for crbug.com/642955. Bug: 774586 Change-Id: I57109ce258c26abf844ef8953272066a09eedd26 Reviewed-on: https://chromium-review.googlesource.com/719349 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#508866} [modify] https://crrev.com/f097403ad0a17bb610823929b3a0a42c8afb9b3b/chrome/browser/ui/webui/settings/settings_cookies_view_handler.cc
,
Oct 14 2017
,
Oct 18 2017
,
Oct 19 2017
Please add appropriate OSs.
,
Oct 19 2017
,
Oct 19 2017
Your change meets the bar and is auto-approved for M63. Please go ahead and merge the CL to branch 3239 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 19 2017
Please merge your change to M63 branch 3239 before 4:00 PM PT tomorrow, Friday, so we can take it in for next dev release. Thank you.
,
Oct 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3a9887f771525d5ffb9be1f73aca43f0f4d72044 commit 3a9887f771525d5ffb9be1f73aca43f0f4d72044 Author: Dave Schuyler <dschuyler@chromium.org> Date: Fri Oct 20 00:02:34 2017 [MD settings] fix not reached error on quota local data This CL checks for quota local data nodes and omits them from the local data list. This is a workaround for crbug.com/642955. Bug: 774586 Change-Id: I57109ce258c26abf844ef8953272066a09eedd26 Reviewed-on: https://chromium-review.googlesource.com/719349 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#508866}(cherry picked from commit f097403ad0a17bb610823929b3a0a42c8afb9b3b) Reviewed-on: https://chromium-review.googlesource.com/729224 Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#95} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/3a9887f771525d5ffb9be1f73aca43f0f4d72044/chrome/browser/ui/webui/settings/settings_cookies_view_handler.cc |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by dpa...@chromium.org
, Oct 13 2017Owner: dschuyler@chromium.org
Status: Assigned (was: Untriaged)