New issue
Advanced search Search tips

Issue 774563 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug


Sign in to add a comment

Harmony - make icon colors conform to MD specs

Project Member Reported by varkha@chromium.org, Oct 13 2017

Issue description

Comment 1 by varkha@chromium.org, Oct 13 2017

Assuming this is needed for all icons it should be at least necessary to change:

kChromeIconGrey to SkColorSetRGB(0x75, 0x75, 0x75) here:
https://cs.chromium.org/chromium/src/ui/gfx/color_palette.h?type=cs&sq=package:chromium&l=16

and change the disabled color ratio here:
https://cs.chromium.org/chromium/src/ui/views/controls/button/image_button_factory.cc?type=cs&q=disabled_color&sq=package:chromium&l=35
to be 0xff * 0.705 instead of 0xff / 2 .

There might be other places that could set the icon colors explicitly.

Comment 2 by varkha@chromium.org, Oct 13 2017

Draft CL for the work in #1 here - https://chromium-review.googlesource.com/c/chromium/src/+/718842

Comment 3 by varkha@chromium.org, Oct 13 2017

Zoom, Find in page and other icons with the patch in #2.
icon-colors.png
15.3 KB View Download

Comment 4 by bettes@chromium.org, Oct 20 2017

Thanks for filing! Can you remind me again how to interpret 0xFF? 

Comment 5 by est...@chromium.org, Oct 20 2017

0xFF is 100% opacity

Comment 6 by bettes@chromium.org, Oct 20 2017

Owner: bsep@chromium.org
Okay, assigning this to bsep for visibility and prioritization. Ideally we can do this before 64 branch

Comment 7 by bsep@chromium.org, Oct 30 2017

Owner: pbos@chromium.org
Load balancing

The close-x for dialogs seems to be set to just black, which is the default for icon buttons, here: https://cs.chromium.org/chromium/src/ui/views/controls/button/image_button_factory.h?dr=CSs&l=31

Comment 8 by pbos@chromium.org, Nov 13 2017

Cc: bsep@chromium.org pbos@chromium.org
Owner: pkasting@chromium.org
My progress is here: https://chromium-review.googlesource.com/c/chromium/src/+/752028

estade@ thought it'd be better to do in one swoop, so this hasn't landed yet. I'll be out for three weeks effectively as of tomorrow (work remotely for like 3 days and then be gone for two) and this won't be landing before that. Since this is very broad surface and requires some time to land bsep@ thought it'd make sense to assign it to you.

Feel free to continue off of that patch or basically look at it for places I found that needed to change. I think a big part of the work will be recoloring png files or update chrome:// favicons to not use them.
Blocking: 651643
Blocking: 651682
Blocking: 651681

Comment 12 by pbos@chromium.org, Jan 5 2018

Owner: pbos@chromium.org
Taking back per offline discussion.
Blocking: 686285
Project Member

Comment 14 by bugdroid1@chromium.org, Feb 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f43dc78128f4977252d8eb3ab2f1d3302f9562cb

commit f43dc78128f4977252d8eb3ab2f1d3302f9562cb
Author: Peter Boström <pbos@chromium.org>
Date: Wed Feb 28 07:27:23 2018

Use Material Design colors for UI icons.

This changes icons generated with use of SetImageFromVectorIcon or
DeriveDefaultIconColor to generate #757575 from a black related text
color. The use of alpha in SetImageFromVectorIcon is changed to result
in #9E9E9E for disabled icons when used to generate icons for black
text.

Some of the favicons are changed to have a MD-blue icon as part of
WebUI branding.

Bug:  chromium:774563 
Change-Id: I978b1cba4d33a06e834f0ff7d74d3dbc6a305b57
Reviewed-on: https://chromium-review.googlesource.com/752028
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539743}
[modify] https://crrev.com/f43dc78128f4977252d8eb3ab2f1d3302f9562cb/ash/message_center/message_center_style.h
[modify] https://crrev.com/f43dc78128f4977252d8eb3ab2f1d3302f9562cb/chrome/app/theme/default_100_percent/common/favicon_bookmarks.png
[modify] https://crrev.com/f43dc78128f4977252d8eb3ab2f1d3302f9562cb/chrome/app/theme/default_100_percent/common/favicon_conflicts.png
[modify] https://crrev.com/f43dc78128f4977252d8eb3ab2f1d3302f9562cb/chrome/app/theme/default_100_percent/common/favicon_downloads.png
[modify] https://crrev.com/f43dc78128f4977252d8eb3ab2f1d3302f9562cb/chrome/app/theme/default_100_percent/common/favicon_extensions.png
[modify] https://crrev.com/f43dc78128f4977252d8eb3ab2f1d3302f9562cb/chrome/app/theme/default_100_percent/common/favicon_print_preview.png
[modify] https://crrev.com/f43dc78128f4977252d8eb3ab2f1d3302f9562cb/chrome/app/theme/default_100_percent/common/favicon_settings.png
[modify] https://crrev.com/f43dc78128f4977252d8eb3ab2f1d3302f9562cb/chrome/app/theme/default_100_percent/legacy/favicon_laptop.png
[modify] https://crrev.com/f43dc78128f4977252d8eb3ab2f1d3302f9562cb/chrome/app/theme/default_100_percent/legacy/favicon_phone.png
[modify] https://crrev.com/f43dc78128f4977252d8eb3ab2f1d3302f9562cb/chrome/app/theme/default_100_percent/legacy/favicon_tablet.png
[modify] https://crrev.com/f43dc78128f4977252d8eb3ab2f1d3302f9562cb/chrome/app/theme/default_200_percent/common/favicon_bookmarks.png
[modify] https://crrev.com/f43dc78128f4977252d8eb3ab2f1d3302f9562cb/chrome/app/theme/default_200_percent/common/favicon_conflicts.png
[modify] https://crrev.com/f43dc78128f4977252d8eb3ab2f1d3302f9562cb/chrome/app/theme/default_200_percent/common/favicon_downloads.png
[modify] https://crrev.com/f43dc78128f4977252d8eb3ab2f1d3302f9562cb/chrome/app/theme/default_200_percent/common/favicon_extensions.png
[modify] https://crrev.com/f43dc78128f4977252d8eb3ab2f1d3302f9562cb/chrome/app/theme/default_200_percent/common/favicon_print_preview.png
[modify] https://crrev.com/f43dc78128f4977252d8eb3ab2f1d3302f9562cb/chrome/app/theme/default_200_percent/common/favicon_settings.png
[modify] https://crrev.com/f43dc78128f4977252d8eb3ab2f1d3302f9562cb/chrome/app/theme/default_200_percent/legacy/favicon_laptop.png
[modify] https://crrev.com/f43dc78128f4977252d8eb3ab2f1d3302f9562cb/chrome/app/theme/default_200_percent/legacy/favicon_phone.png
[modify] https://crrev.com/f43dc78128f4977252d8eb3ab2f1d3302f9562cb/chrome/app/theme/default_200_percent/legacy/favicon_tablet.png
[modify] https://crrev.com/f43dc78128f4977252d8eb3ab2f1d3302f9562cb/chrome/app/vector_icons/profile_switcher_outline.icon
[modify] https://crrev.com/f43dc78128f4977252d8eb3ab2f1d3302f9562cb/chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm
[modify] https://crrev.com/f43dc78128f4977252d8eb3ab2f1d3302f9562cb/chrome/browser/ui/cocoa/toolbar/toolbar_button_cocoa.mm
[modify] https://crrev.com/f43dc78128f4977252d8eb3ab2f1d3302f9562cb/chrome/browser/ui/views/tabs/tab.cc
[modify] https://crrev.com/f43dc78128f4977252d8eb3ab2f1d3302f9562cb/components/resources/default_100_percent/crash/favicon_sad_tab.png
[modify] https://crrev.com/f43dc78128f4977252d8eb3ab2f1d3302f9562cb/components/resources/default_100_percent/favicon_history.png
[modify] https://crrev.com/f43dc78128f4977252d8eb3ab2f1d3302f9562cb/components/resources/default_100_percent/flags_ui/favicon_flags.png
[modify] https://crrev.com/f43dc78128f4977252d8eb3ab2f1d3302f9562cb/components/resources/default_200_percent/crash/favicon_sad_tab.png
[modify] https://crrev.com/f43dc78128f4977252d8eb3ab2f1d3302f9562cb/components/resources/default_200_percent/favicon_history.png
[modify] https://crrev.com/f43dc78128f4977252d8eb3ab2f1d3302f9562cb/components/resources/default_200_percent/flags_ui/favicon_flags.png
[modify] https://crrev.com/f43dc78128f4977252d8eb3ab2f1d3302f9562cb/components/resources/default_300_percent/crash/favicon_sad_tab.png
[modify] https://crrev.com/f43dc78128f4977252d8eb3ab2f1d3302f9562cb/components/resources/default_300_percent/favicon_history.png
[modify] https://crrev.com/f43dc78128f4977252d8eb3ab2f1d3302f9562cb/components/resources/default_300_percent/flags_ui/favicon_flags.png
[modify] https://crrev.com/f43dc78128f4977252d8eb3ab2f1d3302f9562cb/components/resources/sadtab.svg
[modify] https://crrev.com/f43dc78128f4977252d8eb3ab2f1d3302f9562cb/ui/gfx/color_palette.h
[modify] https://crrev.com/f43dc78128f4977252d8eb3ab2f1d3302f9562cb/ui/views/controls/button/image_button_factory.cc

Comment 15 by pbos@chromium.org, Feb 28 2018

Status: Fixed (was: Assigned)
Project Member

Comment 16 by bugdroid1@chromium.org, Mar 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5fbbecce5b98c482cf2fe83c1aacacfb6b91f2e4

commit 5fbbecce5b98c482cf2fe83c1aacacfb6b91f2e4
Author: Peter Boström <pbos@chromium.org>
Date: Wed Mar 14 21:54:36 2018

Revert "Use Material Design colors for UI icons."

This reverts commit f43dc78128f4977252d8eb3ab2f1d3302f9562cb.

Reason for revert: UX has decided against #757575 as it makes a lighter
icon color as a stopgap between current (5A) and GoogleGrey700. GG700 is
closer to 5A colors so trunk will go straight to GG700 as soon as I get
updated favicons with that color sent to me. This revert is intended to
be merged into M66.

Original change's description:
> Use Material Design colors for UI icons.
>
> This changes icons generated with use of SetImageFromVectorIcon or
> DeriveDefaultIconColor to generate #757575 from a black related text
> color. The use of alpha in SetImageFromVectorIcon is changed to result
> in #9E9E9E for disabled icons when used to generate icons for black
> text.
>
> Some of the favicons are changed to have a MD-blue icon as part of
> WebUI branding.
>
> Bug:  chromium:774563 
> Change-Id: I978b1cba4d33a06e834f0ff7d74d3dbc6a305b57
> Reviewed-on: https://chromium-review.googlesource.com/752028
> Commit-Queue: Peter Boström <pbos@chromium.org>
> Reviewed-by: Colin Blundell <blundell@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Evan Stade <estade@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#539743}

TBR=sky@chromium.org,blundell@chromium.org,estade@chromium.org,pbos@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  chromium:774563 , chromium:820229
Change-Id: Ib43faee64803db2cfd9b35dee1ac1818b91ccc45
Reviewed-on: https://chromium-review.googlesource.com/963232
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543213}
[modify] https://crrev.com/5fbbecce5b98c482cf2fe83c1aacacfb6b91f2e4/ash/message_center/message_center_style.h
[modify] https://crrev.com/5fbbecce5b98c482cf2fe83c1aacacfb6b91f2e4/chrome/app/theme/default_100_percent/common/favicon_bookmarks.png
[modify] https://crrev.com/5fbbecce5b98c482cf2fe83c1aacacfb6b91f2e4/chrome/app/theme/default_100_percent/common/favicon_conflicts.png
[modify] https://crrev.com/5fbbecce5b98c482cf2fe83c1aacacfb6b91f2e4/chrome/app/theme/default_100_percent/common/favicon_downloads.png
[modify] https://crrev.com/5fbbecce5b98c482cf2fe83c1aacacfb6b91f2e4/chrome/app/theme/default_100_percent/common/favicon_extensions.png
[modify] https://crrev.com/5fbbecce5b98c482cf2fe83c1aacacfb6b91f2e4/chrome/app/theme/default_100_percent/common/favicon_print_preview.png
[modify] https://crrev.com/5fbbecce5b98c482cf2fe83c1aacacfb6b91f2e4/chrome/app/theme/default_100_percent/common/favicon_settings.png
[modify] https://crrev.com/5fbbecce5b98c482cf2fe83c1aacacfb6b91f2e4/chrome/app/theme/default_100_percent/legacy/favicon_laptop.png
[modify] https://crrev.com/5fbbecce5b98c482cf2fe83c1aacacfb6b91f2e4/chrome/app/theme/default_100_percent/legacy/favicon_phone.png
[modify] https://crrev.com/5fbbecce5b98c482cf2fe83c1aacacfb6b91f2e4/chrome/app/theme/default_100_percent/legacy/favicon_tablet.png
[modify] https://crrev.com/5fbbecce5b98c482cf2fe83c1aacacfb6b91f2e4/chrome/app/theme/default_200_percent/common/favicon_bookmarks.png
[modify] https://crrev.com/5fbbecce5b98c482cf2fe83c1aacacfb6b91f2e4/chrome/app/theme/default_200_percent/common/favicon_conflicts.png
[modify] https://crrev.com/5fbbecce5b98c482cf2fe83c1aacacfb6b91f2e4/chrome/app/theme/default_200_percent/common/favicon_downloads.png
[modify] https://crrev.com/5fbbecce5b98c482cf2fe83c1aacacfb6b91f2e4/chrome/app/theme/default_200_percent/common/favicon_extensions.png
[modify] https://crrev.com/5fbbecce5b98c482cf2fe83c1aacacfb6b91f2e4/chrome/app/theme/default_200_percent/common/favicon_print_preview.png
[modify] https://crrev.com/5fbbecce5b98c482cf2fe83c1aacacfb6b91f2e4/chrome/app/theme/default_200_percent/common/favicon_settings.png
[modify] https://crrev.com/5fbbecce5b98c482cf2fe83c1aacacfb6b91f2e4/chrome/app/theme/default_200_percent/legacy/favicon_laptop.png
[modify] https://crrev.com/5fbbecce5b98c482cf2fe83c1aacacfb6b91f2e4/chrome/app/theme/default_200_percent/legacy/favicon_phone.png
[modify] https://crrev.com/5fbbecce5b98c482cf2fe83c1aacacfb6b91f2e4/chrome/app/theme/default_200_percent/legacy/favicon_tablet.png
[modify] https://crrev.com/5fbbecce5b98c482cf2fe83c1aacacfb6b91f2e4/chrome/app/vector_icons/profile_switcher_outline.icon
[modify] https://crrev.com/5fbbecce5b98c482cf2fe83c1aacacfb6b91f2e4/chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm
[modify] https://crrev.com/5fbbecce5b98c482cf2fe83c1aacacfb6b91f2e4/chrome/browser/ui/cocoa/toolbar/toolbar_button_cocoa.mm
[modify] https://crrev.com/5fbbecce5b98c482cf2fe83c1aacacfb6b91f2e4/chrome/browser/ui/views/tabs/tab.cc
[modify] https://crrev.com/5fbbecce5b98c482cf2fe83c1aacacfb6b91f2e4/components/resources/default_100_percent/crash/favicon_sad_tab.png
[modify] https://crrev.com/5fbbecce5b98c482cf2fe83c1aacacfb6b91f2e4/components/resources/default_100_percent/favicon_history.png
[modify] https://crrev.com/5fbbecce5b98c482cf2fe83c1aacacfb6b91f2e4/components/resources/default_100_percent/flags_ui/favicon_flags.png
[modify] https://crrev.com/5fbbecce5b98c482cf2fe83c1aacacfb6b91f2e4/components/resources/default_200_percent/crash/favicon_sad_tab.png
[modify] https://crrev.com/5fbbecce5b98c482cf2fe83c1aacacfb6b91f2e4/components/resources/default_200_percent/favicon_history.png
[modify] https://crrev.com/5fbbecce5b98c482cf2fe83c1aacacfb6b91f2e4/components/resources/default_200_percent/flags_ui/favicon_flags.png
[modify] https://crrev.com/5fbbecce5b98c482cf2fe83c1aacacfb6b91f2e4/components/resources/default_300_percent/crash/favicon_sad_tab.png
[modify] https://crrev.com/5fbbecce5b98c482cf2fe83c1aacacfb6b91f2e4/components/resources/default_300_percent/favicon_history.png
[modify] https://crrev.com/5fbbecce5b98c482cf2fe83c1aacacfb6b91f2e4/components/resources/default_300_percent/flags_ui/favicon_flags.png
[modify] https://crrev.com/5fbbecce5b98c482cf2fe83c1aacacfb6b91f2e4/components/resources/sadtab.svg
[modify] https://crrev.com/5fbbecce5b98c482cf2fe83c1aacacfb6b91f2e4/ui/gfx/color_palette.h
[modify] https://crrev.com/5fbbecce5b98c482cf2fe83c1aacacfb6b91f2e4/ui/views/controls/button/image_button_factory.cc

Comment 17 by pbos@chromium.org, Mar 14 2018

Status: WontFix (was: Fixed)
This will be superseded by GG700, covered by issue 821996.
Project Member

Comment 18 by bugdroid1@chromium.org, Mar 14 2018

Labels: merge-merged-3359
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/050b9947c93cb4be38d5cf0cc307cd4211557751

commit 050b9947c93cb4be38d5cf0cc307cd4211557751
Author: Peter Boström <pbos@chromium.org>
Date: Wed Mar 14 22:19:13 2018

Revert "Use Material Design colors for UI icons."

This reverts commit f43dc78128f4977252d8eb3ab2f1d3302f9562cb.

Reason for revert: UX has decided against #757575 as it makes a lighter
icon color as a stopgap between current (5A) and GoogleGrey700. GG700 is
closer to 5A colors so trunk will go straight to GG700 as soon as I get
updated favicons with that color sent to me. This revert is intended to
be merged into M66.

Original change's description:
> Use Material Design colors for UI icons.
>
> This changes icons generated with use of SetImageFromVectorIcon or
> DeriveDefaultIconColor to generate #757575 from a black related text
> color. The use of alpha in SetImageFromVectorIcon is changed to result
> in #9E9E9E for disabled icons when used to generate icons for black
> text.
>
> Some of the favicons are changed to have a MD-blue icon as part of
> WebUI branding.
>
> Bug:  chromium:774563 
> Change-Id: I978b1cba4d33a06e834f0ff7d74d3dbc6a305b57
> Reviewed-on: https://chromium-review.googlesource.com/752028
> Commit-Queue: Peter Boström <pbos@chromium.org>
> Reviewed-by: Colin Blundell <blundell@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Evan Stade <estade@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#539743}

TBR=sky@chromium.org,blundell@chromium.org,estade@chromium.org,pbos@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  chromium:774563 , chromium:820229
Change-Id: Ib43faee64803db2cfd9b35dee1ac1818b91ccc45
Reviewed-on: https://chromium-review.googlesource.com/963232
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#543213}(cherry picked from commit 5fbbecce5b98c482cf2fe83c1aacacfb6b91f2e4)
Reviewed-on: https://chromium-review.googlesource.com/963583
Cr-Commit-Position: refs/branch-heads/3359@{#250}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/050b9947c93cb4be38d5cf0cc307cd4211557751/ash/message_center/message_center_style.h
[modify] https://crrev.com/050b9947c93cb4be38d5cf0cc307cd4211557751/chrome/app/theme/default_100_percent/common/favicon_bookmarks.png
[modify] https://crrev.com/050b9947c93cb4be38d5cf0cc307cd4211557751/chrome/app/theme/default_100_percent/common/favicon_conflicts.png
[modify] https://crrev.com/050b9947c93cb4be38d5cf0cc307cd4211557751/chrome/app/theme/default_100_percent/common/favicon_downloads.png
[modify] https://crrev.com/050b9947c93cb4be38d5cf0cc307cd4211557751/chrome/app/theme/default_100_percent/common/favicon_extensions.png
[modify] https://crrev.com/050b9947c93cb4be38d5cf0cc307cd4211557751/chrome/app/theme/default_100_percent/common/favicon_print_preview.png
[modify] https://crrev.com/050b9947c93cb4be38d5cf0cc307cd4211557751/chrome/app/theme/default_100_percent/common/favicon_settings.png
[modify] https://crrev.com/050b9947c93cb4be38d5cf0cc307cd4211557751/chrome/app/theme/default_100_percent/legacy/favicon_laptop.png
[modify] https://crrev.com/050b9947c93cb4be38d5cf0cc307cd4211557751/chrome/app/theme/default_100_percent/legacy/favicon_phone.png
[modify] https://crrev.com/050b9947c93cb4be38d5cf0cc307cd4211557751/chrome/app/theme/default_100_percent/legacy/favicon_tablet.png
[modify] https://crrev.com/050b9947c93cb4be38d5cf0cc307cd4211557751/chrome/app/theme/default_200_percent/common/favicon_bookmarks.png
[modify] https://crrev.com/050b9947c93cb4be38d5cf0cc307cd4211557751/chrome/app/theme/default_200_percent/common/favicon_conflicts.png
[modify] https://crrev.com/050b9947c93cb4be38d5cf0cc307cd4211557751/chrome/app/theme/default_200_percent/common/favicon_downloads.png
[modify] https://crrev.com/050b9947c93cb4be38d5cf0cc307cd4211557751/chrome/app/theme/default_200_percent/common/favicon_extensions.png
[modify] https://crrev.com/050b9947c93cb4be38d5cf0cc307cd4211557751/chrome/app/theme/default_200_percent/common/favicon_print_preview.png
[modify] https://crrev.com/050b9947c93cb4be38d5cf0cc307cd4211557751/chrome/app/theme/default_200_percent/common/favicon_settings.png
[modify] https://crrev.com/050b9947c93cb4be38d5cf0cc307cd4211557751/chrome/app/theme/default_200_percent/legacy/favicon_laptop.png
[modify] https://crrev.com/050b9947c93cb4be38d5cf0cc307cd4211557751/chrome/app/theme/default_200_percent/legacy/favicon_phone.png
[modify] https://crrev.com/050b9947c93cb4be38d5cf0cc307cd4211557751/chrome/app/theme/default_200_percent/legacy/favicon_tablet.png
[modify] https://crrev.com/050b9947c93cb4be38d5cf0cc307cd4211557751/chrome/app/vector_icons/profile_switcher_outline.icon
[modify] https://crrev.com/050b9947c93cb4be38d5cf0cc307cd4211557751/chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm
[modify] https://crrev.com/050b9947c93cb4be38d5cf0cc307cd4211557751/chrome/browser/ui/cocoa/toolbar/toolbar_button_cocoa.mm
[modify] https://crrev.com/050b9947c93cb4be38d5cf0cc307cd4211557751/chrome/browser/ui/views/tabs/tab.cc
[modify] https://crrev.com/050b9947c93cb4be38d5cf0cc307cd4211557751/components/resources/default_100_percent/crash/favicon_sad_tab.png
[modify] https://crrev.com/050b9947c93cb4be38d5cf0cc307cd4211557751/components/resources/default_100_percent/favicon_history.png
[modify] https://crrev.com/050b9947c93cb4be38d5cf0cc307cd4211557751/components/resources/default_100_percent/flags_ui/favicon_flags.png
[modify] https://crrev.com/050b9947c93cb4be38d5cf0cc307cd4211557751/components/resources/default_200_percent/crash/favicon_sad_tab.png
[modify] https://crrev.com/050b9947c93cb4be38d5cf0cc307cd4211557751/components/resources/default_200_percent/favicon_history.png
[modify] https://crrev.com/050b9947c93cb4be38d5cf0cc307cd4211557751/components/resources/default_200_percent/flags_ui/favicon_flags.png
[modify] https://crrev.com/050b9947c93cb4be38d5cf0cc307cd4211557751/components/resources/default_300_percent/crash/favicon_sad_tab.png
[modify] https://crrev.com/050b9947c93cb4be38d5cf0cc307cd4211557751/components/resources/default_300_percent/favicon_history.png
[modify] https://crrev.com/050b9947c93cb4be38d5cf0cc307cd4211557751/components/resources/default_300_percent/flags_ui/favicon_flags.png
[modify] https://crrev.com/050b9947c93cb4be38d5cf0cc307cd4211557751/components/resources/sadtab.svg
[modify] https://crrev.com/050b9947c93cb4be38d5cf0cc307cd4211557751/ui/gfx/color_palette.h
[modify] https://crrev.com/050b9947c93cb4be38d5cf0cc307cd4211557751/ui/views/controls/button/image_button_factory.cc

Sign in to add a comment