[Findit] Flake Analyzer - Assertion error: Generator waterfall.flake.recursive_flake_try_job_pipeline.NextCommitPositionPipeline |
||
Issue description
_GetNextCommitPositionAndRemainingSuspects(
...
if remaining_suspected_commit_positions:
# Try the suggested commit position first.
next_suspected_commit_position = remaining_suspected_commit_positions[0]
previously_run_data_point = (
analysis.FindMatchingDataPointWithCommitPosition(
previously_run_commit_position))
assert previously_run_data_point
assertion failed
,
Oct 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/2755618a0dcf0adf25c3ba357b76eadc89c5b66a commit 2755618a0dcf0adf25c3ba357b76eadc89c5b66a Author: Jeffrey Li <lijeffrey@chromium.org> Date: Fri Oct 20 20:19:19 2017 [Findit] Flake Analyzer - Reuse existing try job data point Multiple analyses may eventually request a try job to be run at the same configuration that another analysis has already performed. In this case, the data point should be reused. This CL solves two issues: 1. Try jobs with existing data points are not being added to the any of the subsequent analyses, though the first analysis that requests the try job is fine. 2. In case heuristic results are available, Flake Analyzer asserts that the "previous" data point (one before the suspect) is in the data points list. Due to issue 1, that data point was already computed but not properly added to the list, causing the assertion to fail when checking "previous". Bug: 774562 Change-Id: I8aacf4c3baa8d99db0e8e2cb2bb2c2591497c5b2 Reviewed-on: https://chromium-review.googlesource.com/726888 Commit-Queue: Jeffrey Li <lijeffrey@chromium.org> Reviewed-by: Brandon Wylie <wylieb@chromium.org> [modify] https://crrev.com/2755618a0dcf0adf25c3ba357b76eadc89c5b66a/appengine/findit/waterfall/flake/test/process_flake_try_job_result_pipeline_test.py [modify] https://crrev.com/2755618a0dcf0adf25c3ba357b76eadc89c5b66a/appengine/findit/waterfall/flake/process_flake_try_job_result_pipeline.py [modify] https://crrev.com/2755618a0dcf0adf25c3ba357b76eadc89c5b66a/appengine/findit/model/flake/master_flake_analysis.py [modify] https://crrev.com/2755618a0dcf0adf25c3ba357b76eadc89c5b66a/appengine/findit/waterfall/flake/recursive_flake_try_job_pipeline.py [add] https://crrev.com/2755618a0dcf0adf25c3ba357b76eadc89c5b66a/appengine/findit/services/flake_failure/flake_try_job_service.py [add] https://crrev.com/2755618a0dcf0adf25c3ba357b76eadc89c5b66a/appengine/findit/services/flake_failure/test/flake_try_job_service_test.py [modify] https://crrev.com/2755618a0dcf0adf25c3ba357b76eadc89c5b66a/appengine/findit/waterfall/flake/test/recursive_flake_try_job_pipeline_test.py
,
Oct 25 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by lijeffrey@chromium.org
, Oct 13 2017