New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 774555 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

3.7% regression in memory.top_10_mobile at 508378:508492

Project Member Reported by primiano@chromium.org, Oct 13 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Oct 13 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=774555

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=d6c829e5a511b57c2f26d439aae35ac4eacd976932e8f08600bf503644f1cc4d


Bot(s) for this bug's original alert(s):

android-webview-nexus6
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Oct 13 2017

Cc: sunxd@chromium.org
Owner: sunxd@chromium.org
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author sunxd@chromium.org ===

Hi sunxd@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : sunxd
  Commit : 48493dc45de06867eec97e7944f56d511e3c4578
  Date   : Thu Oct 12 20:25:14 2017
  Subject: cc: make solid color picture layer tiling respect device scale factor

Bisect Details
  Configuration: android_webview_nexus6_aosp_perf_bisect
  Benchmark    : memory.top_10_mobile
  Metric       : memory:webview:all_processes:reported_by_os:system_memory:native_heap:proportional_resident_size_avg/foreground/http_m_youtube_com_results_q_science
  Change       : 1.20% | 27991298.2222 -> 28326260.0

Revision             Result                  N
chromium@508377      27991298 +- 525924      9       good
chromium@508435      27951476 +- 575718      6       good
chromium@508439      28131700 +- 320314      9       good
chromium@508441      28112585 +- 703702      9       good
chromium@508442      28422223 +- 655909      14      bad       <--
chromium@508443      28456649 +- 519393      9       bad
chromium@508450      28513311 +- 400515      6       bad
chromium@508464      28366310 +- 536897      9       bad
chromium@508492      28326260 +- 343222      6       bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=http.m.youtube.com.results.q.science memory.top_10_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8965831120338583376


For feedback, file a bug with component Speed>Bisection
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Oct 17 2017

Cc: chiniforooshan@chromium.org
 Issue 775235  has been merged into this issue.
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Oct 17 2017

Cc: hubbe@chromium.org
 Issue 775287  has been merged into this issue.
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Oct 17 2017

 Issue 775377  has been merged into this issue.
Project Member

Comment 7 by 42576172...@developer.gserviceaccount.com, Oct 19 2017

 Issue 776487  has been merged into this issue.

Comment 8 by sunxd@chromium.org, Oct 19 2017

I assume the memory regression is due to two facts:

1) We didn't scale solid color picture layers at all even if the device_scale_factor * page_scale_factor is not 1. This is a bug and we can ignore memory regression brought by the fix. Since we are painting a larger area.

2) The previous fixing patch failed to deal with occlusion correctly, I have a WIP patch that fixes that issue, and we can wait and see if the regression can be fixed as well.
Project Member

Comment 9 by 42576172...@developer.gserviceaccount.com, Oct 21 2017

Issue 776784 has been merged into this issue.
Project Member

Comment 10 by 42576172...@developer.gserviceaccount.com, Oct 21 2017

Issue 776785 has been merged into this issue.
Project Member

Comment 11 by 42576172...@developer.gserviceaccount.com, Oct 21 2017

Cc: pmeenan@chromium.org
 Issue 776742  has been merged into this issue.
Project Member

Comment 12 by 42576172...@developer.gserviceaccount.com, Oct 23 2017

 Issue 776749  has been merged into this issue.
Project Member

Comment 13 by 42576172...@developer.gserviceaccount.com, Oct 24 2017

 Issue 776743  has been merged into this issue.
Project Member

Comment 14 by 42576172...@developer.gserviceaccount.com, Oct 24 2017

 Issue 776748  has been merged into this issue.
sunxd: any update on the WIP patch from #8?
The patch mentioned in comment 8 was landed on Oct 25: https://chromium-review.googlesource.com/c/chromium/src/+/738352.

It looks like the bug stops reproducing after that date. I would suggest we can mark it as fixed?

Comment 17 by sunxd@chromium.org, Jan 16 2018

Status: Fixed (was: Assigned)

Sign in to add a comment