New issue
Advanced search Search tips

Issue 774552 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1.4%-1.5% regression in memory.top_10_mobile at 508132:508191

Project Member Reported by primiano@chromium.org, Oct 13 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Oct 13 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=774552

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=e30dcec17cbab7b32ef7dfff0964685806f6fddad71820694abf07938849878c


Bot(s) for this bug's original alert(s):

android-webview-nexus5X
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Oct 13 2017

Cc: japhet@chromium.org
Owner: japhet@chromium.org
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author japhet@chromium.org ===

Hi japhet@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Nate Chapin
  Commit : 591f8b71b99ba4a3826157e5bcd1eea7ca2c6d40
  Date   : Wed Oct 11 23:08:37 2017
  Subject: LayoutImage shouldn't need to know about an image's revalidation state

Bisect Details
  Configuration: android_webview_arm64_aosp_perf_bisect
  Benchmark    : memory.top_10_mobile
  Metric       : memory:webview:all_processes:reported_by_os:system_memory:native_heap:proportional_resident_size_avg/foreground/http_en_m_wikipedia_org_wiki_Science
  Change       : 1.13% | 48776756.4444 -> 49326075.5556

Revision             Result                   N
chromium@508131      48776756 +- 447664       9       good
chromium@508146      48957208 +- 1004460      14      good
chromium@508153      49042200 +- 623001       14      good
chromium@508157      49059901 +- 919015       14      good
chromium@508158      49732717 +- 531500       6       bad       <--
chromium@508159      49717357 +- 498160       6       bad
chromium@508161      49410767 +- 1142857      14      bad
chromium@508191      49326076 +- 865702       9       bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=http.en.m.wikipedia.org.wiki.Science memory.top_10_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8965831165096814992


For feedback, file a bug with component Speed>Bisection
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Oct 13 2017


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Nate Chapin
  Commit : 591f8b71b99ba4a3826157e5bcd1eea7ca2c6d40
  Date   : Wed Oct 11 23:08:37 2017
  Subject: LayoutImage shouldn't need to know about an image's revalidation state

Bisect Details
  Configuration: android_webview_arm64_aosp_perf_bisect
  Benchmark    : memory.top_10_mobile
  Metric       : memory:webview:all_processes:reported_by_os:system_memory:native_heap:proportional_resident_size_avg/foreground/http_en_m_wikipedia_org_wiki_Science
  Change       : 1.70% | 48865340.5714 -> 49619224.0

Revision             Result                   N
chromium@508131      48865341 +- 758613       14      good
chromium@508146      48990049 +- 706909       14      good
chromium@508153      48970227 +- 523332       14      good
chromium@508157      49042541 +- 658873       21      good
chromium@508158      49565123 +- 424064       6       bad       <--
chromium@508159      49358616 +- 724662       9       bad
chromium@508161      49358323 +- 1114870      14      bad
chromium@508191      49619224 +- 388866       6       bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=http.en.m.wikipedia.org.wiki.Science memory.top_10_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8965813879833480304


For feedback, file a bug with component Speed>Bisection
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Oct 15 2017

Issue 774547 has been merged into this issue.

Comment 7 by japhet@chromium.org, Oct 18 2017

Status: Fixed (was: Assigned)
Reverted the accused patch in https://chromium.googlesource.com/chromium/src/+/a99bfdf79831dea44584325e6669977d6ba8ddd6, graphs on https://chromeperf.appspot.com/group_report?bug_id=774552 seem to have recovered.

Sign in to add a comment