New issue
Advanced search Search tips

Issue 774526 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove WebAudio.BiquadFilter.Q histograms

Project Member Reported by rtoy@chromium.org, Oct 13 2017

Issue description

These histograms were added to keep track of the Q values for the lowpass and highpass filters when the implementation of the lowpass and highpass filters changed.

These were added in https://codereview.chromium.org/1934683002, over a year ago, and aren't needed anymore.

Remove them.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21f460686bb19e1f61eb8d38739aa5a9a9d64559

commit 21f460686bb19e1f61eb8d38739aa5a9a9d64559
Author: Raymond Toy <rtoy@chromium.org>
Date: Mon Oct 16 22:42:04 2017

Remove BiquadFilter.Q histograms

The definition of the Q parameter for lowpass and highpass filters
were changed a while ago in the WebAudio specification.  These
were added to determine how much impact this change would have because
the change is aubible.

It's been over a year, and no bugs have been filed on this, and the
histograms show that the default values are, by far, the most common
values.  Hence, we can remove these histograms.

Bug:  774526 
Test: none
Change-Id: I17ad180a40964bd4d81988492d43e522a47f2f2f
Reviewed-on: https://chromium-review.googlesource.com/718839
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509187}
[modify] https://crrev.com/21f460686bb19e1f61eb8d38739aa5a9a9d64559/third_party/WebKit/Source/modules/webaudio/AudioParam.cpp
[modify] https://crrev.com/21f460686bb19e1f61eb8d38739aa5a9a9d64559/third_party/WebKit/Source/modules/webaudio/AudioParam.h
[modify] https://crrev.com/21f460686bb19e1f61eb8d38739aa5a9a9d64559/third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.cpp
[modify] https://crrev.com/21f460686bb19e1f61eb8d38739aa5a9a9d64559/tools/metrics/histograms/histograms.xml

Comment 2 by rtoy@chromium.org, Oct 18 2017

Status: Fixed (was: Started)

Sign in to add a comment