New issue
Advanced search Search tips

Issue 774524 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug

Blocking:
issue 714610



Sign in to add a comment

Password backend methods called in infinite loop

Project Member Reported by cfroussios@chromium.org, Oct 13 2017

Issue description

Chrome Version: Version 63.0.3239.0 (Developer Build) (64-bit)
OS: Linux

What steps will reproduce the problem?
(1) Place probes in NativeBackendLibsecret calls (e.g. RawAddLogin, RemoveLogin, AddUpdateLoginSearch)
(2) Launch Chrome

On my machine I observe that these methods are called every second, as if in a loop.

Example stacktrace
#0 0x7f122d740077 base::debug::StackTrace::StackTrace()
#1 0x561ca4d040d8 NativeBackendLibsecret::RawAddLogin()
#2 0x561ca4d0391f NativeBackendLibsecret::AddLogin()
#3 0x561ca4d0eee4 PasswordStoreX::MigrateLogins()
#4 0x561ca4d0e219 PasswordStoreX::CheckMigration()
#5 0x561ca4d0ecaf PasswordStoreX::FillAutofillableLogins()
#6 0x561ca5575ec6 password_manager::PasswordStore::GetAutofillableLoginsImpl()
#7 0x561ca557717c password_manager::PasswordStore::InitOnBackgroundSequence()
#8 0x561ca557c54b password_manager::PasswordStoreDefault::InitOnBackgroundSequence()
#9 0x7f122d740b27 base::debug::TaskAnnotator::RunTask()
#10 0x7f122d7af6fb base::internal::TaskTracker::RunOrSkipTask()
#11 0x7f122d7afc8b base::internal::TaskTrackerPosix::RunOrSkipTask()
#12 0x7f122d7af268 base::internal::TaskTracker::RunNextTask()
#13 0x7f122d7aa4fe base::internal::SchedulerWorker::Thread::ThreadMain()
#14 0x7f122d7ba953 base::(anonymous namespace)::ThreadFunc()
#15 0x7f122d842184 start_thread
#16 0x7f122272cffd clone



 
Can you add print |this| to PasswordStoreDefault::InitOnBackgroundSequence as well as to PasswordStoreDefault constructor/destructor so that we know if it's the same object. If it's a different object every time, it would be useful to output the stack trace in PasswordStore::Init.
Owner: cfroussios@chromium.org
Reassigning until the additional info is available.
Owner: vasi...@chromium.org
They are called once each, on the same object.

I also verified that the above behaviour only happens if there is stuff to migrate from the profile dir into Keyring.
Cc: cfroussios@chromium.org
I can't reproduce it. Do you still have it on the clean ToT? Then I need to debug on your machine.

Comment 5 by vabr@chromium.org, Oct 23 2017

Status: Assigned (was: Unconfirmed)
Fixing status, given that this has an owner and investigation is going on.
Blocking: 714610
Status: WontFix (was: Assigned)
PasswordStoreX::MigrateLogins is migrating a 1000 of logins and doing it slow. For every password we search, delete the existing one and add the new one.
We should migrate away from Keyring.

Sign in to add a comment