Save password dialog: inconsistent usage of password masking characters |
|||||||
Issue descriptionChrome Version: 63.0.3239.0 OS: Mac What is the expected result? Masked passwords should always be displayed with bullet characters. What happens instead? One password found: bullet points used. Multiple passwords found: asterisk characters used. See attachment. Could you check whether this issue also exists on Windows, Linux or CrOS? Thanks!
,
Oct 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1009ba6f6347fe74b77a1bc0cbec33b36e19cb6b commit 1009ba6f6347fe74b77a1bc0cbec33b36e19cb6b Author: Vasilii Sukhanov <vasilii@chromium.org> Date: Tue Oct 17 11:48:15 2017 Use bullet points instead of asterisk in the save password bubble. Bug: 774516 Change-Id: I17344d16d835a9db9daf1c87824ea9e40ec38baa Reviewed-on: https://chromium-review.googlesource.com/721544 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#509366} [modify] https://crrev.com/1009ba6f6347fe74b77a1bc0cbec33b36e19cb6b/chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller.mm [modify] https://crrev.com/1009ba6f6347fe74b77a1bc0cbec33b36e19cb6b/chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller_unittest.mm [modify] https://crrev.com/1009ba6f6347fe74b77a1bc0cbec33b36e19cb6b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
,
Oct 17 2017
Max, do you want me to merge it back?
,
Oct 17 2017
Just noticed that this applies to Windows, too. >> Max, do you want me to merge it back? I think fixing this for the next release would be acceptable.
,
Oct 17 2017
I fixed all the platforms.
,
Oct 18 2017
I want to merge r509366. It's a small UI fix.
,
Oct 18 2017
This merger is also needed for critical UI fix ( Issue 771878 )
,
Oct 19 2017
Your change meets the bar and is auto-approved for M63. Please go ahead and merge the CL to branch 3239 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bb6e290e408f8b568d3ad53259505108e6c2ffc9 commit bb6e290e408f8b568d3ad53259505108e6c2ffc9 Author: Vasilii Sukhanov <vasilii@chromium.org> Date: Thu Oct 19 08:50:23 2017 Use bullet points instead of asterisk in the save password bubble. TBR=vasilii@chromium.org (cherry picked from commit 1009ba6f6347fe74b77a1bc0cbec33b36e19cb6b) Bug: 774516 Change-Id: I17344d16d835a9db9daf1c87824ea9e40ec38baa Reviewed-on: https://chromium-review.googlesource.com/721544 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by: Tatiana Gornak <melandory@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#509366} Reviewed-on: https://chromium-review.googlesource.com/727932 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#64} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/bb6e290e408f8b568d3ad53259505108e6c2ffc9/chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller.mm [modify] https://crrev.com/bb6e290e408f8b568d3ad53259505108e6c2ffc9/chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller_unittest.mm [modify] https://crrev.com/bb6e290e408f8b568d3ad53259505108e6c2ffc9/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
,
Oct 19 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by kolos@chromium.org
, Oct 16 2017