CL[1] will enable arc video encode and decode accelerator service for mus. We need enable those services for mash too. [1]https://chromium-review.googlesource.com/c/chromium/src/+/709734
When GPU is moved to Viz, we will expose ARC video ecode and decoder accelerator interfaces in viz service.
The code in services/ui/gpu is already in use from chrome-gpu and mus-gpu. So this work should not be blocked on that relocation.
We need a common place for registering GpuArcVideoEncodeAccelerator and GpuArcVideoDecodeAccelerator for both mus and mash. For exmaple: Maybe a new function CreateVizService at [1]. I though we will add a similar function at [1], when GPU is running in a separate Viz process for mus and mash. [1] https://cs.chromium.org/chromium/src/chrome/utility/mash_service_factory.cc?type=cs&sq=package:chromium&l=39
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/49007068353a20be415e81df5346f2a00b3c4439 commit 49007068353a20be415e81df5346f2a00b3c4439 Author: Peng Huang <penghuang@chromium.org> Date: Wed Nov 08 11:59:16 2017 compoentes/arc: remove unnecessary files from //components/arc:arc We want to host GpuArcVideoAccelerators in viz process for mus and mash. But we don't want to depend on //components/arc:arc since it will pull in a lot of unnecessary dependencies. With CL, viz just need depend on //components/arc:arc_bindings. Bug: 774514 Change-Id: I5340532324c13985b0d41944892c7e72bde286a3 Reviewed-on: https://chromium-review.googlesource.com/757080 Reviewed-by: Yusuke Sato <yusukes@chromium.org> Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#514803} [modify] https://crrev.com/49007068353a20be415e81df5346f2a00b3c4439/components/arc/BUILD.gn [modify] https://crrev.com/49007068353a20be415e81df5346f2a00b3c4439/components/arc/common/bluetooth.typemap [modify] https://crrev.com/49007068353a20be415e81df5346f2a00b3c4439/components/arc/common/file_system.typemap
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b82565b01f30e14e0532cfba625a3930d6d05ac9 commit b82565b01f30e14e0532cfba625a3930d6d05ac9 Author: Peng Huang <penghuang@chromium.org> Date: Fri Nov 10 19:54:01 2017 Move //chrome/gpu/*{arc,protected_buffer}* to //components/arc/video_accelerator Mus chrome crashes when playing video in ARC++ Youtube. It is because the ARC video accelerators don't exist in mus world. This CL moves ARC video accelerators to //components/arc/video_accelerator folder so it can be used by both viz and chrome/gpu. Bug: 774514 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Idd4525c05f6a8b8bd3f19f2cd690cc179e1d4736 Reviewed-on: https://chromium-review.googlesource.com/756872 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Pawel Osciak <posciak@chromium.org> Reviewed-by: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#515646} [modify] https://crrev.com/b82565b01f30e14e0532cfba625a3930d6d05ac9/chrome/gpu/BUILD.gn [modify] https://crrev.com/b82565b01f30e14e0532cfba625a3930d6d05ac9/chrome/gpu/DEPS [modify] https://crrev.com/b82565b01f30e14e0532cfba625a3930d6d05ac9/chrome/gpu/chrome_content_gpu_client.cc [modify] https://crrev.com/b82565b01f30e14e0532cfba625a3930d6d05ac9/chrome/gpu/chrome_content_gpu_client.h [add] https://crrev.com/b82565b01f30e14e0532cfba625a3930d6d05ac9/components/arc/common/DEPS [rename] https://crrev.com/b82565b01f30e14e0532cfba625a3930d6d05ac9/components/arc/common/video_accelerator_struct_traits.cc [rename] https://crrev.com/b82565b01f30e14e0532cfba625a3930d6d05ac9/components/arc/common/video_accelerator_struct_traits.h [modify] https://crrev.com/b82565b01f30e14e0532cfba625a3930d6d05ac9/components/arc/common/video_common.typemap [modify] https://crrev.com/b82565b01f30e14e0532cfba625a3930d6d05ac9/components/arc/common/video_encode_accelerator.typemap [rename] https://crrev.com/b82565b01f30e14e0532cfba625a3930d6d05ac9/components/arc/common/video_encode_accelerator_struct_traits.cc [rename] https://crrev.com/b82565b01f30e14e0532cfba625a3930d6d05ac9/components/arc/common/video_encode_accelerator_struct_traits.h [add] https://crrev.com/b82565b01f30e14e0532cfba625a3930d6d05ac9/components/arc/video_accelerator/BUILD.gn [modify] https://crrev.com/b82565b01f30e14e0532cfba625a3930d6d05ac9/components/arc/video_accelerator/DEPS [modify] https://crrev.com/b82565b01f30e14e0532cfba625a3930d6d05ac9/components/arc/video_accelerator/OWNERS [rename] https://crrev.com/b82565b01f30e14e0532cfba625a3930d6d05ac9/components/arc/video_accelerator/arc_video_decode_accelerator.h [rename] https://crrev.com/b82565b01f30e14e0532cfba625a3930d6d05ac9/components/arc/video_accelerator/chrome_arc_video_decode_accelerator.cc [rename] https://crrev.com/b82565b01f30e14e0532cfba625a3930d6d05ac9/components/arc/video_accelerator/chrome_arc_video_decode_accelerator.h [rename] https://crrev.com/b82565b01f30e14e0532cfba625a3930d6d05ac9/components/arc/video_accelerator/gpu_arc_video_decode_accelerator.cc [rename] https://crrev.com/b82565b01f30e14e0532cfba625a3930d6d05ac9/components/arc/video_accelerator/gpu_arc_video_decode_accelerator.h [rename] https://crrev.com/b82565b01f30e14e0532cfba625a3930d6d05ac9/components/arc/video_accelerator/gpu_arc_video_encode_accelerator.cc [rename] https://crrev.com/b82565b01f30e14e0532cfba625a3930d6d05ac9/components/arc/video_accelerator/gpu_arc_video_encode_accelerator.h [rename] https://crrev.com/b82565b01f30e14e0532cfba625a3930d6d05ac9/components/arc/video_accelerator/protected_buffer_manager.cc [rename] https://crrev.com/b82565b01f30e14e0532cfba625a3930d6d05ac9/components/arc/video_accelerator/protected_buffer_manager.h [rename] https://crrev.com/b82565b01f30e14e0532cfba625a3930d6d05ac9/components/arc/video_accelerator/protected_buffer_manager_proxy.cc [rename] https://crrev.com/b82565b01f30e14e0532cfba625a3930d6d05ac9/components/arc/video_accelerator/protected_buffer_manager_proxy.h [delete] https://crrev.com/31974d24b5de701ff9c290b32e4dd543abec8146/components/arc/video_accelerator/video_accelerator.h [add] https://crrev.com/b82565b01f30e14e0532cfba625a3930d6d05ac9/components/arc/video_accelerator/video_frame_plane.h [modify] https://crrev.com/b82565b01f30e14e0532cfba625a3930d6d05ac9/media/gpu/BUILD.gn
This bug has an owner, thus, it's been triaged. Changing status to "assigned".
Jun mentions YouTube video doesn't work in YouTube apps, possibly because of this. Passing to Jun for further investigation.
Turns out I was wrong, no problems on YouTube video anymore after re-imaging the device. Sorry for that. Re-assign back to the original owner.
Peng, is there anything that needs to be done here? I'm retargetting to multi-process as I don't think anything is needed for single-process. If I'm wrong Peng, please update.
I think we did most of work. I just never test it with mash. Mark it as fixed for now.
Comment 1 by penghuang@chromium.org
, Oct 13 2017