Extensions.FunctionCalls Is Overflowing |
|||||
Issue descriptionThe Extensions.FunctionCalls sparse histogram is being incremented so frequently that it sometimes overflows the 31-bit sample count and rolls negative. Desktop does uploads about every 30 minutes (and resets the counters) so whatever extension these are, it's happening on the order of 1M times per second on some occasions. https://uma.googleplex.com/p/chrome/histograms/?endDate=20171011&dayCount=1&histograms=Extensions.FunctionCalls%2CUMA.NegativeSamples.Histogram&fixupData=true&showMax=true&filters=isofficial%2Ceq%2CTrue&implicitFilters=isofficial Given that this is a "slow" sparse histogram, which involves acquiring a lock, there may be significant overhead here, hence the P2.
,
Oct 13 2017
Wow. Talked with bcwhite about this a bit. Notes: - This means that a specific value for the histogram is being recorded > 2^31 times in a sampling period. In this case, that means a specific function. - Sampling periods are about 30 minutes. They can be delayed, but not too long. And, even in an extremely broken case (uploading once a month!), this is still executing 828 calls per second! This is definitely relevant to our discussion about "sane limits" from the other day. bcwhite@ is landing a fix that will help us tell how prolific this is, but whatever the answer, it's something we should address.
,
Feb 7 2018
Don't remember what the fix was... I see only 3 instances of an overflow in the last 28 days across all channels. https://uma.googleplex.com/p/chrome/histograms/?endDate=latest&dayCount=28&histograms=UMA.NegativeSamples.Histogram&fixupData=true&showMax=true&filters=isofficial%2Ceq%2CTrue&implicitFilters=isofficial
,
Feb 8 2018
,
Jun 29 2018
I'm not seeing this any longer.
,
Jun 29 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bcwh...@chromium.org
, Oct 13 2017