Save password dialog: labels should be left-aligned in Harmony UI |
|||||||||
Issue descriptionChrome Version: 63.0.3239.0 OS: Mac What is the expected result? Labels should be left-aligned (see Bookmark dialog). What happens instead? Labels are right-aligned. Could you check whether this issue also exists on Windows, Linux or CrOS? Thanks!
,
Oct 13 2017
can we postpone it till the release when Harmony is enabled?parsing
,
Oct 13 2017
Sounds reasonable to me. Do you know the release target for Harmony?
,
Oct 16 2017
I think Harmony is targeting M65, setting label accordingly.
,
Oct 16 2017
,
Oct 16 2017
,
Oct 16 2017
,
Oct 16 2017
,
Oct 19 2017
,
Oct 19 2017
Made a quick investigation. Our case a bit more tricky than bookmarks. Bookmarks use the same column set for both rows (name and folder). We have to use different column sets for username and password. Then, we have equalize the width of username and password label. Then, horizontal alignment of column wouldn't align the label properly. We should use Label::SetHorizontalAlignment to solve this issue.
,
Oct 19
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 22
Not having a Mac machine available right now for re-testing. kolos@, vasilii@ -- is this still a valid issue? (If not, please close it.) |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by kolos@chromium.org
, Oct 13 2017