Save password dialog: username text field too long (Mac) |
||||||||
Issue descriptionChrome Version: 63.0.3239.0 OS: Mac What is the expected result? Username field should be aligned with buttons (see Bookmark dialog). What happens instead? Username field is too long. Could you check whether this issue also exists on Windows, Linux and CrOS? Thanks!
,
Oct 16 2017
,
Oct 17 2017
,
Nov 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1df038df6e19e70fd11342f9d5a4d9efbea098fc commit 1df038df6e19e70fd11342f9d5a4d9efbea098fc Author: Vasilii Sukhanov <vasilii@chromium.org> Date: Fri Nov 03 09:03:14 2017 Align elements in the save password dialog. The username field is now align with the pop-up button for the password. The save button is right-aligned with the username field. Bug: 774505 , 780825 Change-Id: Iae200387cb25ddbc5a4b9b3d17dfb093b9bf5cfb Reviewed-on: https://chromium-review.googlesource.com/751742 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#513727} [modify] https://crrev.com/1df038df6e19e70fd11342f9d5a4d9efbea098fc/chrome/browser/ui/cocoa/passwords/pending_password_view_controller.mm [modify] https://crrev.com/1df038df6e19e70fd11342f9d5a4d9efbea098fc/chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller.mm
,
Nov 6 2017
Verified this issue on Mac 10.12.6 with chrome #64.0.3260.0 and observed fix is working as expected.Hence adding TE-Verified labels. Attaching the screen-cast for reference.
,
Nov 6 2017
,
Nov 6 2017
This bug requires manual review: M63 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 6 2017
Approving merge for r513727 to M63 branch 3239 based on comments #6 and #7. Please merge ASAP. Thank you.
,
Nov 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d0aae0ed5a278741bbb0385893938114bff40ee8 commit d0aae0ed5a278741bbb0385893938114bff40ee8 Author: Vasilii Sukhanov <vasilii@chromium.org> Date: Mon Nov 06 17:15:04 2017 Align elements in the save password dialog. The username field is now align with the pop-up button for the password. The save button is right-aligned with the username field. TBR=vasilii@chromium.org (cherry picked from commit 1df038df6e19e70fd11342f9d5a4d9efbea098fc) Bug: 774505 , 780825 Change-Id: Iae200387cb25ddbc5a4b9b3d17dfb093b9bf5cfb Reviewed-on: https://chromium-review.googlesource.com/751742 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#513727} Reviewed-on: https://chromium-review.googlesource.com/754934 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#386} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/d0aae0ed5a278741bbb0385893938114bff40ee8/chrome/browser/ui/cocoa/passwords/pending_password_view_controller.mm [modify] https://crrev.com/d0aae0ed5a278741bbb0385893938114bff40ee8/chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller.mm
,
Nov 6 2017
,
Nov 7 2017
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by kolos@chromium.org
, Oct 13 2017Owner: vasi...@chromium.org
Status: Assigned (was: Untriaged)