New issue
Advanced search Search tips

Issue 774503 link

Starred by 1 user
Status: Fixed
Owner:
rtoy@chromium.org
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Typo in printing out name of ConstantSourceNode AudioParam

Project Member Reported by rtoy@chromium.org, Oct 13 2017 
AudioParamHandler::GetParamName thinks the only AudioParam is called
sourceValue.  It's really really named offset.  Fix this so that
messages are correct.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65c9d9f06fda90794352e4c9ea1c0f10aef80b94

commit 65c9d9f06fda90794352e4c9ea1c0f10aef80b94
Author: Raymond Toy <rtoy@chromium.org>
Date: Fri Oct 13 19:14:22 2017

ConstantSource AudioParam is named offset not value

Rename the enum value to say offset instead of value to match tha
actual name of the AudioParam, and also correct parameter name used in
messages.

Bug:  774503 
Test: None
Change-Id: I0fa026e9d9c3edf61f6eb8ed90c1e75b438c92d5
Reviewed-on: https://chromium-review.googlesource.com/718987
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508774}
[modify] https://crrev.com/65c9d9f06fda90794352e4c9ea1c0f10aef80b94/third_party/WebKit/Source/modules/webaudio/AudioParam.cpp
[modify] https://crrev.com/65c9d9f06fda90794352e4c9ea1c0f10aef80b94/third_party/WebKit/Source/modules/webaudio/AudioParam.h
[modify] https://crrev.com/65c9d9f06fda90794352e4c9ea1c0f10aef80b94/third_party/WebKit/Source/modules/webaudio/ConstantSourceNode.cpp

Comment 2 by rtoy@chromium.org, Oct 18 2017

Status: Fixed (was: Started)
►

Sign in to add a comment