Cc: js...@chromium.org Status: Started (was: Fixed) Summary: Roll harfbuzz to 1.6.1 (was: Roll harfbuzz to 1.6)
1.6 roll was not done when this bug was marked as fixed.
Now, Dominik is going directly to 1.6.1.
1.6.1 is also necessary for ICU 60 update. ( bug 766816 ).
I'm going to let it rest for a couple of days, and if nothing comes up, call it 1.7.0 on Monday.
One problem we have now is that master doesn't get tested until after a release, when Firefox and then Chrome roll forward.
We could write a roll script that uploads a test roll commit to chromium-review.googlesource.com for a candidate HB revision and triggers all the test bots to get a first feel whether everything compiles and layout tests look somewhat okay. Or do full Chrome builds with layout tests runs on travis? Maybe there are existing recipes for that.
Full Chrome build on Travis will take foreeeeeeeeeeeeeeever I'd guess...
We just add a whole bunch of different targets using CircleCI, so build breakages should go down. Our test suite however is really not exhaustive, specially for functionality other than hb_shape(). That's why, for example, when I rewrote hb_set_t, it took two followup releases to fully fix it.
From a recent mail related to this discussion, I believe the error that occurs while deploying chrome is:
symbol lookup error: /opt/google/chrome/chrome: undefined symbol: hb_font_set_ptem
Re #19, hb_font_set_ptem was added in HarfBuzz 1.6.0, rolls from 1.6.2 to 1.6.3 or an upcoming 1.6.4 should not make a difference in that regard. However, yes, the initial roll from 1.5.1 to 1.6.x adds that symbol and the new method hb_font_set_ptem is now used in Blink to fix tracking/size-dependent letter spacing on Mac.
Please see the last paragraph of the commit msg of https://chromium-review.googlesource.com/c/chromium/src/+/718860 for CrOS related issues with missing symbols. I am not so familiar with the ChromeOS development process, but it's important to refresh/reload/rebase your SDK and local development environment for the new HarfBuzz that jshin@ rolled to be picked up.
I encountered the same issue in ChromeOS.
symbol lookup error: /opt/google/chrome/chrome: undefined symbol: hb_font_set_ptem
Here's solution.
# build the package
emerge-amd64-generic harfbuzz
# deploy the package
cros deploy 10.7.201.26 media-libs/harfbuzz
Comment 1 by e...@chromium.org
, Oct 13 2017