New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 774501 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Proj-XR
Proj-XR-VR



Sign in to add a comment

Move the controller / reticle / laser into the scene hierarchy

Project Member Reported by vollick@chromium.org, Oct 13 2017

Issue description

This will remove a great deal of special-cased code in ui_renderer.

NB: this affects both WebVR and the browser since the controller may be visible in either mode (it may be used in WebVR to interact with error messages).

 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5cc802d725d4710f0cff3ac5189d177011d275a

commit a5cc802d725d4710f0cff3ac5189d177011d275a
Author: Ian Vollick <vollick@chromium.org>
Date: Wed Nov 01 14:04:47 2017

[vr] Move the controller, laser, and reticle into the UiElement tree

These elements were previously special-cased in UiRenderer. With this
change, the elements are now included in the scene graph permitting
some simplifications and making it easier to, for example, fade out
the controller if desired.

There should only be one functional change in this CL: we break
reticle sorting. This is tracked by  crbug.com/779692 .

Bug:  774501 , 768512 ,776521
Change-Id: I5173b0a419a93abe324d496664bdafef933162a5
Reviewed-on: https://chromium-review.googlesource.com/744543
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513120}
[modify] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/android/vr_shell/vr_controller.cc
[modify] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/android/vr_shell/vr_controller.h
[modify] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/android/vr_shell/vr_shell_gl.cc
[modify] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/android/vr_shell/vr_shell_gl.h
[modify] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/BUILD.gn
[rename] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/controller_mesh.cc
[rename] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/controller_mesh.h
[modify] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/elements/content_element.h
[add] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/elements/controller.cc
[add] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/elements/controller.h
[add] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/elements/laser.cc
[add] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/elements/laser.h
[add] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/elements/reticle.cc
[add] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/elements/reticle.h
[add] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/elements/ui_element_name.cc
[modify] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/elements/ui_element_name.h
[add] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/model/controller_model.h
[modify] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/model/model.h
[add] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/model/reticle_model.h
[add] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/model/web_vr_timeout_state.h
[modify] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/test/fake_ui_element_renderer.cc
[modify] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/test/fake_ui_element_renderer.h
[modify] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/test/ui_pixel_test.cc
[modify] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/testapp/vr_test_context.cc
[modify] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/testapp/vr_test_context.h
[modify] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/ui.cc
[modify] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/ui.h
[modify] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/ui_element_renderer.h
[modify] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/ui_input_manager.cc
[modify] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/ui_input_manager.h
[modify] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/ui_input_manager_unittest.cc
[modify] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/ui_interface.h
[modify] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/ui_renderer.cc
[modify] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/ui_renderer.h
[modify] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/ui_renderer_unittest.cc
[modify] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/ui_scene.cc
[modify] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/ui_scene.h
[modify] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/ui_scene_constants.h
[modify] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/ui_scene_manager.cc
[modify] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/ui_scene_manager.h
[modify] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/vr_shell_renderer.cc
[modify] https://crrev.com/a5cc802d725d4710f0cff3ac5189d177011d275a/chrome/browser/vr/vr_shell_renderer.h

Owner: vollick@chromium.org
Status: Fixed (was: Available)
Labels: M-64
Components: Internals>XR

Sign in to add a comment