New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 774500 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

[Bling Bookmarks] Change the color of spinning loader icon to blue only

Project Member Reported by martiw@chromium.org, Oct 13 2017

Issue description

Per UI review request, make the loader icon to Blue-only rather than
4-color google spinner to avoid initial red (error looking) state.

App Version: canary

Precondition:
1. For easier repro, open chrome at a slow network
2. Go to chrome://flags --> Bookmark New Generation iOS : Enabled
3. Without signed-in google account.

Steps to reproduce:
  1.  Launch chrome 
  2.  Go to Menu -->  Settings
  3.  Sign-in your google account
  4.  Go to Menu -->  Bookmarks
  You will see the spinner if it is still syncing.

Observed results:
In canary, the loader has 4-color cycle color.

Expected results:
loader icon should be Blue-only.

 
Should we change all the other uses of ActivityIndicatorBrandedCycleColors() instead? Because the other spinner will have the same issue of including red.

BTW, the spinner does blue, red, yellow, green so initial color should be blue, not red. If not, then maybe it is a bug in the spinner code.
Labels: OS-iOS
BTW, I think all our spinner should use the same colors for consistency.
Cc: noyau@chromium.org
+ noyau@

Thanks, Sylvain. Indeed, our spinners should all be the same colour (blue). 
Currently, it's blue for Zine and for Bookmarks. 

It is multi-colour for the "Other Devices" spinner under Recent Tabs so we should file a bug and fix that in the next release. Let's focus this bug on the bookmarks spinner and list on the other bugs the other places where we have a spinner. 
SGTM

Comment 6 by martiw@chromium.org, Oct 13 2017

I've filed a bug for all other spinners: crbug.com/774481
thanks folks.

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d9a5c42e582bd1b9eb96f8f07c95d99e35b158b

commit 2d9a5c42e582bd1b9eb96f8f07c95d99e35b158b
Author: Marti Wong <martiw@chromium.org>
Date: Mon Oct 16 21:12:18 2017

Change the color of spinning loader icon to blue only (iOS bookmarks)

Per UI review request, make the loader icon to Blue-only rather than
4-color google spinner to avoid initial red (error looking) state.

screenshot:
https://drive.google.com/file/d/0B1dtd3IUt4I7ZlhZRkl1SEE4OVU

demo video:
https://drive.google.com/open?id=0B1dtd3IUt4I7X0hVcWdEUERmdWs

Bug:  774500 
Change-Id: I9bc3834ec92865658029ed5d4a5f197c366f95c3
Reviewed-on: https://chromium-review.googlesource.com/719056
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509171}
[modify] https://crrev.com/2d9a5c42e582bd1b9eb96f8f07c95d99e35b158b/ios/chrome/browser/ui/bookmarks/bookmark_home_waiting_view.mm

Comment 8 by martiw@chromium.org, Oct 17 2017

Labels: Merge-Request-63
Status: Fixed (was: Started)
Project Member

Comment 9 by sheriffbot@chromium.org, Oct 18 2017

Labels: -Merge-Request-63 Hotlist-Merge-Approved Merge-Approved-63
Your change meets the bar and is auto-approved for M63. Please go ahead and merge the CL to branch 3239 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 18 2017

Labels: -merge-approved-63 merge-merged-3239
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/667b76b00558eaef252dbc806898d94cd9b684ca

commit 667b76b00558eaef252dbc806898d94cd9b684ca
Author: Marti Wong <martiw@chromium.org>
Date: Wed Oct 18 04:21:11 2017

Change the color of spinning loader icon to blue only (iOS bookmarks)

Per UI review request, make the loader icon to Blue-only rather than
4-color google spinner to avoid initial red (error looking) state.

screenshot:
https://drive.google.com/file/d/0B1dtd3IUt4I7ZlhZRkl1SEE4OVU

demo video:
https://drive.google.com/open?id=0B1dtd3IUt4I7X0hVcWdEUERmdWs

Bug:  774500 
Change-Id: I9bc3834ec92865658029ed5d4a5f197c366f95c3
Reviewed-on: https://chromium-review.googlesource.com/719056
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#509171}(cherry picked from commit 2d9a5c42e582bd1b9eb96f8f07c95d99e35b158b)
Reviewed-on: https://chromium-review.googlesource.com/725059
Reviewed-by: Marti Wong <martiw@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#44}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[modify] https://crrev.com/667b76b00558eaef252dbc806898d94cd9b684ca/ios/chrome/browser/ui/bookmarks/bookmark_home_waiting_view.mm

Verified the issue on iPhone8+(iOS 11) tested on the build 64.0.3248.0 canary.
Bookmark loader icon is Blue in color,looks good.
Status: Verified (was: Fixed)
Verified on:

App Version:63.0.3239.19 beta
Devices: iPhone 5, iPhone 7, iPad Mini, 
iOS Versions: 9.3.5, 10.3.3, 11.0.2

Spinning loader icon is in Blue color. Please see the screenshot attached.

Spinner_Bookmarks.PNG
42.7 KB View Download

Sign in to add a comment