Small fix-ups Q4 2017 |
||||||||||
Issue descriptionTracking minor bugs / fixes
,
Oct 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/48f016d9f732460779cf5b4a5257b300a2e5faf4 commit 48f016d9f732460779cf5b4a5257b300a2e5faf4 Author: Simon Glass <sjg@chromium.org> Date: Wed Oct 18 00:12:28 2017 chromeos-config: Correct unit tests for whitelabel A previous CL broken these tests and made it through the CQ. Fix it. BUG= chromium:774498 TEST=./run_tests.sh in the ~/trunk/src/platform2/chromeos-config FEATURES=test emerge-reef chromeos-config-tools FEATURES=test emerge-coral chromeos-config-tools Change-Id: I83c8d5d96a45347732da9227ab67d71449b5d32a Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/724363 Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/48f016d9f732460779cf5b4a5257b300a2e5faf4/chromeos-config/cros_config_host_py/libcros_config_host_unittest.py
,
Oct 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/2d0061a856e0e7eca24f2d7ea5b4dc27fd6418b4 commit 2d0061a856e0e7eca24f2d7ea5b4dc27fd6418b4 Author: Simon Glass <sjg@chromium.org> Date: Wed Oct 18 00:42:48 2017 Revert "chromeos-config: Correct unit tests for whitelabel" This reverts commit 48f016d9f732460779cf5b4a5257b300a2e5faf4. Reason for revert: Needed for the other revert Original change's description: > chromeos-config: Correct unit tests for whitelabel > > A previous CL broken these tests and made it through the CQ. Fix it. > > BUG= chromium:774498 > TEST=./run_tests.sh in the ~/trunk/src/platform2/chromeos-config > FEATURES=test emerge-reef chromeos-config-tools > FEATURES=test emerge-coral chromeos-config-tools > > Change-Id: I83c8d5d96a45347732da9227ab67d71449b5d32a > Signed-off-by: Simon Glass <sjg@chromium.org> > Reviewed-on: https://chromium-review.googlesource.com/724363 > Reviewed-by: Jason Clinton <jclinton@chromium.org> Bug: chromium:774498 Change-Id: Ieb633c3f719ce314d0a852d59f54575c57506f02 Reviewed-on: https://chromium-review.googlesource.com/724527 Reviewed-by: Ningning Xia <nxia@chromium.org> Commit-Queue: Simon Glass <sjg@chromium.org> Tested-by: Simon Glass <sjg@chromium.org> [modify] https://crrev.com/2d0061a856e0e7eca24f2d7ea5b4dc27fd6418b4/chromeos-config/cros_config_host_py/libcros_config_host_unittest.py
,
Oct 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/72d8fb187996c328a2655f05809af52982ac0150 commit 72d8fb187996c328a2655f05809af52982ac0150 Author: Simon Glass <sjg@chromium.org> Date: Mon Oct 23 16:14:10 2017 chromeos-config: Improve test coverage At present the implementation of the commands in cros_config_host is missing some tests and a bug has crept in. Fix the bug and add the missing tests. BUG= chromium:774498 TEST=FEATURES=test sudo -E emerge chromeos-config-tools Change-Id: Iab298a8aff983afcacd4803c6532c0705c1e3594 Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/732313 Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/72d8fb187996c328a2655f05809af52982ac0150/chromeos-config/cros_config_host.py [modify] https://crrev.com/72d8fb187996c328a2655f05809af52982ac0150/chromeos-config/cros_config_host_unittest.py
,
Oct 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/e25862973312b986cd967cfc8e9c4cacaa14305e commit e25862973312b986cd967cfc8e9c4cacaa14305e Author: Simon Glass <sjg@chromium.org> Date: Mon Oct 23 18:12:20 2017 chromeos-config: Avoid using commandline This library takes about 300ms to start (for each test) which increases the run time considerably. We don't need any of its features, so drop it. BUG= chromium:774498 TEST=PYTHONPATH=~/c ./run_tests.sh See that test time is about 1/3 as long Change-Id: Id91806ba71eb4c02d45bc66a24293ab68893ea31 Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/732314 [modify] https://crrev.com/e25862973312b986cd967cfc8e9c4cacaa14305e/chromeos-config/validate_config.py
,
Oct 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/a5ad71efc63d1025cb8b6e700850eae37f14710f commit a5ad71efc63d1025cb8b6e700850eae37f14710f Author: Simon Glass <sjg@chromium.org> Date: Mon Oct 23 18:12:20 2017 chromeos-config: Correct command-line processing At present individual file processing through the command line is broken since it always performs partial validation. Fix this. BUG= chromium:774498 TEST=Manually tested by running without -p (automated tests come in a future CL) Change-Id: Ib018835603c2256352ccce0f3b59013e1b842c37 Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/732315 Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/a5ad71efc63d1025cb8b6e700850eae37f14710f/chromeos-config/validate_config.py
,
Oct 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/ff35fff74a5db8eae4fe827a0a07be1f248f987a commit ff35fff74a5db8eae4fe827a0a07be1f248f987a Author: Simon Glass <sjg@chromium.org> Date: Mon Oct 23 18:12:21 2017 chromeos-config: Complete validator test coverage At present there is no test coverage for accessing the validator from the command line. Correct this and also adjust the return code to 1 on error. The return code 2 is used to report invalid arguments. BUG= chromium:774498 TEST=PYTHONPATH=~/c ./run_tests.sh Change-Id: Ia37405b1ec89eceb9fcb97b1336b84cfd3ad1f00 Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/732316 [modify] https://crrev.com/ff35fff74a5db8eae4fe827a0a07be1f248f987a/chromeos-config/validate_config_unittest.py [modify] https://crrev.com/ff35fff74a5db8eae4fe827a0a07be1f248f987a/chromeos-config/validate_config.py
,
Oct 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/5ecaa2630ddc2dbef61675e756284d2ffe3357d1 commit 5ecaa2630ddc2dbef61675e756284d2ffe3357d1 Author: Simon Glass <sjg@chromium.org> Date: Mon Oct 23 22:22:16 2017 chromeos-config: Update comments and fix a typo Two files have the same typo. Fix this and adjust the comment in the test library to indicate that it is a test. BUG= chromium:774498 TEST=none Change-Id: I52ab344bc9ab9f5cda9ac3eab16274f11a864db9 Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/732322 Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/5ecaa2630ddc2dbef61675e756284d2ffe3357d1/chromeos-config/libcros_config/cros_config_unittest.cc [modify] https://crrev.com/5ecaa2630ddc2dbef61675e756284d2ffe3357d1/chromeos-config/libcros_config/cros_config.cc
,
Oct 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/f48b5fd29ffb3049aa0919079349fe42890d0866 commit f48b5fd29ffb3049aa0919079349fe42890d0866 Author: Simon Glass <sjg@chromium.org> Date: Mon Oct 23 22:22:17 2017 chromeos-config: Add a test for CrosConfigFake We don't have a test for this at present which makes it vulnerable to changes in the underlying interface and bugs in the implementation. At present these might show up as failures in session_manager, for example. Add a simple test for the Fake, representing our deep sympathy for our clients. BUG= chromium:774498 TEST=With a change to run this test from the ebuild: FEATURES=test emerge-reef-uni --nodeps chromeos-config-tools Change-Id: Iceba0866e71a12578e1ae69a5f3769d562be15f2 Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/732643 Reviewed-by: Jason Clinton <jclinton@chromium.org> [add] https://crrev.com/f48b5fd29ffb3049aa0919079349fe42890d0866/chromeos-config/libcros_config/fake_cros_config_unittest.cc [modify] https://crrev.com/f48b5fd29ffb3049aa0919079349fe42890d0866/chromeos-config/chromeos-config.gyp
,
Oct 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/a894a4957c394d7dd8f92417a9840614a6e4fa07 commit a894a4957c394d7dd8f92417a9840614a6e4fa07 Author: Simon Glass <sjg@chromium.org> Date: Mon Oct 23 22:22:17 2017 chromeos-config: Update FakeCrosConfig to support non-root nodes The real implementation (CrosConfig) supports this now. Update the Fake to support it as well. BUG= chromium:774498 TEST=FEATURES=test emerge-reef-uni --nodeps chromeos-config-tools Change-Id: Ibedb67fd761f0a2ed09a252a9811dcc6fb69c3ea Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/732644 Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/a894a4957c394d7dd8f92417a9840614a6e4fa07/chromeos-config/libcros_config/fake_cros_config.cc [modify] https://crrev.com/a894a4957c394d7dd8f92417a9840614a6e4fa07/chromeos-config/libcros_config/fake_cros_config_unittest.cc
,
Oct 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/firmware/+/44dc9f3a890f747ed4c1704dc9834966b58dc9fe commit 44dc9f3a890f747ed4c1704dc9834966b58dc9fe Author: Simon Glass <sjg@chromium.org> Date: Wed Oct 25 22:44:12 2017 pack_firmware: Run the firmware updater silently At present the functional test logs output when running the firmware auto-update: INFO:root:RunCommand: /bin/dash /tmp/tmpvHwy5Mpack_firmwaretest-7455/output.sh --mode output --model electro --output_dir /tmp/tmpvHwy5Mpack_firmwaretest-7455 --verbose --debug Supress this as it is not useful. BUG= chromium:774498 TEST=PYTHONPATH=~/c python pack_firmware_functest.py See there is no output now Change-Id: I2a862c49be8fd777533ed89bac933396c03a0f72 Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/735332 Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/44dc9f3a890f747ed4c1704dc9834966b58dc9fe/pack_firmware_functest.py
,
Oct 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/d582b99e3c78a810bb110b9027859c8a42e30e99 commit d582b99e3c78a810bb110b9027859c8a42e30e99 Author: Simon Glass <sjg@chromium.org> Date: Thu Oct 26 09:33:45 2017 chromeos-config-tools: Run the FakeCrosConfig unit test Run this new test so we have test coverage of this class. BUG= chromium:774498 TEST=FEATURES=test emerge-reef-uni --nodeps chromeos-config-tools Change-Id: I5329e89fc87e7c0c5e5d74f667f7df8336bed72d Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/732310 Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/d582b99e3c78a810bb110b9027859c8a42e30e99/chromeos-base/chromeos-config-tools/chromeos-config-tools-9999.ebuild
,
Oct 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/5d2656c4e9ac2cb4361d99d2fe74d67b07f8fb06 commit 5d2656c4e9ac2cb4361d99d2fe74d67b07f8fb06 Author: Simon Glass <sjg@chromium.org> Date: Thu Oct 26 09:33:46 2017 chromeos-config-tools: Don't install cros_config_schema.py This is not actually needed at present. Drop it to avoid confusion. BUG= chromium:774498 TEST=sudo emerge chromeos-config-tools; see that the file is gone Change-Id: I5e706b248e19e2cd4749b6e7d90ef03ba77e2630 Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/734401 Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/5d2656c4e9ac2cb4361d99d2fe74d67b07f8fb06/chromeos-base/chromeos-config-tools/chromeos-config-tools-9999.ebuild
,
Oct 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/e3d8d7f235e28e89017e7e1a5fc6465e1c776106 commit e3d8d7f235e28e89017e7e1a5fc6465e1c776106 Author: Simon Glass <sjg@chromium.org> Date: Fri Oct 27 01:09:23 2017 chromeos-config: Drop stdin support from cros_config This tool can only access run-time config and this comes from a known location. We do not want to support reading config from stdin. That is useful in the host tool (cros_config_host) but not here. BUG= chromium:774498 TEST=FEATURES=test emerge-reef-uni --nodeps chromeos-config-tools Change-Id: I72b7f80ce48b0140645705b257d7785f5dbd7cd1 Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/739394 Reviewed-by: Jason Clinton <jclinton@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/e3d8d7f235e28e89017e7e1a5fc6465e1c776106/chromeos-config/libcros_config/cros_config.cc
,
Oct 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/25af3c90c2b96907a94e3dc7c56d23420eb9804e commit 25af3c90c2b96907a94e3dc7c56d23420eb9804e Author: Simon Glass <sjg@chromium.org> Date: Fri Oct 27 15:18:07 2017 cros-unibuild: Detect cros_config_host errors and abort At present if cros_config_host fails we do not not. Adjust the pattern used to run this tool so that we can detect this and abort. BUG= chromium:774498 TEST=emerge-reef-uni --nodeps chromeos-bsp-baseboard-reef-private Introduce an error in cros_config_host and see that the error is displayed and the ebuild aborts Change-Id: I568ed5e7134c66633732c8b0fa3578728ae77b3c Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/732309 Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/25af3c90c2b96907a94e3dc7c56d23420eb9804e/eclass/cros-unibuild.eclass
,
Oct 31 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/overlays/overlay-reef-private/+/6a31e140e8b415de643fdb66cec9dc527ea7dbac commit 6a31e140e8b415de643fdb66cec9dc527ea7dbac Author: Simon Glass <sjg@chromium.org> Date: Tue Oct 31 08:44:38 2017
,
Oct 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/4d77d7628550c066ae5c270a207021be54cbc391 commit 4d77d7628550c066ae5c270a207021be54cbc391 Author: Simon Glass <sjg@chromium.org> Date: Tue Oct 31 17:42:18 2017 chromeos-config: Add cros_config_host We don't want the _py suffix now that the C++ version of cros_config_host is gone. Add a new symlink which can be installed. We can drop the old one once the chromeos-config-tools ebuild is migrated. BUG= chromium:774498 TEST= sudo emerge --nodeps chromeos-config-tools With changes to install this file, see that it works Change-Id: Id6983f61abe584734c98f460b9816d058320fb40 Reviewed-on: https://chromium-review.googlesource.com/743032 Tested-by: Simon Glass <sjg@chromium.org> Reviewed-by: Lann Martin <lannm@chromium.org> Reviewed-by: Jason Clinton <jclinton@chromium.org> [add] https://crrev.com/4d77d7628550c066ae5c270a207021be54cbc391/chromeos-config/cros_config_host
,
Nov 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/749d72ca9cd5a025b61caaa58740bd4d09bd9905 commit 749d72ca9cd5a025b61caaa58740bd4d09bd9905 Author: Simon Glass <sjg@chromium.org> Date: Wed Nov 08 23:10:08 2017 chromeos-config: Correct missing variable init This variable should be set to None in case an exception occurs. BUG= chromium:774498 TEST=FEATURES=test sudo -E emerge --nodeps -q chromeos-config-tools Change-Id: I4c8942b5db1f7cb9fd1385c3b082c8e1176cd8f7 Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/757174 Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/749d72ca9cd5a025b61caaa58740bd4d09bd9905/chromeos-config/libcros_config_host/fdt_unittest.py
,
Nov 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/97122ca81475aba324e97f228ea78c4c5fc26b1b commit 97122ca81475aba324e97f228ea78c4c5fc26b1b Author: Simon Glass <sjg@chromium.org> Date: Wed Nov 08 23:10:08 2017 chromeos-config: Add a nicer error when cras-config-dir is missing We have no validation for this case at present (see TODO in validate_config.py). For now, add a nice error message showing the path of the problem. BUG= chromium:774498 TEST=FEATURES=test sudo -E emerge --nodeps -q chromeos-config-tools Change-Id: Iae70f0d415afc49a8557d11c2267134e6bd6e588 Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/757175 Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/97122ca81475aba324e97f228ea78c4c5fc26b1b/chromeos-config/libcros_config_host/libcros_config_host.py
,
Nov 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/a7a0858a51009d9eba815f0a8a3179cc136b9fe6 commit a7a0858a51009d9eba815f0a8a3179cc136b9fe6 Author: Simon Glass <sjg@chromium.org> Date: Wed Nov 08 23:10:08 2017 chromeos-config: Show the full path when we cannot look up Rather than just the relative path, show the full path when a lookup fails. This is important now that we support submodels. BUG= chromium:774498 TEST=FEATURES=test sudo -E emerge --nodeps -q chromeos-config-tools Change-Id: If2b83f01dccfde183745a8bdae6fa5abcfacdfb5 Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/757256 Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/a7a0858a51009d9eba815f0a8a3179cc136b9fe6/chromeos-config/libcros_config/cros_config.cc
,
Nov 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/firmware/+/235a6eb7ad18b393d10954f43467977ffd4a9967 commit 235a6eb7ad18b393d10954f43467977ffd4a9967 Author: Simon Glass <sjg@chromium.org> Date: Sat Nov 11 02:45:51 2017 pack_firmware: Convert the key IDs to upper case These should be upper case to pass the schema validator. Update them. BUG= chromium:774498 TEST=python pack_firmware_functest.py Change-Id: Ia5b2080c69fb6ec2c6a47d57587a347c4233a8b0 Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/764001 Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/235a6eb7ad18b393d10954f43467977ffd4a9967/pack_firmware_functest.py [modify] https://crrev.com/235a6eb7ad18b393d10954f43467977ffd4a9967/test/config_base.dtsi
,
Nov 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/197cf3e9b38a0c4e3813e4232671dc850fd0da50 commit 197cf3e9b38a0c4e3813e4232671dc850fd0da50 Author: Simon Glass <sjg@chromium.org> Date: Sat Nov 18 04:18:51 2017 chromeos-config: Fix a few code-style nits in cros_config.cc/h These were noticed when examining the code again and running 'cros lint'. BUG= chromium:774498 TEST=FEATURES=test sudo -E emerge --nodeps chromeos-config-tools Change-Id: Ia789800811dfd9938453680ba6693c44364044da Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/774903 Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/197cf3e9b38a0c4e3813e4232671dc850fd0da50/chromeos-config/libcros_config/lookup.cc [modify] https://crrev.com/197cf3e9b38a0c4e3813e4232671dc850fd0da50/chromeos-config/libcros_config/cros_config.cc [modify] https://crrev.com/197cf3e9b38a0c4e3813e4232671dc850fd0da50/chromeos-config/libcros_config/cros_config.h
,
Dec 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/90f619c4b4baacd84b8e3602f0ef8f8259ea4445 commit 90f619c4b4baacd84b8e3602f0ef8f8259ea4445 Author: Simon Glass <sjg@chromium.org> Date: Sat Dec 16 18:02:39 2017 cros-unibuild: Drop the coral firmware workaround We don't need this anymore since the firmware packer does not rely on the order of models in the config anymore. BUG= chromium:774498 TEST=emerge-reef chromeos-firmware-reef See that the error message is gone Change-Id: Ifce32c95c9b0e770bb92266921448b772891002c Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/828020 Reviewed-by: Jason Clinton <jclinton@chromium.org> Reviewed-by: C Shapiro <shapiroc@google.com> [modify] https://crrev.com/90f619c4b4baacd84b8e3602f0ef8f8259ea4445/eclass/cros-unibuild.eclass
,
Dec 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/f12d6574cb9d77cb12ca36d65f36a97ba6c5965a commit f12d6574cb9d77cb12ca36d65f36a97ba6c5965a Author: Simon Glass <sjg@chromium.org> Date: Sat Dec 16 18:02:39 2017 cros-unibuild: Tidy up function names and comments Various things are wrong with the comments in this file. Also some of the names are too generic. Tidy this up. Note that --all-models is not needed with cros_config_host commands as they generally operate on all models. BUG= chromium:774498 TEST=emerge-coral --nodeps chromeos-config-bsp chromeos-config \ chromeos-bsp-coral-private chromeos-firmware-coral Check firmware output manually and see that BSP files are installed Change-Id: If482c4176621d25fcba8cb94dac8837838b02aad Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/831146 Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/f12d6574cb9d77cb12ca36d65f36a97ba6c5965a/eclass/cros-unibuild.eclass [modify] https://crrev.com/f12d6574cb9d77cb12ca36d65f36a97ba6c5965a/eclass/cros-firmware.eclass
,
Dec 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/3de9559711dec036102c1e76d4ed62cae92c5c71 commit 3de9559711dec036102c1e76d4ed62cae92c5c71 Author: Simon Glass <sjg@chromium.org> Date: Mon Dec 18 06:28:49 2017 cros-unibuild: Install thermal files the new way Create a common installation function for unibuild. Use this to obtain and install thermal files using cros_config_host. BUG= chromium:774498 TEST=manually test with coral ebuild Needs manual testing on robo Change-Id: I9a9fd056e081599aa0c3ae77668b6cf33f08035e Reviewed-on: https://chromium-review.googlesource.com/742330 Commit-Ready: Simon Glass <sjg@chromium.org> Tested-by: Simon Glass <sjg@chromium.org> Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/3de9559711dec036102c1e76d4ed62cae92c5c71/eclass/cros-unibuild.eclass
,
Dec 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/8d10eb04e137f9f805bf55207f350006dad8f04b commit 8d10eb04e137f9f805bf55207f350006dad8f04b Author: Simon Glass <sjg@chromium.org> Date: Fri Dec 22 02:08:56 2017 chromeos-config: Drop unwanted 'print' in audio test This slipped in from debugging I think. Drop it. BUG= chromium:774498 TEST=./run_tests.sh See that it doesn't print the audio files anymore Change-Id: I248afde4a2a1ea23845fdd613e80689bae7b5f29 Signed-off-by: Simon Glass <sjg@chromium.org> [modify] https://crrev.com/8d10eb04e137f9f805bf55207f350006dad8f04b/chromeos-config/cros_config_host/v2/libcros_config_host_json_unittest.py
,
Dec 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/4e098f7239da118563eae17a152ee4874ddb0ba8 commit 4e098f7239da118563eae17a152ee4874ddb0ba8 Author: Simon Glass <sjg@chromium.org> Date: Fri Dec 22 06:50:30 2017 chromeos-config: Fix pylint errors Fix a few long-standing errors that are mildly annoying. BUG= chromium:774498 TEST=repo upload, see there are no errors now Change-Id: I3bc8c174a4f0380d1c6959a8d8e3783ff11138a3 Signed-off-by: Simon Glass <sjg@chromium.org> [modify] https://crrev.com/4e098f7239da118563eae17a152ee4874ddb0ba8/chromeos-config/cros_config_host/libcros_config_host.py
,
Jan 3 2018
,
Jan 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/8ac0f2ce0b8c086f0971dcbbe74fa30dca959af2 commit 8ac0f2ce0b8c086f0971dcbbe74fa30dca959af2 Author: Simon Glass <sjg@chromium.org> Date: Fri Jan 26 03:24:01 2018 chromeos-config: Allow firmware node to be called anything At present we require family firmware nodes to match an existing model. We don't need to enforce this anymore since the firmware packer no-longer reads the config directly, and can handle any name. BUG= chromium:774498 TEST=sudo emerge --nodeps -q chromeos-config-host emerge-coral -q --nodeps chromeos-config-bsp chromeos-config \ chromeos-firmware-coral See that the firmware updater looks correct Signed-off-by: Simon Glass <sjg@chromium.org> Change-Id: Icc66ccc01fd8410a2c60f9bf45af2734b4810486 Reviewed-on: https://chromium-review.googlesource.com/826807 Commit-Ready: Patrick Berny <pberny@chromium.org> Tested-by: Patrick Berny <pberny@chromium.org> Reviewed-by: Jason Clinton <jclinton@chromium.org> Reviewed-by: Patrick Berny <pberny@chromium.org> [modify] https://crrev.com/8ac0f2ce0b8c086f0971dcbbe74fa30dca959af2/chromeos-config/README.md [modify] https://crrev.com/8ac0f2ce0b8c086f0971dcbbe74fa30dca959af2/chromeos-config/cros_config_host/validate_config.py
,
Feb 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/052a0dce3a19a62fd95d3c7ff4f3bb6ca64d514f commit 052a0dce3a19a62fd95d3c7ff4f3bb6ca64d514f Author: Simon Glass <sjg@chromium.org> Date: Fri Feb 02 23:12:12 2018 chromeos-config: Correct unit test for firmware This was broken by a recent CL which changed the error string. Fix it. BUG= chromium:774498 TEST=FEATURES=test sudo -E emerge chromeos-config-host Change-Id: I4764dfb120fd7efaa228fa6112e7667bd9d718f6 Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/900126 Reviewed-by: Jason Clinton <jclinton@chromium.org> Reviewed-by: C Shapiro <shapiroc@google.com> [modify] https://crrev.com/052a0dce3a19a62fd95d3c7ff4f3bb6ca64d514f/chromeos-config/cros_config_host/validate_config_unittest.py
,
Feb 4 2018
,
Feb 5 2018
,
Feb 5 2018
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/4a93430ed06a677a164f824570f8522723fd57e9 commit 4a93430ed06a677a164f824570f8522723fd57e9 Author: Simon Glass <sjg@chromium.org> Date: Mon Feb 05 22:42:15 2018 chromeos-config: Allow firmware node to be called anything At present we require family firmware nodes to match an existing model. We don't need to enforce this anymore since the firmware packer no-longer reads the config directly, and can handle any name. BUG= chromium:774498 TEST=sudo emerge --nodeps -q chromeos-config-host emerge-coral -q --nodeps chromeos-config-bsp chromeos-config \ chromeos-firmware-coral See that the firmware updater looks correct Signed-off-by: Simon Glass <sjg@chromium.org> Change-Id: Icc66ccc01fd8410a2c60f9bf45af2734b4810486 Reviewed-on: https://chromium-review.googlesource.com/826807 Commit-Ready: Patrick Berny <pberny@chromium.org> Tested-by: Patrick Berny <pberny@chromium.org> Reviewed-by: Jason Clinton <jclinton@chromium.org> Reviewed-by: Patrick Berny <pberny@chromium.org> (cherry picked from commit 8ac0f2ce0b8c086f0971dcbbe74fa30dca959af2) Reviewed-on: https://chromium-review.googlesource.com/900384 Reviewed-by: Simon Glass <sjg@chromium.org> Commit-Queue: Patrick Berny <pberny@chromium.org> Trybot-Ready: Patrick Berny <pberny@chromium.org> [modify] https://crrev.com/4a93430ed06a677a164f824570f8522723fd57e9/chromeos-config/README.md [modify] https://crrev.com/4a93430ed06a677a164f824570f8522723fd57e9/chromeos-config/cros_config_host/validate_config.py
,
Feb 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/410dd320cecfddfbb8a07389c4f290d137d273b0 commit 410dd320cecfddfbb8a07389c4f290d137d273b0 Author: Simon Glass <sjg@chromium.org> Date: Tue Feb 06 06:21:09 2018 chromeos-config: Allow firmware node to be called anything At present we require family firmware nodes to match an existing model. We don't need to enforce this anymore since the firmware packer no-longer reads the config directly, and can handle any name. BUG= chromium:774498 TEST=sudo emerge --nodeps -q chromeos-config-host emerge-coral -q --nodeps chromeos-config-bsp chromeos-config \ chromeos-firmware-coral See that the firmware updater looks correct Signed-off-by: Simon Glass <sjg@chromium.org> Change-Id: Icc66ccc01fd8410a2c60f9bf45af2734b4810486 Reviewed-on: https://chromium-review.googlesource.com/826807 Commit-Ready: Patrick Berny <pberny@chromium.org> Tested-by: Patrick Berny <pberny@chromium.org> Reviewed-by: Jason Clinton <jclinton@chromium.org> Reviewed-by: Patrick Berny <pberny@chromium.org> (cherry picked from commit 8ac0f2ce0b8c086f0971dcbbe74fa30dca959af2) (cherry picked from commit 2ad7e3b63f11da8223992f982d4f36877f9a43c3) Reviewed-on: https://chromium-review.googlesource.com/900485 Reviewed-by: Simon Glass <sjg@chromium.org> Commit-Queue: Patrick Berny <pberny@chromium.org> Trybot-Ready: Patrick Berny <pberny@chromium.org> [modify] https://crrev.com/410dd320cecfddfbb8a07389c4f290d137d273b0/chromeos-config/README.md [modify] https://crrev.com/410dd320cecfddfbb8a07389c4f290d137d273b0/chromeos-config/cros_config_host/validate_config.py
,
Feb 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/b69535828472c1cbe65cb34d9bf124451b9ad2e3 commit b69535828472c1cbe65cb34d9bf124451b9ad2e3 Author: Simon Glass <sjg@chromium.org> Date: Thu Feb 08 00:09:56 2018 chromeos-config: Correct unit test for firmware This was broken by a recent CL which changed the error string. Fix it. BUG= chromium:774498 TEST=FEATURES=test sudo -E emerge chromeos-config-host Change-Id: I4764dfb120fd7efaa228fa6112e7667bd9d718f6 Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/900126 Reviewed-by: Jason Clinton <jclinton@chromium.org> Reviewed-by: C Shapiro <shapiroc@google.com> (cherry picked from commit 052a0dce3a19a62fd95d3c7ff4f3bb6ca64d514f) Reviewed-on: https://chromium-review.googlesource.com/902887 Reviewed-by: YH Lin <yueherngl@chromium.org> Commit-Queue: Patrick Berny <pberny@chromium.org> Tested-by: Patrick Berny <pberny@chromium.org> Trybot-Ready: Patrick Berny <pberny@chromium.org> [modify] https://crrev.com/b69535828472c1cbe65cb34d9bf124451b9ad2e3/chromeos-config/cros_config_host/validate_config_unittest.py
,
Feb 12 2018
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 16 2018
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/e2cb766c0050413e36953795e157613d15d606d3 commit e2cb766c0050413e36953795e157613d15d606d3 Author: Simon Glass <sjg@chromium.org> Date: Sat Feb 17 01:05:32 2018 chromeos-config: Correct unit test for firmware This was broken by a recent CL which changed the error string. Fix it. BUG= chromium:774498 TEST=FEATURES=test sudo -E emerge chromeos-config-host Change-Id: I4764dfb120fd7efaa228fa6112e7667bd9d718f6 Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/900126 Reviewed-by: Jason Clinton <jclinton@chromium.org> Reviewed-by: C Shapiro <shapiroc@google.com> (cherry picked from commit 052a0dce3a19a62fd95d3c7ff4f3bb6ca64d514f) Reviewed-on: https://chromium-review.googlesource.com/902888 Reviewed-by: YH Lin <yueherngl@chromium.org> Commit-Queue: Patrick Berny <pberny@chromium.org> Tested-by: Patrick Berny <pberny@chromium.org> Trybot-Ready: Patrick Berny <pberny@chromium.org> [modify] https://crrev.com/e2cb766c0050413e36953795e157613d15d606d3/chromeos-config/cros_config_host/validate_config_unittest.py
,
Feb 18 2018
,
Mar 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/b670829433308ec515dedab583226a0c4954ad2f commit b670829433308ec515dedab583226a0c4954ad2f Author: Simon Glass <sjg@chromium.org> Date: Fri Mar 16 02:34:35 2018 cros-unibuild: Drop the coral firmware workaround We don't need this anymore since the firmware packer does not rely on the order of models in the config anymore. BUG= chromium:774498 TEST=emerge-reef chromeos-firmware-reef See that the error message is gone Change-Id: Ifce32c95c9b0e770bb92266921448b772891002c Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/828020 Reviewed-by: Jason Clinton <jclinton@chromium.org> Reviewed-by: C Shapiro <shapiroc@google.com> (cherry picked from commit 90f619c4b4baacd84b8e3602f0ef8f8259ea4445) Reviewed-on: https://chromium-review.googlesource.com/963071 Commit-Queue: YH Lin <yueherngl@chromium.org> Tested-by: YH Lin <yueherngl@chromium.org> [modify] https://crrev.com/b670829433308ec515dedab583226a0c4954ad2f/eclass/cros-unibuild.eclass
,
Mar 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/0a41facfdf1fde36d6bcf368857c6f9680757103 commit 0a41facfdf1fde36d6bcf368857c6f9680757103 Author: Simon Glass <sjg@chromium.org> Date: Fri Mar 16 02:34:38 2018 cros-unibuild: Tidy up function names and comments Various things are wrong with the comments in this file. Also some of the names are too generic. Tidy this up. Note that --all-models is not needed with cros_config_host commands as they generally operate on all models. BUG= chromium:774498 TEST=emerge-coral --nodeps chromeos-config-bsp chromeos-config \ chromeos-bsp-coral-private chromeos-firmware-coral Check firmware output manually and see that BSP files are installed Change-Id: If482c4176621d25fcba8cb94dac8837838b02aad Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/831146 Reviewed-by: Mike Frysinger <vapier@chromium.org> (cherry picked from commit f12d6574cb9d77cb12ca36d65f36a97ba6c5965a) Reviewed-on: https://chromium-review.googlesource.com/964924 Reviewed-by: Patrick Berny <pberny@chromium.org> Commit-Queue: YH Lin <yueherngl@chromium.org> Tested-by: YH Lin <yueherngl@chromium.org> [modify] https://crrev.com/0a41facfdf1fde36d6bcf368857c6f9680757103/eclass/cros-unibuild.eclass [modify] https://crrev.com/0a41facfdf1fde36d6bcf368857c6f9680757103/eclass/cros-firmware.eclass
,
Mar 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/d7982cdce7b569414c80d2187b1c52adbabea2b6 commit d7982cdce7b569414c80d2187b1c52adbabea2b6 Author: Simon Glass <sjg@chromium.org> Date: Fri Mar 16 02:34:39 2018 cros-unibuild: Install thermal files the new way Create a common installation function for unibuild. Use this to obtain and install thermal files using cros_config_host. BUG= chromium:774498 TEST=manually test with coral ebuild Needs manual testing on robo Change-Id: I9a9fd056e081599aa0c3ae77668b6cf33f08035e Reviewed-on: https://chromium-review.googlesource.com/742330 Commit-Ready: Simon Glass <sjg@chromium.org> Tested-by: Simon Glass <sjg@chromium.org> Reviewed-by: Jason Clinton <jclinton@chromium.org> (cherry picked from commit 3de9559711dec036102c1e76d4ed62cae92c5c71) Reviewed-on: https://chromium-review.googlesource.com/963072 Commit-Queue: YH Lin <yueherngl@chromium.org> Tested-by: YH Lin <yueherngl@chromium.org> [modify] https://crrev.com/d7982cdce7b569414c80d2187b1c52adbabea2b6/eclass/cros-unibuild.eclass |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by bugdroid1@chromium.org
, Oct 15 2017