New issue
Advanced search Search tips

Issue 774492 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Move cros_config_host_py files out of their subdir

Project Member Reported by sjg@chromium.org, Oct 13 2017

Issue description

I think it is better to drtop the cros_config_host_py subdir and put the files in the main dir. That makes it easier to find things.
 
Maybe once the cros_config_host_py tool is ready, move everything into /host and /board folders? The /host stuff (python) will continue to grow right? While the cros_config stuff will be pared down?

Comment 2 by sjg@chromium.org, Oct 13 2017

Or perhaps just have libcros_config and libcros_config_host dirs?

Will this break any of the install stuff? If so, is it worth doing? I know it will require some tests being updated.

Comment 4 by sjg@chromium.org, Oct 17 2017

You should be able to change these lines in the chromeos-config-tools ebuild:

			for fname in cros_config_host_py/*.py; do
				einfo "install ${fname}"
				doexe "${fname}"
			done
			exeinto /usr/bin
			doexe cros_config_host_py/cros_config_host_py

BTW, please install the validator (in validate/) at the same time.

Yes I think it is worth doing. Your tool will be the official one soon and should not be hidden away
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/f84e67ccffd5ff19b6682f13b405921c3c3b5626

commit f84e67ccffd5ff19b6682f13b405921c3c3b5626
Author: Simon Glass <sjg@chromium.org>
Date: Mon Oct 23 11:28:25 2017

chromeos-config-tools: Adjust installer for new locations

Some files have moved in the repo. Update the installation to suit.
Ensure that library files are stored in a library subdirectory.

BUG= chromium:774492 
CQ-DEPEND=CL:731578
TEST=FEATURES=test sudo -E emerge --nodeps chromeos-config-tools

Change-Id: I493d42383cf2fa4ddf4ca1c8f826076b571c8c12
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/732109

[modify] https://crrev.com/f84e67ccffd5ff19b6682f13b405921c3c3b5626/chromeos-base/chromeos-config-tools/chromeos-config-tools-9999.ebuild

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/2608a4d24a14025c01b9514db7c95380ebf52469

commit 2608a4d24a14025c01b9514db7c95380ebf52469
Author: Alec Thilenius <athilenius@chromium.org>
Date: Mon Oct 23 11:28:26 2017

chromeos-config: File structure re-org

Re-organize the file structure in chromeos-config. Moved the CLI tool
for the python library out to the root, renamed it do cros_config_host
and fixed all the broken file paths in unit tests. All unit tests pass
but the ebuild needs to be updated before this can be merged.

BUG= chromium:774492 
CQ-DEPEND=CL:732109
TEST=emerge --unmerge chromeos-config-tools
FEATURES=test sudo -E emerge chromeos-config-tools
PYTHONPATH=~/c ./run_tests.sh

Change-Id: Icab8453f1aad4909896cd1f0e48ec4cd7bb659e3
Reviewed-on: https://chromium-review.googlesource.com/731578
Commit-Ready: Simon Glass <sjg@chromium.org>
Tested-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Simon Glass <sjg@chromium.org>

[rename] https://crrev.com/2608a4d24a14025c01b9514db7c95380ebf52469/chromeos-config/libcros_config_host/fdt.py
[rename] https://crrev.com/2608a4d24a14025c01b9514db7c95380ebf52469/chromeos-config/libcros_config_host/libcros_config_host.py
[rename] https://crrev.com/2608a4d24a14025c01b9514db7c95380ebf52469/chromeos-config/validate_config.py
[rename] https://crrev.com/2608a4d24a14025c01b9514db7c95380ebf52469/chromeos-config/libcros_config_host/fdt_unittest.py
[rename] https://crrev.com/2608a4d24a14025c01b9514db7c95380ebf52469/chromeos-config/cros_config_host_py
[rename] https://crrev.com/2608a4d24a14025c01b9514db7c95380ebf52469/chromeos-config/cros_config_host_unittest.py
[rename] https://crrev.com/2608a4d24a14025c01b9514db7c95380ebf52469/chromeos-config/validate_config_unittest.py
[rename] https://crrev.com/2608a4d24a14025c01b9514db7c95380ebf52469/chromeos-config/cros_config_schema_example.json
[modify] https://crrev.com/2608a4d24a14025c01b9514db7c95380ebf52469/chromeos-config/setup.py
[rename] https://crrev.com/2608a4d24a14025c01b9514db7c95380ebf52469/chromeos-config/libcros_config_host/fdt_util.py
[rename] https://crrev.com/2608a4d24a14025c01b9514db7c95380ebf52469/chromeos-config/cros_config_host.py
[rename] https://crrev.com/2608a4d24a14025c01b9514db7c95380ebf52469/chromeos-config/validate_config
[add] https://crrev.com/2608a4d24a14025c01b9514db7c95380ebf52469/chromeos-config/libcros_config_host/__init__.py
[modify] https://crrev.com/2608a4d24a14025c01b9514db7c95380ebf52469/chromeos-config/cros_config_schema_unittest.py
[rename] https://crrev.com/2608a4d24a14025c01b9514db7c95380ebf52469/chromeos-config/validate_schema.py
[rename] https://crrev.com/2608a4d24a14025c01b9514db7c95380ebf52469/chromeos-config/libcros_config_host_unittest.py

Status: Fixed (was: Untriaged)

Sign in to add a comment