Standardize the color of the spinning loader icon in Bling |
||||||
Issue descriptionWhen doing this search: https://cs.chromium.org/search/?q=(+setCycleColors+OR+%22cycleColors+%3D%22+)+-f:third_party&sq=package:chromium We can see there are 2 spinning loader color being used: 1. @[ [[MDCPalette cr_bluePalette] tint500] ] 2. ActivityIndicatorBrandedCycleColors() Do we need to standardize them and use one color only?
,
Oct 13 2017
Per discussion in crbug.com/ Issue 774500 Our spinners should all be the same colour (blue) so we should use @[ [[MDCPalette cr_bluePalette] tint500] ]
,
Oct 16 2017
,
Oct 16 2017
,
Oct 16
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 17
Is this still needed @Pete?
,
Oct 18
Pete could you give your thoughts on this?
,
Oct 22
Yeah I think they should obviously be consistent throughout our app. In terms of which one to use: I guess use the one that is in the Google brand palette. I didn't look at the implementation, but something tells me that would be `ActivityIndicatorBrandedCycleColors`. The effect I'm looking for is a single static blue tint color, so if instead `ActivityIndicatorBrandedCycleColors` produces the 4-color transitioning effect, then we should just use the same blue (which may or may not be the same as [[MDCPalette cr_bluePalette] tint500]) that we use to tint all our blue controls in the post-m69 work ... that way we are consistent. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by martiw@chromium.org
, Oct 13 2017Labels: M-64