New issue
Advanced search Search tips

Issue 774476 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Unify service worker payment app retrieval across platforms

Project Member Reported by rouslan@chromium.org, Oct 13 2017

Issue description

Android and desktop both use ManifestVerifier for service worker payment apps, but they have their own different ways for filtering apps based on payment methods they support. Capability matching and CanMakePaymentEvent handling should also be common.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/438d8c97a9f822a2716f51125370d1997db2ccba

commit 438d8c97a9f822a2716f51125370d1997db2ccba
Author: Rouslan Solomakhin <rouslan@chromium.org>
Date: Thu Oct 26 21:33:18 2017

[Payments] Unify service worker payment apps among platforms.

This patch adds ServiceWorkerPaymentAppFactory, which is used by both
Android and desktop to retrieve payment apps, filter them based on
supported payment methods, and verify permission to use URL-based
payment methods.

Bug: 774476
Change-Id: I9d9aee03d828f993f9d28c6312ca11bd5ec178fa
Reviewed-on: https://chromium-review.googlesource.com/718917
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511965}
[modify] https://crrev.com/438d8c97a9f822a2716f51125370d1997db2ccba/chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentAppBridge.java
[modify] https://crrev.com/438d8c97a9f822a2716f51125370d1997db2ccba/chrome/browser/android/payments/service_worker_payment_app_bridge.cc
[modify] https://crrev.com/438d8c97a9f822a2716f51125370d1997db2ccba/chrome/browser/payments/manifest_verifier_browsertest.cc
[add] https://crrev.com/438d8c97a9f822a2716f51125370d1997db2ccba/chrome/browser/payments/service_worker_payment_app_factory_browsertest.cc
[modify] https://crrev.com/438d8c97a9f822a2716f51125370d1997db2ccba/chrome/test/BUILD.gn
[modify] https://crrev.com/438d8c97a9f822a2716f51125370d1997db2ccba/components/payments/content/BUILD.gn
[modify] https://crrev.com/438d8c97a9f822a2716f51125370d1997db2ccba/components/payments/content/manifest_verifier.cc
[modify] https://crrev.com/438d8c97a9f822a2716f51125370d1997db2ccba/components/payments/content/payment_request_state.cc
[modify] https://crrev.com/438d8c97a9f822a2716f51125370d1997db2ccba/components/payments/content/payment_request_state.h
[add] https://crrev.com/438d8c97a9f822a2716f51125370d1997db2ccba/components/payments/content/service_worker_payment_app_factory.cc
[add] https://crrev.com/438d8c97a9f822a2716f51125370d1997db2ccba/components/payments/content/service_worker_payment_app_factory.h
[add] https://crrev.com/438d8c97a9f822a2716f51125370d1997db2ccba/components/payments/content/service_worker_payment_app_factory_unittest.cc
[modify] https://crrev.com/438d8c97a9f822a2716f51125370d1997db2ccba/components/payments/core/BUILD.gn
[add] https://crrev.com/438d8c97a9f822a2716f51125370d1997db2ccba/components/payments/core/test_payment_manifest_downloader.cc
[add] https://crrev.com/438d8c97a9f822a2716f51125370d1997db2ccba/components/payments/core/test_payment_manifest_downloader.h
[add] https://crrev.com/438d8c97a9f822a2716f51125370d1997db2ccba/components/test/data/payments/alicepay.com/app1/app.js
[add] https://crrev.com/438d8c97a9f822a2716f51125370d1997db2ccba/components/test/data/payments/alicepay.com/app1/index.html
[add] https://crrev.com/438d8c97a9f822a2716f51125370d1997db2ccba/components/test/data/payments/alicepay.com/app1/index.js
[add] https://crrev.com/438d8c97a9f822a2716f51125370d1997db2ccba/components/test/data/payments/alicepay.com/app2/app.js
[add] https://crrev.com/438d8c97a9f822a2716f51125370d1997db2ccba/components/test/data/payments/alicepay.com/app2/index.html
[add] https://crrev.com/438d8c97a9f822a2716f51125370d1997db2ccba/components/test/data/payments/alicepay.com/app2/index.js

Sign in to add a comment