New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 774474 link

Starred by 1 user
Status: Assigned
Owner:
█ egdaniel@chromium.org
Last visit > 30 days ago
Cc:
fmalita@chromium.org
reed@google.com
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Suppress focus-ring* layout tests for upcoming Skia roll

Project Member Reported by egdaniel@chromium.org, Oct 13 2017 
The skia roll contains, https://skia-review.googlesource.com/c/skia/+/59084, which changes how the GPU draws hairline lines.

This causes the following layout test to change (and be more correct) 

* virtual/gpu-rasterization/images/imagemap-focus-ring-in-positioned-container.html
* virtual/gpu-rasterization/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map.html
* virtual/gpu-rasterization/images/imagemap-focus-ring-outline-color-not-inherited-from-map.html
* virtual/gpu-rasterization/images/imagemap-focus-ring-outline-color.html
* virtual/gpu-rasterization/images/imagemap-focus-ring-with-paint-root-offset.html
* virtual/gpu-rasterization/images/imagemap-focus-ring.html
* virtual/gpu-rasterization/images/imagemap-overflowing-polygon-focus-ring.html
* virtual/gpu-rasterization/images/imagemap-polygon-focus-ring.html
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac97fd5c4a120812ddb3673f32357afb2f48098b

commit ac97fd5c4a120812ddb3673f32357afb2f48098b
Author: Greg Daniel <egdaniel@chromium.org>
Date: Fri Oct 13 14:46:46 2017

Suppress gpu focus-ring* layout tests for upcoming Skia roll

Bug: 774474
Change-Id: Ie91bd3f3e750344cc217893ac9025315df87c6ab
Reviewed-on: https://chromium-review.googlesource.com/718817
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Greg Daniel <egdaniel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508697}
[modify] https://crrev.com/ac97fd5c4a120812ddb3673f32357afb2f48098b/third_party/WebKit/LayoutTests/TestExpectations
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9790903105941dfc7a00280537835a3dd806ec46

commit 9790903105941dfc7a00280537835a3dd806ec46
Author: Greg Daniel <egdaniel@chromium.org>
Date: Wed Oct 25 15:39:43 2017

Remove focus ring suppressions from Skia roll

Bug: 774474
Change-Id: I658d17edd3b4df4f54c5a580bbdcac89a1717efb
Reviewed-on: https://chromium-review.googlesource.com/735841
Commit-Queue: Greg Daniel <egdaniel@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511473}
[modify] https://crrev.com/9790903105941dfc7a00280537835a3dd806ec46/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/9790903105941dfc7a00280537835a3dd806ec46/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/imagemap-focus-ring-expected.png
[modify] https://crrev.com/9790903105941dfc7a00280537835a3dd806ec46/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/imagemap-focus-ring-in-positioned-container-expected.png
[modify] https://crrev.com/9790903105941dfc7a00280537835a3dd806ec46/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/imagemap-focus-ring-outline-color-expected.png
[modify] https://crrev.com/9790903105941dfc7a00280537835a3dd806ec46/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.png
[modify] https://crrev.com/9790903105941dfc7a00280537835a3dd806ec46/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.png
[modify] https://crrev.com/9790903105941dfc7a00280537835a3dd806ec46/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/imagemap-focus-ring-with-paint-root-offset-expected.png
[modify] https://crrev.com/9790903105941dfc7a00280537835a3dd806ec46/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/imagemap-overflowing-polygon-focus-ring-expected.png
[modify] https://crrev.com/9790903105941dfc7a00280537835a3dd806ec46/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/imagemap-polygon-focus-ring-expected.png
[modify] https://crrev.com/9790903105941dfc7a00280537835a3dd806ec46/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/imagemap-focus-ring-expected.png
[modify] https://crrev.com/9790903105941dfc7a00280537835a3dd806ec46/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/imagemap-focus-ring-in-positioned-container-expected.png
[modify] https://crrev.com/9790903105941dfc7a00280537835a3dd806ec46/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/imagemap-focus-ring-outline-color-expected.png
[modify] https://crrev.com/9790903105941dfc7a00280537835a3dd806ec46/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.png
[modify] https://crrev.com/9790903105941dfc7a00280537835a3dd806ec46/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.png
[modify] https://crrev.com/9790903105941dfc7a00280537835a3dd806ec46/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/imagemap-focus-ring-with-paint-root-offset-expected.png
[modify] https://crrev.com/9790903105941dfc7a00280537835a3dd806ec46/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/imagemap-overflowing-polygon-focus-ring-expected.png
[modify] https://crrev.com/9790903105941dfc7a00280537835a3dd806ec46/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/imagemap-polygon-focus-ring-expected.png

Comment 3 by benhenry@chromium.org, Aug 1

Status: Assigned (was: Untriaged)
►

Sign in to add a comment