New issue
Advanced search Search tips

Issue 774459 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

Inbox won't load in 32 bit builds

Project Member Reported by siggi@chromium.org, Oct 13 2017

Issue description

Inbox doesn't finish loading. While the page becomes UI responsive and the message list loads, it's not possible to open messages. Clicking on UI widgets -
 like folders - changes the navigation URL, but navigation does not take place.

Prudhvi has bisected this to between Chrome version 63.0.3236.3 and 63.0.3237.8.
 

Comment 1 Deleted

Comment 2 by siggi@chromium.org, Oct 13 2017

A local, non-instrumented SyzyASAN build behaves the same way, so this is apparently not an instrumentation problem. Has to be Albatross, somehow.

Comment 3 by siggi@chromium.org, Oct 13 2017

Build 63.0.3239.1 behaves the same way.

Comment 4 by siggi@chromium.org, Oct 13 2017

Hmm, so this is a 32 bit build anomaly. I installed Version 63.0.3239.0 (Official Build) canary (32-bit), and the problem repros there too. The 64 bit version is fine.

Comment 5 by siggi@chromium.org, Oct 13 2017

Summary: Inbox won't load in 32 bit builds (was: Inbox won't load in SyzyASAN builds)

Comment 6 by siggi@chromium.org, Oct 13 2017

Labels: ReleaseBlock-Dev
Owner: pbomm...@chromium.org
Status: Assigned (was: Started)
Assigning to Prudhvi for bisecting, as this isn't a SyzyASAN problem - this seems to affect 32 bit builds of Chrome on Windows at least.
Cc: georgesak@chromium.org

Comment 8 by siggi@chromium.org, Oct 13 2017

Labels: M-63

Comment 9 by siggi@chromium.org, Oct 13 2017

Cc: -syzygy-team@chromium.org
-syzygy-team as this is not a Syzygy problem
Cc: bmeu...@chromium.org gov...@chromium.org
Components: Blink>JavaScript
Owner: ----
Status: Available (was: Assigned)
Please find the bisect range :

You are probably looking for a change made after 507351 (known good), but no later than 507358 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/d333bed7476464825f8dbbb2ab5dcd01d690de15..4c48b5daa096160b7ef0a3cd6674d082fa3e9d2d

suspected CL(Very unknowledgeable guess) : https://chromium.googlesource.com/v8/v8/+/1aa09302a08bb01e486e4c274abc39769bb61076


Note : Some reason I wasn't able to perform the per-cl bisect for Chrome 32 due to some script issues will check that in a bit.

Comment 11 by siggi@chromium.org, Oct 13 2017

Running the browser with --js-flags="--noopt" allows Inbox to load as usual, though maybe even slower than usual. I'm rebuilding with V8 backed up to before the suspected CL to confirm, but this'll take an hour or two.

Comment 12 by siggi@chromium.org, Oct 13 2017

Owner: jkummerow@chromium.org
Jakob has kindly offered to try and revert the offending CL today.
Status: Assigned (was: Available)
Please revert the CL ASAP, we are branching M63 today.
Please request a merge to M63 once revert is landed/baked in Canary.

Comment 15 by siggi@chromium.org, Oct 13 2017

Yups, if I back V8 up to before https://chromium.googlesource.com/v8/v8/+/1aa09302a08bb01e486e4c274abc39769bb61076, Inbox loads just fine in a 32 bit build.
Cc: hablich@chromium.org

Comment 17 by siggi@chromium.org, Oct 13 2017

And if I patch https://chromium.googlesource.com/v8/v8/+/1aa09302a08bb01e486e4c274abc39769bb61076 back into my working release build, it's horked again. It's the one(TM).
Stopgap fix in flight: https://chromium-review.googlesource.com/c/v8/v8/+/719461

(Reverting is very difficult due to follow-up changes.)
Project Member

Comment 19 by bugdroid1@chromium.org, Oct 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/a3de183f705dc4c4e4a13c03910db5a4d84f1a22

commit a3de183f705dc4c4e4a13c03910db5a4d84f1a22
Author: Jakob Kummerow <jkummerow@chromium.org>
Date: Fri Oct 13 19:30:03 2017

[turbofan] Turn off lowering to kFindOrderedHashMapEntryForInt32Key.

As a simple and backmergeable fix for  crbug.com/774459 .

Bug:  chromium:774459 
Tbr: bmeurer@chromium.org
Change-Id: Ibe55ad13fe6be63a76dc3079a0288356ce35de9f
Reviewed-on: https://chromium-review.googlesource.com/719461
Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#48561}
[modify] https://crrev.com/a3de183f705dc4c4e4a13c03910db5a4d84f1a22/src/compiler/simplified-lowering.cc

Status: Fixed (was: Assigned)
Closing this, as the user-visible problem is mitigated.

I assume Benedikt has solving the actual underlying bug on his radar ;-)

The patch is conservative enough that we could back-merge immediately, but we can also wait for Canary coverage.
Pls request a merge to M63 after if change looks good in canary.

Comment 22 by siggi@chromium.org, Oct 17 2017

Inbox is loading again for me in "Version 64.0.3242.0 (Official Build) canary (32-bit)"

Comment 23 by siggi@chromium.org, Oct 17 2017

Also loads in Version 64.0.3242.1 (Official Build) canary SyzyASan (32-bit), even with chrome://flags/#dcheck-is-fatal Enabled.

Labels: Merge-Request-63
Labels: -Merge-Request-63 Merge-Approved-63
Approving merge to M63 branch 3239 based on comment #22 & #23. 
Project Member

Comment 26 by bugdroid1@chromium.org, Oct 17 2017

Labels: merge-merged-6.3
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/e415875d1a485ba06f467d28bbb0c11ec3d250b5

commit e415875d1a485ba06f467d28bbb0c11ec3d250b5
Author: Jakob Kummerow <jkummerow@chromium.org>
Date: Tue Oct 17 20:15:04 2017

Merged: [turbofan] Turn off lowering to kFindOrderedHashMapEntryForInt32Key.

Revision: a3de183f705dc4c4e4a13c03910db5a4d84f1a22

BUG= chromium:774459 
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
R=cbruni@chromium.org

Change-Id: Ia785eaaa6effe18f31ec59fdb9544ffc36b5195f
Reviewed-on: https://chromium-review.googlesource.com/723593
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/branch-heads/6.3@{#20}
Cr-Branched-From: 094a7c93dcdcd921de3883ba4674b7e1a0feffbe-refs/heads/6.3.292@{#1}
Cr-Branched-From: 18b8fbb528a8021e04a029e06eafee50b918bce0-refs/heads/master@{#48432}
[modify] https://crrev.com/e415875d1a485ba06f467d28bbb0c11ec3d250b5/src/compiler/simplified-lowering.cc

Labels: -Merge-Approved-63
All done here.

Sign in to add a comment