TargetDomainDisposeContextFailsIfInUse flakily crashes |
||||
Issue descriptionBuild target: headless_browsertests Test name: TargetDomainDisposeContextFailsIfInUse.RunAsyncTest Platforms: all desktop Symptom: test flakily crashes (on shutdown, I think) Example failure log: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.linux%2FLinux_Tests__dbg__1_%2F67397%2F%2B%2Frecipes%2Fsteps%2Fheadless_browsertests%2F0%2Flogs%2FTargetDomainDisposeContextFailsIfInUse.RunAsyncTest%2F0 BrowserTestBase received signal: Segmentation fault. Backtrace: #0 0x7f0cafdeedbd base::debug::StackTrace::StackTrace() #1 0x7f0cafded1ec base::debug::StackTrace::StackTrace() #2 0x0000012ddf8f content::(anonymous namespace)::DumpStackTraceSignalHandler() #3 0x7f0c9e0b3cb0 <unknown> #4 0x7f0caf552dcc headless::HeadlessBrowserContextImpl::ShouldRemoveHeaders() #5 0x7f0caf598248 headless::HeadlessNetworkDelegate::OnBeforeURLRequest() #6 0x7f0cae9ba61e net::NetworkDelegate::NotifyBeforeURLRequest() #7 0x7f0caf1b73fc net::URLRequest::Start() #8 0x7f0caafbeedb content::ResourceLoader::StartRequestInternal() #9 0x7f0caafbe70f content::ResourceLoader::Resume() #10 0x7f0caafc0e15 content::ResourceLoader::ScopedDeferral::~ScopedDeferral() #11 0x7f0caafb86a1 content::ResourceLoader::StartRequest() #12 0x7f0caafa1c2f content::ResourceDispatcherHostImpl::StartLoading() #13 0x7f0caaf96ccc content::ResourceDispatcherHostImpl::BeginRequestInternal() #14 0x7f0caafa0c14 content::ResourceDispatcherHostImpl::BeginNavigationRequest() #15 0x7f0caaf6b754 content::NavigationURLLoaderImplCore::Start() #16 0x7f0caaf6a811 _ZN4base8internal13FunctorTraitsIMN7content27NavigationURLLoaderImplCoreEFvPNS2_15ResourceContextEPN3net23URLRequestContextGetterEPN7storage17FileSystemContextEPNS2_33ServiceWorkerNavigationHandleCoreEPNS2_28AppCacheNavigationHandleCoreENSt3__110unique_ptrINS2_21NavigationRequestInfoENSG_14default_deleteISI_EEEENSH_INS2_16NavigationUIDataENSJ_ISM_EEEEEvE6InvokeI13scoped_refptrIS3_EJS5_S8_SB_SD_SF_SL_SO_EEEvSQ_OT_DpOT0_ #17 0x7f0caaf6a3c6 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIMN7content27NavigationURLLoaderImplCoreEFvPNS4_15ResourceContextEPN3net23URLRequestContextGetterEPN7storage17FileSystemContextEPNS4_33ServiceWorkerNavigationHandleCoreEPNS4_28AppCacheNavigationHandleCoreENSt3__110unique_ptrINS4_21NavigationRequestInfoENSI_14default_deleteISK_EEEENSJ_INS4_16NavigationUIDataENSL_ISO_EEEEEJ13scoped_refptrIS5_ES7_SA_SD_SF_SH_SN_SQ_EEEvOT_DpOT0_ #18 0x7f0caaf6a09f _ZN4base8internal7InvokerINS0_9BindStateIMN7content27NavigationURLLoaderImplCoreEFvPNS3_15ResourceContextEPN3net23URLRequestContextGetterEPN7storage17FileSystemContextEPNS3_33ServiceWorkerNavigationHandleCoreEPNS3_28AppCacheNavigationHandleCoreENSt3__110unique_ptrINS3_21NavigationRequestInfoENSH_14default_deleteISJ_EEEENSI_INS3_16NavigationUIDataENSK_ISN_EEEEEJ13scoped_refptrIS4_ES6_S9_NS0_17UnretainedWrapperISB_EESE_SG_NS0_13PassedWrapperISM_EENSW_ISP_EEEEEFvvEE7RunImplISR_NSH_5tupleIJST_S6_S9_SV_SE_SG_SX_SY_EEEJLm0ELm1ELm2ELm3ELm4ELm5ELm6ELm7EEEEvOT_OT0_NSH_16integer_sequenceImJXspT1_EEEE #19 0x7f0caaf69d29 _ZN4base8internal7InvokerINS0_9BindStateIMN7content27NavigationURLLoaderImplCoreEFvPNS3_15ResourceContextEPN3net23URLRequestContextGetterEPN7storage17FileSystemContextEPNS3_33ServiceWorkerNavigationHandleCoreEPNS3_28AppCacheNavigationHandleCoreENSt3__110unique_ptrINS3_21NavigationRequestInfoENSH_14default_deleteISJ_EEEENSI_INS3_16NavigationUIDataENSK_ISN_EEEEEJ13scoped_refptrIS4_ES6_S9_NS0_17UnretainedWrapperISB_EESE_SG_NS0_13PassedWrapperISM_EENSW_ISP_EEEEEFvvEE7RunOnceEPNS0_13BindStateBaseE #20 0x7f0cafd9dfb1 _ZNO4base12OnceCallbackIFvvEE3RunEv #21 0x7f0cafdf30ba base::debug::TaskAnnotator::RunTask() #22 0x7f0cafe928c5 base::internal::IncomingTaskQueue::RunTask() #23 0x7f0cafe9b6e4 base::MessageLoop::RunTask() #24 0x7f0cafe9b986 base::MessageLoop::DeferOrRunPendingTask() #25 0x7f0cafe9bcd3 base::MessageLoop::DoWork() #26 0x7f0cafea1ac9 base::MessagePumpLibevent::Run() #27 0x7f0cafe9ae84 base::MessageLoop::Run() #28 0x7f0caff448c5 base::RunLoop::Run() #29 0x7f0cb0006484 base::Thread::Run() #30 0x7f0caa903cc6 content::BrowserThreadImpl::IOThreadRun() #31 0x7f0caa903fcb content::BrowserThreadImpl::Run() #32 0x7f0cb00070a4 base::Thread::ThreadMain() #33 0x7f0caffec8c1 base::(anonymous namespace)::ThreadFunc() #34 0x7f0cb0191184 start_thread #35 0x7f0c9e17affd clone
,
Oct 13 2017
Alex, could you please triage?
,
Oct 16 2017
Looks like a lifetime issue, probably due to a missing lock in HeadlessNetworkDelegate::OnBeforeURLRequest. I'll send a patch to add it and hopefully the flakes will go away.
,
Oct 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7a9777223774930b2cb8158dc669051298ea277e commit 7a9777223774930b2cb8158dc669051298ea277e Author: Alex Clarke <alexclarke@chromium.org> Date: Mon Oct 16 14:35:42 2017 Reenable TargetDomainDisposeContextFailsIfInUse The flakiness seems to be caused by a missing lock. Bug: 774443 Change-Id: Ie6227e5f10225569f9a0017f354f4d05c67a5f0e Reviewed-on: https://chromium-review.googlesource.com/721080 Reviewed-by: Alexander Timin <altimin@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#509041} [modify] https://crrev.com/7a9777223774930b2cb8158dc669051298ea277e/headless/lib/browser/headless_network_delegate.cc [modify] https://crrev.com/7a9777223774930b2cb8158dc669051298ea277e/headless/lib/headless_devtools_client_browsertest.cc
,
Oct 16 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Oct 13 2017