paint/invalidation/selection-partial-invalidation-between-blocks.html is flaky on Win10 |
|||||||
Issue descriptionOn WebKit Win10 builder, layout test paint/invalidation/selection-partial-invalidation-between-blocks.html is 50% flaky. I think the flakiness started here: https://chromium.googlesource.com/chromium/src/+/a56445999783667165dabe5ed082b2cec00247a7 https://luci-milo.appspot.com/buildbot/chromium.webkit/WebKit%20Win10/26581
,
Oct 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e2e292a6ab48ab7bf3381567ad261d84419b5409 commit e2e292a6ab48ab7bf3381567ad261d84419b5409 Author: tmartino <tmartino@chromium.org> Date: Fri Oct 13 22:21:17 2017 Marking flaky: selection-partial-invalidation... This test was labeled as possibly failing on Win10 earlier today: paint/invalidation/selection-partial-invalidation-between-blocks.html We're seeing failures on other platforms, so I'm removing the platform specifier. TBR=yosin@chromium.org,wangxianzhu@chromium.org,yoichio@chromium.org,wkorman@chromium.org,xiaochengh@chromium.org Bug: 774437 Change-Id: I63078d0dfa296be5cc6769d9436e1209e195fc3e Reviewed-on: https://chromium-review.googlesource.com/719721 Commit-Queue: Tommy Martino <tmartino@chromium.org> Reviewed-by: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#508844} [modify] https://crrev.com/e2e292a6ab48ab7bf3381567ad261d84419b5409/third_party/WebKit/LayoutTests/TestExpectations
,
Oct 16 2017
,
Jan 10 2018
,
Apr 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/881f4954ad3b6a042880984fdb8716a50468cefd commit 881f4954ad3b6a042880984fdb8716a50468cefd Author: Yoichi Osato <yoichio@chromium.org> Date: Thu Apr 26 03:29:17 2018 Fix flaky selection-partial-invalidation-between-blocks.html layout test. This patch wanted to confirm changing selection invalidation between execCommand("selectAll") and Selection.setBaseAndExtent(). However calling execCommand("selectAll") before load is flaky from the point of invalidation. This patch arranges the function calls so that invalidation occurs only on selection difference w/o flakiness. Bug: 774437 Change-Id: I63efe553282f4a6643c0d7b8eb0b0597b1ccac9f Reviewed-on: https://chromium-review.googlesource.com/1025594 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#553892} [modify] https://crrev.com/881f4954ad3b6a042880984fdb8716a50468cefd/third_party/WebKit/LayoutTests/FlagExpectations/disable-blink-features=RootLayerScrolling [modify] https://crrev.com/881f4954ad3b6a042880984fdb8716a50468cefd/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/881f4954ad3b6a042880984fdb8716a50468cefd/third_party/WebKit/LayoutTests/paint/invalidation/selection/selection-partial-invalidation-between-blocks.html [modify] https://crrev.com/881f4954ad3b6a042880984fdb8716a50468cefd/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/selection/selection-partial-invalidation-between-blocks-expected.png [modify] https://crrev.com/881f4954ad3b6a042880984fdb8716a50468cefd/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/selection/selection-partial-invalidation-between-blocks-expected.txt [add] https://crrev.com/881f4954ad3b6a042880984fdb8716a50468cefd/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spv175/paint/invalidation/selection/selection-partial-invalidation-between-blocks-expected.txt [modify] https://crrev.com/881f4954ad3b6a042880984fdb8716a50468cefd/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/selection/selection-partial-invalidation-between-blocks-expected.txt [modify] https://crrev.com/881f4954ad3b6a042880984fdb8716a50468cefd/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/selection/selection-partial-invalidation-between-blocks-expected.txt
,
Apr 26 2018
,
Apr 26 2018
,
Apr 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3184a05536f93d93c4b3b034ce7c95e46ab01e11 commit 3184a05536f93d93c4b3b034ce7c95e46ab01e11 Author: Max Morin <maxmorin@chromium.org> Date: Thu Apr 26 12:54:26 2018 Revert "Fix flaky selection-partial-invalidation-between-blocks.html layout test." This reverts commit 881f4954ad3b6a042880984fdb8716a50468cefd. Reason for revert: Still flaking: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20%28dbg%29/11967. Log: 05:08:20.784 26556 worker/0 starting 05:08:24.024 26556 worker/0 paint/invalidation/selection/selection-partial-invalidation-between-blocks.html output stderr lines: 05:08:24.024 26556 05:08:24.024 26556 DevTools listening on ws://127.0.0.1:45124/devtools/browser/d84ed017-44ce-4367-a80b-87ccd3e45ee6 05:08:24.026 26556 [1/1] paint/invalidation/selection/selection-partial-invalidation-between-blocks.html failed unexpectedly (text diff) 05:08:24.026 26556 worker/0 paint/invalidation/selection/selection-partial-invalidation-between-blocks.html failed: 05:08:24.026 26556 worker/0 text diff 05:08:24.026 26556 worker/0 killing secondary driver 05:08:24.026 26556 worker/0 exiting 05:08:24.027 26556 worker/0 cleaning up 05:08:24.027 26556 worker/0 killing primary driver 05:08:24.027 26556 killed pid 9941 05:08:24.027 26556 worker/0 killing secondary driver 05:08:24.027 26556 05:08:24.027 26556 Retrying 1 unexpected failure, attempt 3 of 3... 05:08:24.027 26556 Sharding tests ... 05:08:24.027 26556 Starting 1 worker ... 05:08:24.028 26556 worker/0 starting 05:08:27.279 26556 worker/0 paint/invalidation/selection/selection-partial-invalidation-between-blocks.html output stderr lines: 05:08:27.280 26556 05:08:27.280 26556 DevTools listening on ws://127.0.0.1:44074/devtools/browser/ce14587c-4ea1-4a18-87c5-8aee030bcb30 05:08:27.281 26556 [1/1] paint/invalidation/selection/selection-partial-invalidation-between-blocks.html failed unexpectedly (text diff) 05:08:27.281 26556 worker/0 paint/invalidation/selection/selection-partial-invalidation-between-blocks.html failed: 05:08:27.281 26556 worker/0 text diff Original change's description: > Fix flaky selection-partial-invalidation-between-blocks.html layout test. > > This patch wanted to confirm changing selection invalidation > between execCommand("selectAll") and Selection.setBaseAndExtent(). > However calling execCommand("selectAll") before load is flaky from > the point of invalidation. > > This patch arranges the function calls so that invalidation occurs > only on selection difference w/o flakiness. > > Bug: 774437 > Change-Id: I63efe553282f4a6643c0d7b8eb0b0597b1ccac9f > Reviewed-on: https://chromium-review.googlesource.com/1025594 > Commit-Queue: Yoichi Osato <yoichio@chromium.org> > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#553892} TBR=yosin@chromium.org,yoichio@chromium.org,xiaochengh@chromium.org Change-Id: I0e20c1b9212e2777b19b4cec6d1c64e61a3784a6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 774437 Reviewed-on: https://chromium-review.googlesource.com/1030410 Reviewed-by: Max Morin <maxmorin@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#553999} [modify] https://crrev.com/3184a05536f93d93c4b3b034ce7c95e46ab01e11/third_party/WebKit/LayoutTests/FlagExpectations/disable-blink-features=RootLayerScrolling [modify] https://crrev.com/3184a05536f93d93c4b3b034ce7c95e46ab01e11/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/3184a05536f93d93c4b3b034ce7c95e46ab01e11/third_party/WebKit/LayoutTests/paint/invalidation/selection/selection-partial-invalidation-between-blocks.html [modify] https://crrev.com/3184a05536f93d93c4b3b034ce7c95e46ab01e11/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/selection/selection-partial-invalidation-between-blocks-expected.png [modify] https://crrev.com/3184a05536f93d93c4b3b034ce7c95e46ab01e11/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/selection/selection-partial-invalidation-between-blocks-expected.txt [delete] https://crrev.com/f29d2fc24203909ad8eff2e16f8c1d615c9db253/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spv175/paint/invalidation/selection/selection-partial-invalidation-between-blocks-expected.txt [modify] https://crrev.com/3184a05536f93d93c4b3b034ce7c95e46ab01e11/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/selection/selection-partial-invalidation-between-blocks-expected.txt [modify] https://crrev.com/3184a05536f93d93c4b3b034ce7c95e46ab01e11/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/selection/selection-partial-invalidation-between-blocks-expected.txt
,
Apr 27 2018
,
Apr 27 2018
Thank you for reverting. I will refix it.
,
Sep 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7853c572b77feb82912f678abcf7908ff016c4bf commit 7853c572b77feb82912f678abcf7908ff016c4bf Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Fri Sep 07 21:20:28 2018 Rebaseline paint/invalidation/selection/selection-partial-invalidation-between-blocks.html Some failures are caused by changed but valid results instead of the bug. Rebaseline so that we can track real flakiness. TBR=yoichio@chromium.org Bug: 774437 Change-Id: If7f5664902b67700bd18ab70a209cbc160e028d5 Reviewed-on: https://chromium-review.googlesource.com/1213269 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#589663} [modify] https://crrev.com/7853c572b77feb82912f678abcf7908ff016c4bf/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/selection/selection-partial-invalidation-between-blocks-expected.png [modify] https://crrev.com/7853c572b77feb82912f678abcf7908ff016c4bf/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/selection/selection-partial-invalidation-between-blocks-expected.txt [modify] https://crrev.com/7853c572b77feb82912f678abcf7908ff016c4bf/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/selection/selection-partial-invalidation-between-blocks-expected.txt [modify] https://crrev.com/7853c572b77feb82912f678abcf7908ff016c4bf/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/selection/selection-partial-invalidation-between-blocks-expected.txt
,
Sep 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/95a4a5a3ba595151d4eea0292e71b966060ddc41 commit 95a4a5a3ba595151d4eea0292e71b966060ddc41 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Tue Sep 11 18:54:46 2018 Remove flakiness expectation for paint/invalidation/selection/selection-partial-invalidation-between-blocks.html It's no longer flaky: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=paint%2Finvalidation%2Fselection%2Fselection-partial-invalidation-between-blocks.html TBR=yoichio@chromium.org Bug: 774437 Change-Id: I40e82ad1c5cab68d9996961eba44394edf26ed7f Reviewed-on: https://chromium-review.googlesource.com/1220171 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#590423} [modify] https://crrev.com/95a4a5a3ba595151d4eea0292e71b966060ddc41/third_party/WebKit/LayoutTests/TestExpectations
,
Sep 11
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Oct 13 2017