Attaching expected video for reference

Deleted: Expected_PowerwashScreen.mp4 6.2 MB

	Expected_PowerwashScreen.mp4 6.2 MB View Download

This was probably implemented in the  issue 120680 .

It must be regression after that change. I guess this is https://chromium-review.googlesource.com/c/chromium/src/+/603547?

Zach, can you have a look at this

To provider the context, the CL makes TrayBubbleView to always consume key events (if it's opened and not focused) similar to how menu consumes key events.

Any updates?

+Olga for keyboard shortcuts - can you help find a fix here?

the shortcut not working for me at all on M62 beta. 

adding ahmed to triage. 

weidongg, can you please take a look? Thanks!

Actually all accelerator keys registered in WebUILoginView [1] does not work.

Those accelerator keys work before CL in #3 because the focus is always on WebUILoginView's native window, even if you open Uber Tray. But after the CL 
 TrayBubbleView's native window somehow gets the focus. So even if we do not stop propagation [2], the key event will be sent to the focused window.

[1] https://cs.chromium.org/chromium/src/chrome/browser/chromeos/login/ui/webui_login_view.cc?type=cs&sq=package:chromium&l=130
[2] https://cs.chromium.org/chromium/src/ui/views/bubble/tray_bubble_view.cc?dr=C&l=180

I also think it's this CL: https://chromium-review.googlesource.com/c/chromium/src/+/603547?

This is working as intended from the CL point of view. In the CL, we made the tray behave similar to how menu behaves. It consumes all key events while tray is open.

Also Ctrl+Shift+Alt+R doesn't work if tray is activated. For example, if you open a tray with Alt+Shift+S, Ctrl+Shift+Alt+R would not work even without the CL.

omrilio@: Could you confirm what is the expected (intended) behavior here? Or could you reroute this issue to someone to confirm the expected behavior? Thank you!

Accelerator should and does works even with menu opened.
Try ctrl-n /ctrl-f5 with desktop menu opened (and also works with uber tray opened)

To make the accelerator work while system tray is open, it needs to be registered at accelerator controller.

Uploaded a CL at https://crrev.com/c/754253

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/633edfecac687f0d04a0544c15811d9746c7c545

commit 633edfecac687f0d04a0544c15811d9746c7c545
Author: Yuki Awano <yawano@chromium.org>
Date: Wed Nov 15 06:58:25 2017

Register accelerators at accelerator controller

- Register accelerators at global accelerator manager (accelerator
  controller) to make them work while system tray is open.
- Close system tray when status area becomes invisible.

      Confirm that reset screen is shown.

Bug:  774425 
Test: Open system tray at login screen, and press Ctrl+Alt+Shift+R.
Change-Id: I642a6ceee04b721427c9ee7116c78e0f2163b40d
Reviewed-on: https://chromium-review.googlesource.com/754253
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Yuki Awano <yawano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516618}
[modify] https://crrev.com/633edfecac687f0d04a0544c15811d9746c7c545/ash/system/tray/system_tray_controller.cc
[modify] https://crrev.com/633edfecac687f0d04a0544c15811d9746c7c545/chrome/browser/chromeos/login/ui/webui_login_view.cc

Request merge the CL in comment 17 to M63.

This bug requires manual review: M63 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31a6a28b421690ea8bb7826acfb11bd752ca6e68

commit 31a6a28b421690ea8bb7826acfb11bd752ca6e68
Author: Yuki Awano <yawano@chromium.org>
Date: Fri Nov 17 05:12:17 2017

Register accelerators at accelerator controller

- Register accelerators at global accelerator manager (accelerator
  controller) to make them work while system tray is open.
- Close system tray when status area becomes invisible.

      Confirm that reset screen is shown.

Bug:  774425 
Test: Open system tray at login screen, and press Ctrl+Alt+Shift+R.
Change-Id: I642a6ceee04b721427c9ee7116c78e0f2163b40d
Reviewed-on: https://chromium-review.googlesource.com/754253
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Yuki Awano <yawano@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#516618}(cherry picked from commit 633edfecac687f0d04a0544c15811d9746c7c545)
Reviewed-on: https://chromium-review.googlesource.com/776473
Reviewed-by: Yuki Awano <yawano@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#525}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[modify] https://crrev.com/31a6a28b421690ea8bb7826acfb11bd752ca6e68/ash/system/tray/system_tray_controller.cc
[modify] https://crrev.com/31a6a28b421690ea8bb7826acfb11bd752ca6e68/chrome/browser/chromeos/login/ui/webui_login_view.cc

Fix has merged to M63. Mark this as fixed.