FullscreenActivity video touch surface is incorrect when Tab#updateBrowserControlsState does not animate |
|||||||
Issue descriptionYou can try this out by running Chrome with FullscreenActivity enabled, going to a page with video and fullscreening. It seems that the touch events are offset - if you press almost anywhere on the screen the video will pause but if you press on the controls nothing happens. In fact if you press at the very bottom edge of the screen below the controls, you can get touches to register. See video What is stranger is that the back button (which should exit fullscreen) does not work either. This can be fixed by undoing the change to Tab.java in https://chromium-review.googlesource.com/c/chromium/src/+/617922 . This means that the problem is in Tab.updateFullscreenEnabledState, if we call updateBrowserControlsState with animate as false the bug is present, if animate is true everything works fine. I've spent quite a bit of time trying to find the cause of this to no avail, so I'm getting tempted to just set animate to true whenever FullscreenActivity is enabled since the change seems to about efficiency.
,
Nov 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/12da6bcd6b2431a7f0d597bf759cd39538c7e125 commit 12da6bcd6b2431a7f0d597bf759cd39538c7e125 Author: Peter E Conn <peconn@chromium.org> Date: Thu Nov 23 13:14:01 2017 📺 Provide control container height for FullscreenActivity. The bug was caused by the control container height in ChromeFullscreenManager sometimes not updating correctly. For FullscreenActivity the control container height should be 0, although this was not set. Setting the control container height correctly to 0 effectively disables the control container height transition and solves the issue. Bug: 774410 Change-Id: I727cfcf904aa2f4e9ebc9477e9d0598ff827c9cd Reviewed-on: https://chromium-review.googlesource.com/746884 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#518910} [modify] https://crrev.com/12da6bcd6b2431a7f0d597bf759cd39538c7e125/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/12da6bcd6b2431a7f0d597bf759cd39538c7e125/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java [modify] https://crrev.com/12da6bcd6b2431a7f0d597bf759cd39538c7e125/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java [modify] https://crrev.com/12da6bcd6b2431a7f0d597bf759cd39538c7e125/chrome/android/java/src/org/chromium/chrome/browser/FullscreenActivity.java [modify] https://crrev.com/12da6bcd6b2431a7f0d597bf759cd39538c7e125/chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java [modify] https://crrev.com/12da6bcd6b2431a7f0d597bf759cd39538c7e125/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java [modify] https://crrev.com/12da6bcd6b2431a7f0d597bf759cd39538c7e125/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java
,
Nov 23 2017
The above CL fixed the touch surface issue, but the back button is still an issue.
,
Jan 10
This bug had an unsupported status. Updating to Untriaged so someone will reevaluate.
,
Jan 10
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by peconn@chromium.org
, Oct 13 2017