Issue metadata
Sign in to add a comment
|
Regression:Unnecessary blink of Red message[SIM card missing] is seen for Mobile data section of settings page. |
||||||||||||||||||||||
Issue descriptionChrome Version:63.0.3238.0/10028.0.0 dev channel Daisy,Peppy,Blaze,Paine,Falco OS:Chrome OS What steps will reproduce the problem? (1)Sign into user ->Turn off WiFi ->Connect Dongle >> turn on Mobile data (2)Goto chrome://settings page ->click on Mobile data section to open its sub-page and Observe(Kindly refer video) Actual:Unnecessary blink of Red message[SIM card missing] is seen while opening the subpage. Expected No such unnecessary blink of error message should be seen, when SIM card exists. This is a Regression issue as same is working fine in M-62 @stevenjb: Please confirm the issue Note: Issue is not seen in Linux,Windows OS
,
Oct 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/854791c2fac4ad1ad7aa2857ea64933ec6a4341b commit 854791c2fac4ad1ad7aa2857ea64933ec6a4341b Author: Steven Bennetts <stevenjb@chromium.org> Date: Mon Oct 16 17:48:40 2017 Settings > Network > Choose Mobile fixes * Disable 'scan' button while connected * Move 'Scanning...' and 'Scan completed' to secondary text line * Show 'Disconnect to enable scanning' in secondary text when connected (and there is no other scan status). * Hide SIM UI until Cellular properties load to avoid incorrect red 'SIM card missing' text while loading. Bug: 773131 , 774401 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I843fc6efd5f19137a63a1f12a1389e4ee55a9c8f Reviewed-on: https://chromium-review.googlesource.com/716864 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Ben Chan <benchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#509097} [modify] https://crrev.com/854791c2fac4ad1ad7aa2857ea64933ec6a4341b/chrome/app/settings_strings.grdp [modify] https://crrev.com/854791c2fac4ad1ad7aa2857ea64933ec6a4341b/chrome/browser/resources/settings/internet_page/internet_detail_page.js [modify] https://crrev.com/854791c2fac4ad1ad7aa2857ea64933ec6a4341b/chrome/browser/ui/webui/chromeos/network_element_localized_strings_provider.cc [modify] https://crrev.com/854791c2fac4ad1ad7aa2857ea64933ec6a4341b/ui/webui/resources/cr_components/chromeos/network/network_choose_mobile.html [modify] https://crrev.com/854791c2fac4ad1ad7aa2857ea64933ec6a4341b/ui/webui/resources/cr_components/chromeos/network/network_choose_mobile.js [modify] https://crrev.com/854791c2fac4ad1ad7aa2857ea64933ec6a4341b/ui/webui/resources/cr_components/chromeos/network/network_property_list.html [modify] https://crrev.com/854791c2fac4ad1ad7aa2857ea64933ec6a4341b/ui/webui/resources/cr_components/chromeos/network/network_shared_css.html
,
Oct 17 2017
,
Oct 17 2017
This bug requires manual review: There is .grd file changes and we are only 48 days from stable. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 17 2017
It would be possible to merge just the fix for this bug, not the associated UI changes, which would not require the string change. That said, the string in question is auxillary, i.e. it is just providing additional information and does not affect the functionality of the UI which was improved by this CL but not significantly changed (we are disabling a button when clicking it will not have the desired result).
,
Oct 27 2017
,
Oct 30 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7c3ae4a0a6229183afbe338f34aa8aa6154f37fa commit 7c3ae4a0a6229183afbe338f34aa8aa6154f37fa Author: Steven Bennetts <stevenjb@chromium.org> Date: Mon Oct 30 16:37:21 2017 Settings > Network > Choose Mobile fixes * Disable 'scan' button while connected * Move 'Scanning...' and 'Scan completed' to secondary text line * Show 'Disconnect to enable scanning' in secondary text when connected (and there is no other scan status). * Hide SIM UI until Cellular properties load to avoid incorrect red 'SIM card missing' text while loading. TBR=stevenjb@chromium.org (cherry picked from commit 854791c2fac4ad1ad7aa2857ea64933ec6a4341b) Bug: 773131 , 774401 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I843fc6efd5f19137a63a1f12a1389e4ee55a9c8f Reviewed-on: https://chromium-review.googlesource.com/716864 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Ben Chan <benchan@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#509097} Reviewed-on: https://chromium-review.googlesource.com/744181 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#291} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/7c3ae4a0a6229183afbe338f34aa8aa6154f37fa/chrome/app/settings_strings.grdp [modify] https://crrev.com/7c3ae4a0a6229183afbe338f34aa8aa6154f37fa/chrome/browser/resources/settings/internet_page/internet_detail_page.js [modify] https://crrev.com/7c3ae4a0a6229183afbe338f34aa8aa6154f37fa/chrome/browser/ui/webui/chromeos/network_element_localized_strings_provider.cc [modify] https://crrev.com/7c3ae4a0a6229183afbe338f34aa8aa6154f37fa/ui/webui/resources/cr_components/chromeos/network/network_choose_mobile.html [modify] https://crrev.com/7c3ae4a0a6229183afbe338f34aa8aa6154f37fa/ui/webui/resources/cr_components/chromeos/network/network_choose_mobile.js [modify] https://crrev.com/7c3ae4a0a6229183afbe338f34aa8aa6154f37fa/ui/webui/resources/cr_components/chromeos/network/network_property_list.html [modify] https://crrev.com/7c3ae4a0a6229183afbe338f34aa8aa6154f37fa/ui/webui/resources/cr_components/chromeos/network/network_shared_css.html
,
Nov 3 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rkalavakuntla@chromium.org
, Oct 13 2017