New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 774393 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Password is seen misplaced on password bubble.

Reported by db...@etouch.net, Oct 13 2017

Issue description

Chrome Version: 63.0.3239.0 Revision adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}(64bit)
OS: Mac(10.12.6)

What steps will reproduce the problem?
(1) Launch chrome, navigate to gmail.com and sign in with valid credentials.
(2) Observe on password field on password bubble.

Actual: Password is seen misplaced i.e. shift upwards on bubble.

Expected: Password should seen properly.

This is a regression issue, broken in 'M-63', will soon update the other info:

Good Build: 63.0.3238.0
Bad Build: 63.0.3239.0

Note: Issue is not seen on Windows and Linux OS.
 
 
Actual_Password.mov
3.6 MB Download
Expected_password.mov
3.8 MB Download

Comment 1 by battre@chromium.org, Oct 13 2017

Owner: vasi...@chromium.org
Status: Assigned (was: Unconfirmed)

Comment 2 by db...@etouch.net, Oct 13 2017

Labels: hasbisect-per-revision
You are probably looking for a change made after 508391 (known good), but no later than 508392 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/a0f98cc9956e6a634c846d2450fa68bbfd3769da..f3107632464a2d623fa58c2476ab324ef2be71bd

Suspect:https://chromium.googlesource.com/chromium/src/+/f3107632464a2d623fa58c2476ab324ef2be71bd
 
Labels: ReleaseBlock-Stable
Tagging with blocker label, please undo if not the case.

Thanks.!
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f8924b5487b82919c3f4c9892764124044405b8

commit 4f8924b5487b82919c3f4c9892764124044405b8
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Fri Oct 13 15:45:08 2017

Align password vertically in the save bubble on Mac.

In the edit mode it should be center aligned with the "password" label. In the view mode they are
top aligned.

Bug:  774393 
Change-Id: I27288ca3069f9609ab03b46aba8b28a95e9da451
Reviewed-on: https://chromium-review.googlesource.com/718858
Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508710}
[modify] https://crrev.com/4f8924b5487b82919c3f4c9892764124044405b8/chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller.mm

Labels: Merge-Request-63
I want to merge r508710. It's a safe UI polishing CL, no risk.
Project Member

Comment 6 by sheriffbot@chromium.org, Oct 17 2017

Labels: -Merge-Request-63 Hotlist-Merge-Approved Merge-Approved-63
Your change meets the bar and is auto-approved for M63. Please go ahead and merge the CL to branch 3239 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a94ae07b192cdabece086008d6617716cfbee229

commit a94ae07b192cdabece086008d6617716cfbee229
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Tue Oct 17 12:57:50 2017

Correctly vertically align the combobox in the save password dialog.

This is a follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/718858.
The combobox should be center-aligned with the label like it used to be. Only the static password
label is top-aligned.

Bug:  774393 , 774962 
Change-Id: Id4fe1bf3a93d30f2d9748978afb91df08929726c
Reviewed-on: https://chromium-review.googlesource.com/723139
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Tatiana Gornak <melandory@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509370}
[modify] https://crrev.com/a94ae07b192cdabece086008d6617716cfbee229/chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller.mm

Project Member

Comment 8 by bugdroid1@chromium.org, Oct 17 2017

Labels: -merge-approved-63 merge-merged-3239
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb668d67f68259044b61191b7f87d21e26c0f292

commit eb668d67f68259044b61191b7f87d21e26c0f292
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Tue Oct 17 13:44:20 2017

Align password vertically in the save bubble on Mac.

In the edit mode it should be center aligned with the "password" label. In the view mode they are
top aligned.

(cherry picked from commit 4f8924b5487b82919c3f4c9892764124044405b8)

Bug:  774393 
Change-Id: I27288ca3069f9609ab03b46aba8b28a95e9da451
Reviewed-on: https://chromium-review.googlesource.com/718858
Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#508710}
Reviewed-on: https://chromium-review.googlesource.com/723381
Reviewed-by: Tatiana Gornak <melandory@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#29}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[modify] https://crrev.com/eb668d67f68259044b61191b7f87d21e26c0f292/chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller.mm

Status: Fixed (was: Assigned)

Comment 10 by db...@etouch.net, Oct 18 2017

Labels: TE-Verified-M63 TE-Verified-63.0.3239.0
Just to update:

Above issue is fixed on latest chrome Dev 63.0.3239.9

Thank you.
Labels: TE-Verified-M64 TE-Verified-64.0.3243.0
Just to update:

Above issue is fixed on latest chrome Canary 64.0.3243.0

Thank you
Current_Result.mov
3.8 MB Download

Sign in to add a comment