New issue
Advanced search Search tips

Issue 774392 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug
Team-Security-UX


Show other hotlists

Hotlists containing this issue:
EnamelAndFriendsFixIt


Sign in to add a comment

"Learn more" link on bad clock interstitial doesn't do anything

Reported by baranov...@yandex-team.ru, Oct 13 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.113 YaBrowser/17.9.1.787 (beta) Yowser/2.5 Safari/537.36

Steps to reproduce the problem:
1. set up wrong clock
2. go to https://expired.badssl.com
3. click `learn more` link

What is the expected behavior?
some help page is opened or link does not exist

What went wrong?
nothing happens

Did this work before? N/A 

Chrome version: 60.0.3112.113  Channel: stable
OS Version: OS X 10.12.6
Flash Version: Shockwave Flash 27.0 r0

in debug build it will be NOTREACHED, since BadClockUI::HandleCommand does not handle CMD_OPEN_HELP_CENTER, but uses the same text resource as all interstitials do (with link)
 

Comment 1 Deleted

Cc: est...@chromium.org
Status: Untriaged (was: Unconfirmed)
Oh, my mistake, I missed step #1, meaning I was just getting the normal Certificate Date Invalid intersitital.

https://cs.chromium.org/chromium/src/components/security_interstitials/core/bad_clock_ui.cc?l=114&rcl=65e1b24a78b29b21efe8f14cadc4caf1781f5503
Cc: carlosil@chromium.org
Notably, even if this link did work, the topic probably wouldn't load due to the bad clock. So maybe we should remove the link until we have HTTP-accessible help?

Comment 4 by est...@chromium.org, Oct 13 2017

Cc: cthomp@chromium.org
Labels: M-64 OS-Android OS-Chrome OS-Linux OS-Windows
Status: Available (was: Untriaged)
I'd be fine with removing the link for now, that seems reasonable. cthomp, this would be a great starter bug if you want to pick it up.

Comment 5 by est...@chromium.org, Nov 10 2017

Labels: Hotlist-EnamelAndFriendsFixIt

Comment 6 by est...@chromium.org, Nov 15 2017

Owner: est...@chromium.org
Status: Started (was: Available)
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3033545ff102ccd0db3231cfd50ada79a3d7aec0

commit 3033545ff102ccd0db3231cfd50ada79a3d7aec0
Author: Emily Stark <estark@google.com>
Date: Wed Nov 15 02:10:30 2017

Remove non-working Learn More links from bad clock interstitial

These links have never worked, and even if we made them work, there's a good
chance they'd just lead the user to another error page due to their bad clock.

Bug:  774392 
Change-Id: If1955759dc4d70d5209176213ff13e967969c1b2
Reviewed-on: https://chromium-review.googlesource.com/770144
Reviewed-by: Lucas Garron <lgarron@chromium.org>
Commit-Queue: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516561}
[modify] https://crrev.com/3033545ff102ccd0db3231cfd50ada79a3d7aec0/components/security_interstitials_strings.grdp

Comment 8 by est...@chromium.org, Nov 15 2017

Status: Fixed (was: Started)
Labels: TE-Verified-M64 TE-Verified-64.0.3270.0
Tested this issue on Windows 7, Mac 10.12.6 & Ubuntu 14.04 using chrome# 64.0.3270.0 as per C#0 & C#7.

'Learn more' link is not available in the below URL when system clock is set wrong.

As it is working as intended, adding TE- Verified labels.

Please find the attached screencast for reference.

Thanks..!

774392-Win.mp4
715 KB View Download
Android: Works fine as per expected Behavior, Issue Verified on 64.0.3273.0

Sign in to add a comment