[Bling Bookmarks] Remove the extra stroke below promo card |
||||||
Issue descriptionPrecondition: 1. Go to chrome://flags --> Bookmark New Generation iOS : Enabled 2. Without signed-in google account. Steps to reproduce: 1. Launch chrome 2. Go to Menu --> Bookmarks. There is a stroke below the promo card and above Mobile Bookmarks. We should remove that stroke per UI review request. (see attachment)
,
Oct 18 2017
,
Oct 18 2017
By looking at the screenshots in Photoshop: - The color of row separator in new bookmarks is #bcbbc1 - The color of row separator in reading list, history, settings is #d9d9d9 When I fix this bug, I will make sure the separator color is correct (#d9d9d9)
,
Oct 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3668becccfd3803a2b0bceb129bfef0ff08007e1 commit 3668becccfd3803a2b0bceb129bfef0ff08007e1 Author: Marti Wong <martiw@chromium.org> Date: Wed Oct 18 16:20:49 2017 Remove the unwanted stroke below promo card (new iOS bookmark ui) Introduce a custom separator for the new bookmark table cell, so that we don't show a separator under promo section. screenshot: https://drive.google.com/file/d/0B1dtd3IUt4I7WERlaWVlR0N4cUE Bug: 774388 Change-Id: I5edcd199fd3daa3b055769873d8983918cb6310e Reviewed-on: https://chromium-review.googlesource.com/725128 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#509783} [modify] https://crrev.com/3668becccfd3803a2b0bceb129bfef0ff08007e1/ios/chrome/browser/ui/bookmarks/bookmark_table_view.mm [modify] https://crrev.com/3668becccfd3803a2b0bceb129bfef0ff08007e1/ios/chrome/browser/ui/bookmarks/cells/bookmark_table_cell.mm
,
Oct 19 2017
,
Oct 20 2017
Your change meets the bar and is auto-approved for M63. Please go ahead and merge the CL to branch 3239 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4e1095d23478de0420ed5764fb0bde799b4bf2db commit 4e1095d23478de0420ed5764fb0bde799b4bf2db Author: Marti Wong <martiw@chromium.org> Date: Sat Oct 21 04:20:31 2017 Remove the unwanted stroke below promo card (new iOS bookmark ui) Introduce a custom separator for the new bookmark table cell, so that we don't show a separator under promo section. screenshot: https://drive.google.com/file/d/0B1dtd3IUt4I7WERlaWVlR0N4cUE Bug: 774388 Change-Id: I5edcd199fd3daa3b055769873d8983918cb6310e Reviewed-on: https://chromium-review.googlesource.com/725128 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#509783}(cherry picked from commit 3668becccfd3803a2b0bceb129bfef0ff08007e1) Reviewed-on: https://chromium-review.googlesource.com/732123 Reviewed-by: Marti Wong <martiw@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#133} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/4e1095d23478de0420ed5764fb0bde799b4bf2db/ios/chrome/browser/ui/bookmarks/bookmark_table_view.mm [modify] https://crrev.com/4e1095d23478de0420ed5764fb0bde799b4bf2db/ios/chrome/browser/ui/bookmarks/cells/bookmark_table_cell.mm
,
Oct 24 2017
Verified on M64.0.3248.0 canary iOS: 10.3.3, 11.0 Device: iPhone6, iPad Air2 Extra stroke is now removed. Screenshot: https://drive.google.com/file/d/0B-xmXLQhjeKuSFpCX1lIbWJUMDQ/view
,
Oct 25 2017
Verified the issue on the build 63.0.3239.17 beta tested on iPad(10.3.3). Extra stroke is now removed. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by martiw@chromium.org
, Oct 13 2017