New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 774383 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

internal display goes blank when external monitor is connected on kevin/bob since R63-9991

Project Member Reported by uekawa@google.com, Oct 13 2017

Issue description

ToT canary, at least since r63-10000.0.0 on kevin.
last good one I know of: R63-9979.0.0

mirror / extended display mode.
Actually, I cannot click on anything on extended display except for the menu
(and internal display is blank so I can't see half of the things).

bisecting.

 

Comment 1 by uekawa@google.com, Oct 13 2017

Narrowing down to between 9995 (good) and 10000 (bad).


Comment 2 by uekawa@google.com, Oct 13 2017

actually, 9995 seems to be very unstable I can't really tell what's going on.

Comment 3 by uekawa@google.com, Oct 16 2017

I think I got it down to 9995 is bad and 9989 is good.

Comment 4 by uekawa@google.com, Oct 17 2017

R63-9991.0.0 is the first bad, R63-9990.0.0 is the last good.

I believe the changes are:

https://chromium.googlesource.com/chromium/src/+log/63.0.3223.0..63.0.3228.0?pretty=fuller&n=10000
https://crosland.corp.google.com/log/9990.0.0..9991.0.0

There's little Chrome OS changes but unfortunately it's a large chrome uprev jump.

Comment 5 by uekawa@google.com, Oct 17 2017

Labels: M-63
Summary: internal display goes blank when external monitor is connected on kevin/bob since R63-9991 (was: internal display goes blank when external monitor is connected on kevin)
reproduced on bob 64 10041.0.0 too, but kevin and bob are very similar.

Comment 6 by uekawa@google.com, Oct 17 2017

Owner: osh...@chromium.org
bisected chrome, and this seems to be the CL that caused the problem.


commit 115ac3528d0a279b55f5ec5ae82a872db9da3911 (HEAD)
Author: Mitsuru Oshima <oshima@chromium.org>
Date:   Wed Sep 27 03:21:33 2017 +0000

    Generate DispayInfo for disconnected internal display
    
    DisplayManager knows if the device has internal display, but
    didn't populate the ManagedDisplayInfo if it's not connected
    already.
    
     logout in doced mode. The scale used for ARC++ should be correct.
    
    Bug: 66227368
    Test: Covered by unit tests. Also tested on device.
    Change-Id: Ifdf2b0d00b63d3aeef008882ca1e01a500cb9a9d
    Reviewed-on: https://chromium-review.googlesource.com/683233
    Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
    Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#504571}

Comment 7 by uekawa@google.com, Oct 17 2017

Labels: -Pri-3 Pri-1

Comment 8 by uekawa@google.com, Oct 17 2017

Labels: ReleaseBlock-Stable ReleaseBlock-Beta M-62
hmm.. I see this change was cherry-picked to M62. Does M62 work with this patched in? 
b/66227368

Adding some tags.

Project Member

Comment 9 by sheriffbot@chromium.org, Oct 17 2017

This issue is marked as a release blocker with no OS labels associated. Please add an appropriate OS label.

All release blocking issues should have OS labels associated to it, so that the issue can tracked and promptly verified, once it gets fixed.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Please add appropriate OSs.

Comment 11 by uekawa@google.com, Oct 17 2017

Labels: OS-Chrome
Cc: kylec...@chromium.org
kylechar@, I noticed that the native bounds of the internal display changes when external display is connected on kevin (but not on carioline)

[0, 0, 2400x1600] single 
to
[0, 1260 2400x1600] dual

Is this expected?

Labels: -ReleaseBlock-Beta
Does this actually happen on 62?

And does this happen only on RK3399 systems?

External display is working fine for me on a samus running 10001...

The CL is already in the current live beta, so we have no reason to block 62 beta based on this, another update will not make it worse, but if this is happening we need it fixed before stable, if we don't have a fix by tomorrow afternoon we should revert the CL.
Is this different than  bug #774668 ?
Cc: dcasta...@chromium.org diand...@chromium.org ka...@chromium.org matthewjoseph@chromium.org hoegsberg@chromium.org sontis@chromium.org marc...@chromium.org conradlo@chromium.org
 Issue 774668  has been merged into this issue.
The symptom in #12 seems to be board specific, and can happen in 62.
CL is under review now: https://chromium-review.googlesource.com/c/chromium/src/+/726262
Project Member

Comment 17 by bugdroid1@chromium.org, Oct 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca1309e1130def3f01b093f53e083258ea214e78

commit ca1309e1130def3f01b093f53e083258ea214e78
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Thu Oct 19 22:10:07 2017

Do not re-register dislay info if exists

UpdateInternalDisplay should register the display info
only if
1) no internal display info  is registered. (it'll be
  treated as new display)
2) it's disconnected

BUG= 774383 
TEST=covered by unit test. manually tested on kevin.

Change-Id: Ifdf74ad7e61a0d5ffa617e0a72622e2ddb9bbebd
Reviewed-on: https://chromium-review.googlesource.com/726262
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510235}
[modify] https://crrev.com/ca1309e1130def3f01b093f53e083258ea214e78/ash/display/display_manager_unittest.cc
[modify] https://crrev.com/ca1309e1130def3f01b093f53e083258ea214e78/ui/display/manager/chromeos/display_change_observer.cc

Labels: Merge-Request-62
Status: Started (was: Untriaged)
Labels: Merge-Request-63
Project Member

Comment 20 by sheriffbot@chromium.org, Oct 19 2017

Labels: -Merge-Request-62 Merge-Review-62 Hotlist-Merge-Review
This bug requires manual review: Request affecting a post-stable build
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Request-63 Merge-Approved-63
Labels: -Hotlist-Merge-Review -Merge-Review-62 Merge-Approved-62
Project Member

Comment 23 by bugdroid1@chromium.org, Oct 23 2017

Labels: -merge-approved-62 merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68052a3094af829b1b5f0dafcc3d63e488184f2c

commit 68052a3094af829b1b5f0dafcc3d63e488184f2c
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Mon Oct 23 19:26:53 2017

Do not re-register dislay info if exists

UpdateInternalDisplay should register the display info
only if
1) no internal display info  is registered. (it'll be
  treated as new display)
2) it's disconnected

BUG= 774383 
TEST=covered by unit test. manually tested on kevin.

(cherry picked from commit ca1309e1130def3f01b093f53e083258ea214e78)

Change-Id: Ifdf74ad7e61a0d5ffa617e0a72622e2ddb9bbebd
Reviewed-on: https://chromium-review.googlesource.com/726262
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#510235}
Reviewed-on: https://chromium-review.googlesource.com/733941
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#727}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/68052a3094af829b1b5f0dafcc3d63e488184f2c/ash/display/display_manager_unittest.cc
[modify] https://crrev.com/68052a3094af829b1b5f0dafcc3d63e488184f2c/ui/display/manager/chromeos/display_change_observer.cc

Project Member

Comment 24 by bugdroid1@chromium.org, Oct 23 2017

Labels: -merge-approved-63 merge-merged-3239
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ffc81e408f4eef98554553f0496768854a5ab42e

commit ffc81e408f4eef98554553f0496768854a5ab42e
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Mon Oct 23 19:28:44 2017

Do not re-register dislay info if exists

UpdateInternalDisplay should register the display info
only if
1) no internal display info  is registered. (it'll be
  treated as new display)
2) it's disconnected

BUG= 774383 
TEST=covered by unit test. manually tested on kevin.

Change-Id: Ifdf74ad7e61a0d5ffa617e0a72622e2ddb9bbebd
Reviewed-on: https://chromium-review.googlesource.com/726262
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#510235}(cherry picked from commit ca1309e1130def3f01b093f53e083258ea214e78)
Reviewed-on: https://chromium-review.googlesource.com/734123
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#160}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[modify] https://crrev.com/ffc81e408f4eef98554553f0496768854a5ab42e/ash/display/display_manager_unittest.cc
[modify] https://crrev.com/ffc81e408f4eef98554553f0496768854a5ab42e/ui/display/manager/chromeos/display_change_observer.cc

Status: Fixed (was: Started)

Sign in to add a comment